mbox series

[0/2] spi: imx: Fix cleanup in remove and convert to .remove_new()

Message ID 20230306065733.2170662-1-u.kleine-koenig@pengutronix.de
Headers
Series spi: imx: Fix cleanup in remove and convert to .remove_new() |

Message

Uwe Kleine-König March 6, 2023, 6:57 a.m. UTC 
  From: Uwe Kleine-König <uwe@kleine-koenig.org>

Hello,

this small series converts the spi-imx driver to .remove_new(). The
motivation for this tree-wide effort are drivers that don't properly
cleanup and return an error code. This is broken as this results in
resource leaks. The spi-imx driver is such a driver. The idea is that if
the remove callback returns void it's obvious that an early error return
is wrong.

Best regards
Uwe

Uwe Kleine-König (2):
  spi: imx: Don't skip cleanup in remove's error path
  spi: imx: Convert to platform remove callback returning void

 drivers/spi/spi-imx.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)


base-commit: b01fe98d34f3bed944a93bd8119fed80c856fad8

Comments

Mark Brown March 20, 2023, 6:50 p.m. UTC | #1 
On Mon, 06 Mar 2023 07:57:31 +0100, Uwe Kleine-König wrote:
> this small series converts the spi-imx driver to .remove_new(). The
> motivation for this tree-wide effort are drivers that don't properly
> cleanup and return an error code. This is broken as this results in
> resource leaks. The spi-imx driver is such a driver. The idea is that if
> the remove callback returns void it's obvious that an early error return
> is wrong.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: imx: Don't skip cleanup in remove's error path
      commit: 11951c9e3f364d7ae3b568a0e52c8335d43066b5
[2/2] spi: imx: Convert to platform remove callback returning void
      commit: 423e548127223d597bb65a149ebcb3c50ea08846

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark