From patchwork Thu Mar 2 04:32:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Imran Khan X-Patchwork-Id: 6014 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4039230wrd; Wed, 1 Mar 2023 20:34:41 -0800 (PST) X-Google-Smtp-Source: AK7set9mbJxs60iv5rdTO+e0c4inhnMjulHjBUb2Ltg3fSZDp+QD8ulIAC0fzMILLlaHbN9QV6ho X-Received: by 2002:a05:6a20:1442:b0:b8:4b1a:deb5 with SMTP id a2-20020a056a20144200b000b84b1adeb5mr968865pzi.18.1677731680854; Wed, 01 Mar 2023 20:34:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677731680; cv=none; d=google.com; s=arc-20160816; b=tuWdErflM4qfoY7qHMziuHGnb5y2sngrhAWl7+65LKCKVIRfDkL2X8jBmIxUZEHojT +EZWw+jVJwHrraqd6d4FZR9HZCbjzal74IOyXxrvZZKKq31Eda6y5rDV1maFShs+5a+D gVFkJHbJnzkTUSGZc3b6ZoRRmBYQfI12SBxJwd9WFpTRIFvxZdPzOmHjelqvzQ1pttqT irfRiIpMUnoko+/TILKxaKBKK3w2IYfpNABd+f0LQhbD/7yKXrltSqAFWFD4ZK+C9/H+ 9P0twf52Q8StHd9pWCyS0aFYSFke+mMQSuyG6gWJVblPkIbUY21DCIjz5VgCM05ycIlh 9h1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SzY3TSGeoxLLZE49ifvuQ2pf50uYOD/2poZwGo/0E5c=; b=irDVeb75Mn5wkhFGRkkYQjMojh4NXUOofzJzeo5UbVTWxlayu22ngUeiDPNGYsMmoy c4VQXL5LqbQtwGzG1Etq0WLyPqnmcV9g8VKBjmHbDIn8clQKCVh6zgqeQ999RtH9586Y Q7qk7LffVSKIm+p1rSMOMd+0pJ+OzgcC6xcTTcdTp9x5WRpw+9rZFtEDptYznWBo7Apu QClh26p3CwjvVg5iAUCJwEVlpOjO/dsSJerKLlqAxM5NxfQPjg24xE5a9mixsY2bPdDq 1d72AuGvPdjaAoUylK9agYUPHxK4nH+ZqQchHgCFoS7CueL2MDqG7lFMMXzYd+4r89gl OkEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=KkCb+iKj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k21-20020aa79735000000b005a8dc43d62fsi13491810pfg.139.2023.03.01.20.34.27; Wed, 01 Mar 2023 20:34:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=KkCb+iKj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbjCBEcR (ORCPT + 99 others); Wed, 1 Mar 2023 23:32:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjCBEcQ (ORCPT ); Wed, 1 Mar 2023 23:32:16 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3871E497C0; Wed, 1 Mar 2023 20:32:14 -0800 (PST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 321MxKgE017202; Thu, 2 Mar 2023 04:32:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2022-7-12; bh=SzY3TSGeoxLLZE49ifvuQ2pf50uYOD/2poZwGo/0E5c=; b=KkCb+iKjzv9Xc5Fe/bLcZE2B2XSItLWEiyhahDQ/Wza5Egp4Gp+1LZicvQx8v/qQ2Tb+ OolIYGMLToUC6PFjnprhdpptTtuCb82ByJHsIALEAtoqJfkcD17c19yOPP3SdcMVBDGK FatHEFaBeJX1lsiSCftkE/cZdIA6DTma29S1hW5OBgy+sYS3Qef2OcG70RoeYas0st6u HOkdABhVy0oPpqgxycdvkV3CYSn+nW13Z8J5ORs3I2BpkulWsUA1It/zX8gHeEVa07yW qEQ2n8tO1NhIXA8eV/0X/75YFKLUcrGzg19iBpEFfw2+Kp3GrI/FIyVchLdMPGqwXkzz IQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3nybaktnax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Mar 2023 04:32:09 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 3223eOfq031525; Thu, 2 Mar 2023 04:32:09 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3ny8sga7dg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Mar 2023 04:32:09 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3224W8eS012677; Thu, 2 Mar 2023 04:32:08 GMT Received: from localhost.localdomain (dhcp-10-191-129-161.vpn.oracle.com [10.191.129.161]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3ny8sga7bn-1; Thu, 02 Mar 2023 04:32:08 +0000 From: Imran Khan To: tj@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, joe.jin@oracle.com Subject: [PATCH 0/3] kernfs: Introduce separate rwsem to protect inode Date: Thu, 2 Mar 2023 15:32:00 +1100 Message-Id: <20230302043203.1695051-1-imran.f.khan@oracle.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-02_01,2023-03-01_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=991 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303020035 X-Proofpoint-GUID: rqgWtyKN2cg7YmGm9ddbBNJlis2Kj5K_ X-Proofpoint-ORIG-GUID: rqgWtyKN2cg7YmGm9ddbBNJlis2Kj5K_ X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759229175076936771?= X-GMAIL-MSGID: =?utf-8?q?1759229175076936771?= This change set is consolidating the changes discussed and/or mentioned in [1] and [2]. I have not received any feedback about any of the patches included in this change set, so I am rebasing them on current linux-next tip and bringing them all in one place. As mentioned in [1], since changing per-fs kernfs_rwsem into a hashed rwsem is not working for all scenarios, PATCH-1 here tries to address the same issue with the help of another newly introduced per-fs rwsem. PATCH-2 and PATCH-3 are basically resend of PATCH-1 and PATCH-2 respectively in [2]. It would be really helpful if I could get some feedback about this changeset so that we can reduce the kernfs_rwsem contention and make sysfs access more scalable for large-scale systems. The patches in this change set are as follows: PATCH-1: kernfs: Introduce separate rwsem to protect inode attributes. PATCH-2: kernfs: Use a per-fs rwsem to protect per-fs list of kernfs_super_info. PATCH-3: kernfs: change kernfs_rename_lock into a read-write lock. Imran Khan (3): kernfs: Introduce separate rwsem to protect inode attributes. Use a per-fs rwsem to protect per-fs list of kernfs_super_info. kernfs: change kernfs_rename_lock into a read-write lock. fs/kernfs/dir.c | 26 +++++++++++++++++--------- fs/kernfs/file.c | 2 ++ fs/kernfs/inode.c | 16 ++++++++-------- fs/kernfs/kernfs-internal.h | 2 ++ fs/kernfs/mount.c | 8 ++++---- 5 files changed, 33 insertions(+), 21 deletions(-) base-commit: 7f7a8831520f12a3cf894b0627641fad33971221 [1]:https://lore.kernel.org/all/74969b22-e0b6-30bd-a1f0-132f4b8485cf@oracle.com/ [2]:https://lore.kernel.org/all/20220810111017.2267160-1-imran.f.khan@oracle.com/