mbox series

[v2,0/3] perf : fix counting when initial delay configured

Message ID 20230302031146.2801588-1-changbin.du@huawei.com
Headers
Series perf : fix counting when initial delay configured |

Message

Changbin Du March 2, 2023, 3:11 a.m. UTC 
  The first one fixes the problem that counters are never enabled  when initial
delay configured.
The remaining two reuse the common field target::initial_delay for
record/ftrace/trace subcommands.

v2:
 - introduce common filed target::initial_delay

Changbin Du (3):
  perf stat: fix counting when initial delay configured
  perf record: reuse target::initial_delay
  perf: ftrace: reuse target::initial_delay

 tools/perf/builtin-ftrace.c | 10 +++++-----
 tools/perf/builtin-record.c | 12 ++++++------
 tools/perf/builtin-stat.c   | 15 +++++----------
 tools/perf/builtin-trace.c  |  8 ++++----
 tools/perf/util/evlist.c    |  6 +++---
 tools/perf/util/evsel.c     |  2 +-
 tools/perf/util/ftrace.h    |  1 -
 tools/perf/util/record.h    |  1 -
 tools/perf/util/stat.c      |  6 +-----
 tools/perf/util/stat.h      |  1 -
 tools/perf/util/target.h    | 12 ++++++++++++
 11 files changed, 37 insertions(+), 37 deletions(-)

Comments

Namhyung Kim March 2, 2023, 7:22 p.m. UTC | #1 
Hello,

On Wed, Mar 1, 2023 at 7:12 PM Changbin Du <changbin.du@huawei.com> wrote:
>
> The first one fixes the problem that counters are never enabled  when initial
> delay configured.
> The remaining two reuse the common field target::initial_delay for
> record/ftrace/trace subcommands.
>
> v2:
>  - introduce common filed target::initial_delay
>
> Changbin Du (3):
>   perf stat: fix counting when initial delay configured
>   perf record: reuse target::initial_delay
>   perf: ftrace: reuse target::initial_delay

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

>
>  tools/perf/builtin-ftrace.c | 10 +++++-----
>  tools/perf/builtin-record.c | 12 ++++++------
>  tools/perf/builtin-stat.c   | 15 +++++----------
>  tools/perf/builtin-trace.c  |  8 ++++----
>  tools/perf/util/evlist.c    |  6 +++---
>  tools/perf/util/evsel.c     |  2 +-
>  tools/perf/util/ftrace.h    |  1 -
>  tools/perf/util/record.h    |  1 -
>  tools/perf/util/stat.c      |  6 +-----
>  tools/perf/util/stat.h      |  1 -
>  tools/perf/util/target.h    | 12 ++++++++++++
>  11 files changed, 37 insertions(+), 37 deletions(-)
>
> --
> 2.25.1
>
Arnaldo Carvalho de Melo March 2, 2023, 8:40 p.m. UTC | #2 
Em Thu, Mar 02, 2023 at 11:22:37AM -0800, Namhyung Kim escreveu:
> Hello,
> 
> On Wed, Mar 1, 2023 at 7:12 PM Changbin Du <changbin.du@huawei.com> wrote:
> >
> > The first one fixes the problem that counters are never enabled  when initial
> > delay configured.
> > The remaining two reuse the common field target::initial_delay for
> > record/ftrace/trace subcommands.
> >
> > v2:
> >  - introduce common filed target::initial_delay
> >
> > Changbin Du (3):
> >   perf stat: fix counting when initial delay configured
> >   perf record: reuse target::initial_delay
> >   perf: ftrace: reuse target::initial_delay
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applying the first to perf-tools (old perf/urgent) and the rest
to perf-tools-next (old perf/core).

- Arnaldo
 
> Thanks,
> Namhyung
> 
> >
> >  tools/perf/builtin-ftrace.c | 10 +++++-----
> >  tools/perf/builtin-record.c | 12 ++++++------
> >  tools/perf/builtin-stat.c   | 15 +++++----------
> >  tools/perf/builtin-trace.c  |  8 ++++----
> >  tools/perf/util/evlist.c    |  6 +++---
> >  tools/perf/util/evsel.c     |  2 +-
> >  tools/perf/util/ftrace.h    |  1 -
> >  tools/perf/util/record.h    |  1 -
> >  tools/perf/util/stat.c      |  6 +-----
> >  tools/perf/util/stat.h      |  1 -
> >  tools/perf/util/target.h    | 12 ++++++++++++
> >  11 files changed, 37 insertions(+), 37 deletions(-)
> >
> > --
> > 2.25.1
> >
Changbin Du March 10, 2023, 2:37 a.m. UTC | #3 
On Thu, Mar 02, 2023 at 05:40:16PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Mar 02, 2023 at 11:22:37AM -0800, Namhyung Kim escreveu:
> > Hello,
> > 
> > On Wed, Mar 1, 2023 at 7:12 PM Changbin Du <changbin.du@huawei.com> wrote:
> > >
> > > The first one fixes the problem that counters are never enabled  when initial
> > > delay configured.
> > > The remaining two reuse the common field target::initial_delay for
> > > record/ftrace/trace subcommands.
> > >
> > > v2:
> > >  - introduce common filed target::initial_delay
> > >
> > > Changbin Du (3):
> > >   perf stat: fix counting when initial delay configured
> > >   perf record: reuse target::initial_delay
> > >   perf: ftrace: reuse target::initial_delay
> > 
> > Acked-by: Namhyung Kim <namhyung@kernel.org>
> 
> Thanks, applying the first to perf-tools (old perf/urgent) and the rest
> to perf-tools-next (old perf/core).
> 
> - Arnaldo
> 
Hi Arnaldo, it seems only the first one is applied. The remaining two patches
are missed in your tree.
 - perf record: reuse target::initial_delay
 - perf: ftrace: reuse target::initial_delay
Arnaldo Carvalho de Melo March 10, 2023, 3:05 p.m. UTC | #4 
Em Fri, Mar 10, 2023 at 10:37:14AM +0800, Changbin Du escreveu:
> On Thu, Mar 02, 2023 at 05:40:16PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Mar 02, 2023 at 11:22:37AM -0800, Namhyung Kim escreveu:
> > > Hello,
> > > 
> > > On Wed, Mar 1, 2023 at 7:12 PM Changbin Du <changbin.du@huawei.com> wrote:
> > > >
> > > > The first one fixes the problem that counters are never enabled  when initial
> > > > delay configured.
> > > > The remaining two reuse the common field target::initial_delay for
> > > > record/ftrace/trace subcommands.
> > > >
> > > > v2:
> > > >  - introduce common filed target::initial_delay
> > > >
> > > > Changbin Du (3):
> > > >   perf stat: fix counting when initial delay configured
> > > >   perf record: reuse target::initial_delay
> > > >   perf: ftrace: reuse target::initial_delay
> > > 
> > > Acked-by: Namhyung Kim <namhyung@kernel.org>
> > 
> > Thanks, applying the first to perf-tools (old perf/urgent) and the rest
> > to perf-tools-next (old perf/core).
> > 
> > - Arnaldo
> > 
> Hi Arnaldo, it seems only the first one is applied. The remaining two patches
> are missed in your tree.
>  - perf record: reuse target::initial_delay
>  - perf: ftrace: reuse target::initial_delay

Those are not fixes, right? I mentioned that I would apply it after the
first is merged.

- Arnaldo
Changbin Du March 13, 2023, 1:58 a.m. UTC | #5 
On Fri, Mar 10, 2023 at 12:05:38PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 10, 2023 at 10:37:14AM +0800, Changbin Du escreveu:
> > On Thu, Mar 02, 2023 at 05:40:16PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Mar 02, 2023 at 11:22:37AM -0800, Namhyung Kim escreveu:
> > > > Hello,
> > > > 
> > > > On Wed, Mar 1, 2023 at 7:12 PM Changbin Du <changbin.du@huawei.com> wrote:
> > > > >
> > > > > The first one fixes the problem that counters are never enabled  when initial
> > > > > delay configured.
> > > > > The remaining two reuse the common field target::initial_delay for
> > > > > record/ftrace/trace subcommands.
> > > > >
> > > > > v2:
> > > > >  - introduce common filed target::initial_delay
> > > > >
> > > > > Changbin Du (3):
> > > > >   perf stat: fix counting when initial delay configured
> > > > >   perf record: reuse target::initial_delay
> > > > >   perf: ftrace: reuse target::initial_delay
> > > > 
> > > > Acked-by: Namhyung Kim <namhyung@kernel.org>
> > > 
> > > Thanks, applying the first to perf-tools (old perf/urgent) and the rest
> > > to perf-tools-next (old perf/core).
> > > 
> > > - Arnaldo
> > > 
> > Hi Arnaldo, it seems only the first one is applied. The remaining two patches
> > are missed in your tree.
> >  - perf record: reuse target::initial_delay
> >  - perf: ftrace: reuse target::initial_delay
> 
> Those are not fixes, right? I mentioned that I would apply it after the
> first is merged.
>
Sorry, I misunderstood your previous reply :)

> - Arnaldo