mbox series

[v2,0/3] Add "mclk" support for maxim,max9867

Message ID 20230302-max9867-v2-0-fd2036d5e825@skidata.com
Headers
Series Add "mclk" support for maxim,max9867 |

Message

Richard Leitner March 3, 2023, 10:04 a.m. UTC 
  This series adds support for the clocks properties in the
maxim,max9867 bindings. Furthermore the binding definitions are
converted from txt to yaml.

The clock property is needed to define the mclk for one of our
boards which uses the the i.MX8MP SAI MCLK as clock for the
maxim,max9867.

ChangeLog:
v2:
 - dt-bindings:
  - add "additionalProperties: false" property
  - remove "clock-names" property
  - fix $id
  - fix example
 - max9867:
  - Enable and prepare mclk on SND_SOC_BIAS_ON
  - disable and unprepare mclk on SND_SOC_BIAS_OFF
  - drop "mclk" clock-name

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
Benjamin Bara (1):
      ASoC: maxim,max9867: add "mclk" support

Richard Leitner (2):
      ASoC: dt-bindings: maxim,max9867: convert txt bindings to yaml
      ASoC: dt-bindings: maxim,max9867: add clocks property

 .../devicetree/bindings/sound/max9867.txt          | 17 ------
 .../devicetree/bindings/sound/maxim,max9867.yaml   | 66 ++++++++++++++++++++++
 sound/soc/codecs/max9867.c                         | 19 ++++++-
 3 files changed, 83 insertions(+), 19 deletions(-)
---
base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
change-id: 20230302-max9867-49081908a2ab

Best regards,

Comments

Mark Brown March 6, 2023, 1:32 p.m. UTC | #1 
On Fri, 03 Mar 2023 11:04:00 +0100, richard.leitner@linux.dev wrote:
> This series adds support for the clocks properties in the
> maxim,max9867 bindings. Furthermore the binding definitions are
> converted from txt to yaml.
> 
> The clock property is needed to define the mclk for one of our
> boards which uses the the i.MX8MP SAI MCLK as clock for the
> maxim,max9867.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: dt-bindings: maxim,max9867: convert txt bindings to yaml
      commit: 6668f70abeea30f4674b2fdbc4232d5c3611b272
[2/3] ASoC: dt-bindings: maxim,max9867: add clocks property
      commit: d63e55b3e8ec90da69107f32038f3059d7317cc5
[3/3] ASoC: maxim,max9867: add "mclk" support
      commit: 448b06ba107d925d59d02781acdd2e4ad12dda0b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Richard Leitner March 28, 2023, 5:59 a.m. UTC | #2 
Hi Mark, Hi Krzysztof,

sorry for coming back to you on this series, but I have a question on
the "workflow"...

On Mon, Mar 06, 2023 at 01:32:10PM +0000, Mark Brown wrote:
> On Fri, 03 Mar 2023 11:04:00 +0100, richard.leitner@linux.dev wrote:
> > This series adds support for the clocks properties in the
> > maxim,max9867 bindings. Furthermore the binding definitions are
> > converted from txt to yaml.
> > 
> > The clock property is needed to define the mclk for one of our
> > boards which uses the the i.MX8MP SAI MCLK as clock for the
> > maxim,max9867.
> > 
> > [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/3] ASoC: dt-bindings: maxim,max9867: convert txt bindings to yaml
>       commit: 6668f70abeea30f4674b2fdbc4232d5c3611b272
> [2/3] ASoC: dt-bindings: maxim,max9867: add clocks property
>       commit: d63e55b3e8ec90da69107f32038f3059d7317cc5
> [3/3] ASoC: maxim,max9867: add "mclk" support
>       commit: 448b06ba107d925d59d02781acdd2e4ad12dda0b
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.

As Krzysztof requested some changes on the clocks property dt-bindings
patch (#2) commit message... How should I handle this?

The changes requested on the patch content (dts example) should be sent
as incremental patch to the original series, I guess?

see https://lore.kernel.org/lkml/45d306d3-8efb-12ac-0a83-f01ca2982b0a@linaro.org/

> 
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
> 
> Thanks,
> Mark
> 

Thanks & regards;rl
Krzysztof Kozlowski March 28, 2023, 7:41 a.m. UTC | #3 
On 28/03/2023 07:59, Richard Leitner wrote:
>> should be sent as incremental updates against current git, existing
>> patches will not be replaced.
> 
> As Krzysztof requested some changes on the clocks property dt-bindings
> patch (#2) commit message... How should I handle this?
> 
> The changes requested on the patch content (dts example) should be sent
> as incremental patch to the original series, I guess?

Incremental updates, so new patch. Rebase on maintainer's tree next
branch or linux-next (usually linux-next is the easiest but for
cross-tree patches might create inapplicable series).

Best regards,
Krzysztof
Mark Brown March 28, 2023, 12:39 p.m. UTC | #4 
On Tue, Mar 28, 2023 at 07:59:16AM +0200, Richard Leitner wrote:

> As Krzysztof requested some changes on the clocks property dt-bindings
> patch (#2) commit message... How should I handle this?

> The changes requested on the patch content (dts example) should be sent
> as incremental patch to the original series, I guess?

If it's just the commit message it's too late.  Otherwise incremental
patches against current git.