mbox series

[v2,0/2] arch/*/io.h: remove ioremap_uc in some architectures

Message ID 20230301102208.148490-1-bhe@redhat.com
Headers
Series arch/*/io.h: remove ioremap_uc in some architectures |

Message

Baoquan He March 1, 2023, 10:22 a.m. UTC 
  This patchset tries to remove ioremap_uc() in the current architectures
except of x86 and ia64. They will use the default ioremap_uc definition
in <asm-generic/io.h> which returns NULL.

If any arch sees a breakage caused by the default ioremap_uc(), it can
provide a sepcific one for its own usage.

v1->v2:
  - Update log of patch 2, and document related to ioremap_uc()
    according to Geert's comment.
  - Add Geert's Acked-by.

Baoquan He (2):
  mips: add <asm-generic/io.h> including
  arch/*/io.h: remove ioremap_uc in some architectures

 Documentation/driver-api/device-io.rst | 11 ++++--
 arch/alpha/include/asm/io.h            |  1 -
 arch/hexagon/include/asm/io.h          |  3 --
 arch/m68k/include/asm/kmap.h           |  1 -
 arch/mips/include/asm/io.h             | 47 +++++++++++++++++++++++++-
 arch/mips/include/asm/mmiowb.h         |  2 --
 arch/parisc/include/asm/io.h           |  2 --
 arch/powerpc/include/asm/io.h          |  1 -
 arch/sh/include/asm/io.h               |  2 --
 arch/sparc/include/asm/io_64.h         |  1 -
 10 files changed, 55 insertions(+), 16 deletions(-)

Comments

Baoquan He March 1, 2023, 1:37 p.m. UTC | #1 
On 03/01/23 at 06:22pm, Baoquan He wrote:
> This patchset tries to remove ioremap_uc() in the current architectures
> except of x86 and ia64. They will use the default ioremap_uc definition
> in <asm-generic/io.h> which returns NULL.
> 
> If any arch sees a breakage caused by the default ioremap_uc(), it can
> provide a sepcific one for its own usage.

Forgot mentioning this patchset is based on below patchset.

[PATCH v5 00/17] mm: ioremap:  Convert architectures to take GENERIC_IOREMAP way
https://lore.kernel.org/all/20230301034247.136007-1-bhe@redhat.com/T/#u

> 
> v1->v2:
>   - Update log of patch 2, and document related to ioremap_uc()
>     according to Geert's comment.
>   - Add Geert's Acked-by.
> 
> Baoquan He (2):
>   mips: add <asm-generic/io.h> including
>   arch/*/io.h: remove ioremap_uc in some architectures
> 
>  Documentation/driver-api/device-io.rst | 11 ++++--
>  arch/alpha/include/asm/io.h            |  1 -
>  arch/hexagon/include/asm/io.h          |  3 --
>  arch/m68k/include/asm/kmap.h           |  1 -
>  arch/mips/include/asm/io.h             | 47 +++++++++++++++++++++++++-
>  arch/mips/include/asm/mmiowb.h         |  2 --
>  arch/parisc/include/asm/io.h           |  2 --
>  arch/powerpc/include/asm/io.h          |  1 -
>  arch/sh/include/asm/io.h               |  2 --
>  arch/sparc/include/asm/io_64.h         |  1 -
>  10 files changed, 55 insertions(+), 16 deletions(-)
> 
> -- 
> 2.34.1
>
Luis Chamberlain March 2, 2023, 7:57 p.m. UTC | #2 
On Wed, Mar 01, 2023 at 06:22:06PM +0800, Baoquan He wrote:
> This patchset tries to remove ioremap_uc() in the current architectures
> except of x86 and ia64. They will use the default ioremap_uc definition
> in <asm-generic/io.h> which returns NULL.
> 
> If any arch sees a breakage caused by the default ioremap_uc(), it can
> provide a sepcific one for its own usage.

Feel free to add:

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis
Baoquan He March 3, 2023, 10:24 a.m. UTC | #3 
On 03/02/23 at 11:57am, Luis Chamberlain wrote:
> On Wed, Mar 01, 2023 at 06:22:06PM +0800, Baoquan He wrote:
> > This patchset tries to remove ioremap_uc() in the current architectures
> > except of x86 and ia64. They will use the default ioremap_uc definition
> > in <asm-generic/io.h> which returns NULL.
> > 
> > If any arch sees a breakage caused by the default ioremap_uc(), it can
> > provide a sepcific one for its own usage.
> 
> Feel free to add:
> 
> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

Thanks for check. I made some changes according to comments, will repost.
Please help review.