From patchwork Wed Mar 1 07:34:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 5969 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3491124wrd; Tue, 28 Feb 2023 23:41:07 -0800 (PST) X-Google-Smtp-Source: AK7set8YNAWHUJnEN6owaYG9ppdKeXCpOx2F1hnw65ghag/MKvQYaOTakn20AIWQquKs580n5fv5 X-Received: by 2002:aa7:9830:0:b0:5b5:8e27:1394 with SMTP id q16-20020aa79830000000b005b58e271394mr5089248pfl.34.1677656466989; Tue, 28 Feb 2023 23:41:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677656466; cv=none; d=google.com; s=arc-20160816; b=o6kNO1o1Oxe3UlbH1lDsontxRWegOzOV3VVJIsnuIdIGD/jdLkMISzLbtJX1aU8MLz Naz3bPxrfBd1eZun+qGP4QyxymIlFwbvxdAD0CqZTAw4Lz0GG36tEQPgrqIrtkCyEsjK s14ZD2w4k9P8YAD2qQk1/P7RTCCkfpUWPFCFfQtya4rAYvsAXtJfXtgl0AEhiAfq3mfF GOPZirWKWQgvWpUfhGJt1XCpzvSA2r6wBfhPuRvhUnQIXozThNSeN8dggEr86psIBpft krkav7xPknCbkIPgtKabMMWERHczSvHboFGwSciT3MRhsAIR9NQ8vo0vxiU7LbqbDHn3 T09A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=s1Um63dYaVsSi9NwW9bcqeTE7Mfb+ymQ6zpveu6DYgM=; b=LTpnS/QT4+ru+L7yUDCJEPd9EkTmIRLW/yEW4Pa/SYUWd+KL4jSwyNjwYgjev/nB2W eo2+dYfz2iaHXrW4F4Thfowleri/J9I82hxEynIaK14dsfncHbuEt+/wBNKMVz0VstV7 DKC8UwIHw/748wAuYBrzVpP/RkNKSgpbowrf9w/7Jv3WekNQrkVo2HUh4Yql2qg7gp6f l/0QuBPIkTdYx3cfKiiq9tKd7s25njt+UJGCaugDsb2N0TX22/aFRpP4K8dak/pn+t1P aas6vNmJmVQnsnxHi5Lw+yfa9nKwUwDM/TugVQVp6ax0faUW6mmbPeQdvRb81YgtSpdH ndcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=vy3kE4HW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a63d94e000000b004fbc2116e12si11650710pgj.587.2023.02.28.23.40.53; Tue, 28 Feb 2023 23:41:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=vy3kE4HW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbjCAHeh (ORCPT + 99 others); Wed, 1 Mar 2023 02:34:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbjCAHef (ORCPT ); Wed, 1 Mar 2023 02:34:35 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8636B392AB; Tue, 28 Feb 2023 23:34:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1677656072; x=1709192072; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KWZHzc9wIEfs7HHJ0zPtwqbEGbgEkAvB8xct4rTxPg4=; b=vy3kE4HWEhuxtl4Zn/Cf/0FHfETKwS5yfdGZ7KmSmVnczZwjZCoATof9 rl8dABzYNL7IUs0qaBvr+62bjNCmLgd4kUeaNTd3KrY78GevJQgvDSuJZ pe5H8F8SYVc8tJ4R6sGjGP4dKHDbovgcb6UK94cQNExdw0wzzWd7WiRAx NjyYzRqjym9wZs+2DJos2IjBofDWneKzd2kjynndwI5VAKCDEk/6GHw2Y RD+yPDpFiN9hDwP729+r+3dSrLYNtznMcSCxgr7eFE6a9fiQ592Jz/miD 3nEZ7C3yuFqV0b7iLaNq/7Fa+7OhJcAzrLYK9Rcj/cfWVocER2fqoK/Za g==; X-IronPort-AV: E=Sophos;i="5.98,224,1673938800"; d="scan'208";a="214162822" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Mar 2023 00:34:31 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Mar 2023 00:34:30 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Wed, 1 Mar 2023 00:34:26 -0700 From: shravan kumar To: , , , , , , CC: , , , , , , , , Jacopo Mondi , "Sakari Ailus" Subject: [PATCH v12 0/5] media: i2c: imx334: support lower bandwidth mode Date: Wed, 1 Mar 2023 13:04:07 +0530 Message-ID: <20230301073412.1204574-1-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759150307638165158?= X-GMAIL-MSGID: =?utf-8?q?1759150307638165158?= From: Shravan Chippa Hi This patch series is for imx334 sensor driver support for lower bandwidth Some platforms may not be capable of supporting the bandwidth required for 12 bit or 3840x2160@60 resolutions. Add support for dynamically selecting 10 bit and 1920x1080@30 resolutions. V11 -> V12 Update default link frequency from device tree max link frequency value. Update init_cfg() function to update the link frequency menu_skip_mask value. V10 -> V11 Changed veriable type int to unsigned int Updated CC list V10 -> V10 PATCH RESEND with updated CC list V9 -> V10 Added new dt-binding patch added support for handling multiple link-frequncy minor changes on coding style V8 -> V9 -Updated all array values with samall later to get unifamity in mode array values -corrected hblank_min, hbalank, pix_clk for 1920x1080@30 updated according to link frequency -corrected mutex use for imx334_get_format_code function -corrected the fmt->format.code value assinment -in function imx334_get_format_code variable "i" value comparision corrected V7 -> V8 -patch drop "mimx334-odify-link-frequency" as per the commnets linkfrquncy will be half of the line bandwidth -changed 1920x1080@30 mode link frequency from (891000000Mbps) to (445500000Mbps). linkfrquncy will be half of the line bandwidth V6 -> V7 Reloved: kernel test robot warning "drivers/media/i2c/imx334.c:767:15: warning: unused variable 'i' " V5 -> V6 -Drop the dt-binding patch -Optimize the code to avoid duplicating the lines -Added proper mutex while imx334_mbus_codes array -Modified Function __v4l2_ctrl_modify_range arguments as per the review commants -Added hblank dummy set ctrl -Removed Redundant comment -corrected code alignment -All commit msgs are re-written V4 -> V5 -Added 5 more patchs as per the review comments witch has below updates -Updated 1782000000Mbps link frequency for 3840x2160@60 as per the mode values -Updated 1782000000Mbps link frequency in dt-bindings also -Updated 3840x2160@60 mode array with default(reset) values -Updated hblank __v4l2_ctrl_s_ctrl() to __v4l2_ctrl_modify_range() Suggested-by: Jacopo Mondi -Current mode update only when we try to set V4L2_SUBDEV_FORMAT_ACTIVE -Added link frequency (891000000Mbps) and pixel rate (74250000) to 1920x1080@30 mode Suggested-by: Sakari Ailus -Updated commit message V3 -> V4 - Make the 12 bit and 3840x2160 as default - Set bus code SRGGB12 if set format fails V2 -> V3 - Fixed the warning reported by kernel test robot V1 -> V2 - Addressed the review comment given by Jacopo Mondi, Which has bug in imx334_enum_frame_size() loop function, - Renamed array codes[] to imx334_mbus_codes[] Shravan Chippa (5): media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range media: i2c: imx334: add missing reset values for mode 3840x2160_regs[] media: i2c: imx334: support lower bandwidth mode dt-bindings: media: i2c: imx334 add new link_freq media: i2c: imx334: update pixel and link frequency .../bindings/media/i2c/sony,imx334.yaml | 2 +- drivers/media/i2c/imx334.c | 367 ++++++++++++++++-- 2 files changed, 330 insertions(+), 39 deletions(-)