From patchwork Tue Feb 28 22:38:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 5960 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3292170wrd; Tue, 28 Feb 2023 14:42:48 -0800 (PST) X-Google-Smtp-Source: AK7set9LpJGPLaU+L7OVr1J80U33ebJuozqe6xgsoolyUf9y1AZZF39S3DWCm2xqllR7c+rCfPvS X-Received: by 2002:aa7:c989:0:b0:4ad:5220:79ef with SMTP id c9-20020aa7c989000000b004ad522079efmr5212528edt.8.1677624168453; Tue, 28 Feb 2023 14:42:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677624168; cv=none; d=google.com; s=arc-20160816; b=lP3Iz5H8NRnVh+scmmQ2NBiOUYcsgloQwXlM/fBPGt/rzR6Q1hy5YF6jIWoGgYkwDN QmuP2ON9n1h8FGiKCd77DRCGTBjxJwZTBOXGLQ63ms95vccKYiowbTO+V3aBWHh7fKdk gQawg2oJJjGUDV5cZNUMNBn9uUOKcV0PRpA5Z9tX7PiV1YccfX7dwAMjsJr5jm4ET61V KhYebZqDMvsfw/xxd7ffPrCq6/QhA3jNuN2YH0G9BgSCkrRDLpvUkv+8eQBkKdJhUnyM k9EkdnMY4r3PsaPMdxpO0yb5dgp+s/TpnAQknTbO6evErIgLdv1zC8obIofUlfN1p5k2 xdtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=EJkMR1yW1VwQXrb2e38VKDBxR+/bnLnE1QvDu6Bz41c=; b=vf8KOnsjin2Fky6pBHFBAmp46AaPQjv7Z9o2sknb16ZdhEjyoCnTVW5uwFuDBLuR2B syQHwZy8gtm64vq+QUjt0jpzMstxH1uERY5dWarrnEju93Au7MIwXm+14I7glyFo/LSy ssSgOQKev35GCH6301wSYczqc77Lq8tcKTdOq/yKGndGpQualHolK0li+OXJQ7CGXdtt iQW84l2eC7SXCEeHxQK8p146su2Y8w1PuWLDhR+DW8zcFfzSU1BbIjbKiwqJH3WPtKoE 0IQ4qbLAZlI2gs6kE/noTMPadwnLmdhepLkEQFnF0ggHXZLrlKm51DQvSV9FSQdm88js TmBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aaiHvzyo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i22-20020aa7dd16000000b004acb2c92ba6si12747916edv.79.2023.02.28.14.42.25; Tue, 28 Feb 2023 14:42:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aaiHvzyo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbjB1Wjk (ORCPT + 99 others); Tue, 28 Feb 2023 17:39:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbjB1Wjg (ORCPT ); Tue, 28 Feb 2023 17:39:36 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56F4B16304 for ; Tue, 28 Feb 2023 14:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677623926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EJkMR1yW1VwQXrb2e38VKDBxR+/bnLnE1QvDu6Bz41c=; b=aaiHvzyo5dKac1bZEMqVsUFiJ4VQSG/qoFP/7ffHSNLbMgacJirH0JA9tyJ8Dz9G9v88Xf h9jXeq/tD4CJTqgvf220CCE67a/WYBQnfx9m7NBgRh7kMXU6cqhoM3n3+II86pRb7vixUc LgH8dm8AC3C402z9orexybRrbsvKADg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201-BVQoJkQ5ObCj-2C6iWfEpw-1; Tue, 28 Feb 2023 17:38:43 -0500 X-MC-Unique: BVQoJkQ5ObCj-2C6iWfEpw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5AFCF3810B07; Tue, 28 Feb 2023 22:38:42 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E66E2026D4B; Tue, 28 Feb 2023 22:38:40 +0000 (UTC) From: David Howells To: Steve French Cc: David Howells , Shyam Prasad N , Rohith Surabattula , Tom Talpey , Stefan Metzmacher , Jeff Layton , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/1] smb3: Memory leak/page refcount overflow fix Date: Tue, 28 Feb 2023 22:38:37 +0000 Message-Id: <20230228223838.3794807-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759116439756959626?= X-GMAIL-MSGID: =?utf-8?q?1759116439756959626?= Hi Steve, Here's another fix patch for you. It fixes a leak of the pages extracted for direct I/O. This was causing the page refcount to overflow and become negative and then try_grab_page() would always fail on it. I've pushed the patch here also: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-cifs David David Howells (1): cifs: Fix memory leak in direct I/O fs/cifs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)