From patchwork Tue Feb 28 16:46:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Lobakin X-Patchwork-Id: 5946 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3125941wrd; Tue, 28 Feb 2023 08:49:13 -0800 (PST) X-Google-Smtp-Source: AK7set+w5leC4YCn7/hNWMyhzfGo595VPo6NKZiSX3zDatudbHZcZXQOLK9qE05GpVwdafD6snlf X-Received: by 2002:a05:6a00:2a04:b0:5a9:d0e6:6a85 with SMTP id ce4-20020a056a002a0400b005a9d0e66a85mr3631523pfb.7.1677602953521; Tue, 28 Feb 2023 08:49:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677602953; cv=none; d=google.com; s=arc-20160816; b=KHKDEpij3MBdMD+hL1FgO/ohXx3hG2+9uCNhkDrsBAApQF0F0+FG46p54gfltMzrs4 dfgycTkZrqeCoWExOymKypRFESZhxJzuPMR+pFW4b/G3FZ9mpfFewIEsajwwZBnw+O7y +d22zXln5DtZd/LB9uJFd1S8Z/POgxBBQPa8JBn7AFEUxrhkobzKiLFoMGULThvQFJaA ryNz88nOCJE4c9Bm3hHO9tgwN+Ufo9RZC4Vqwf+12dxricmmKK6cZSal4jd4rbjvoAFP P7odPYoB1uixaIn1hiKZdashWx4D+y9CzH8ZTiuuvfs88YIyrfMhkP9BuGyTV0Whe+nB IyzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=A5lB/pfLl/oOcVA3MwtHDPsB6sJv04K5pthLXSu0CLs=; b=LNQOiof1tUUEqQmF2KBOKionpAhKrQHbk097m+5ULkJ92AOzccVl+K+ndphhwWbRLT CITI6j0phMzv/Q3lLYX/1+EONd8BnEMaODUrL3ypW0EvkyYlZL01HURlNdpqxPqc2YO4 DrV+B0T3L00Jvzshd4qmfjg4xm6/5Yo7zeZU7XUl8htQGBWUP55CIz279/lVB5B155+u 4qytZv6vwr/CaORYou56ckTuyRsbhNeUi7hciboK0Xj2sPc3w09oHvrBP/La4y/9E0O/ crGHzkBT/WOrDGEa1tZz5K/ZnG13H4u3G4CzPGIgytArQ7Imy6rbaIQqbxsDf1gxpGEK UACg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GIITSovH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k22-20020a63ff16000000b004fbd7827010si1277694pgi.263.2023.02.28.08.48.59; Tue, 28 Feb 2023 08:49:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GIITSovH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjB1Qsi (ORCPT + 99 others); Tue, 28 Feb 2023 11:48:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbjB1Qsh (ORCPT ); Tue, 28 Feb 2023 11:48:37 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A51AE6EAE; Tue, 28 Feb 2023 08:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677602886; x=1709138886; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WRHLtls8wXHkKG0wPUdAzJHiEECJD6P2u5mrgkq32og=; b=GIITSovHGRKPNNTtFu04OQGPMroln0wHW/qqp0zCw8RKm17eppp+CFws /PUYx1LkfG9HzeeORUnfDR2tB0YnNvcsKjlmd14wsubbFTadTjxdS7klW n9oTsrlgL7i41IbRyNU/A/K9xeXlMmTy0OYlHv7BMZ6gJv8uWL21EvvBD icJ+BV2gcU7tlii29k/2gyfhtaBBsiOXwQFzoX5TjPuuTTEtHfHF+7jdi SaK0GFNAczUaWQbkh0/rKSVg/0JeN1s8xl4Cbdtcxfz3v5LaZoV4aNw2v FThPn5cmwovc4gLUJYnb07o152pMgB0iYdhnmie0jWGd+/5Gbs6tGEKlF Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10635"; a="317986827" X-IronPort-AV: E=Sophos;i="5.98,222,1673942400"; d="scan'208";a="317986827" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 08:48:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10635"; a="624107465" X-IronPort-AV: E=Sophos;i="5.98,222,1673942400"; d="scan'208";a="624107465" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orsmga003.jf.intel.com with ESMTP; 28 Feb 2023 08:48:03 -0800 Received: from newjersey.igk.intel.com (newjersey.igk.intel.com [10.102.20.203]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 07A41369ED; Tue, 28 Feb 2023 16:48:01 +0000 (GMT) From: Alexander Lobakin To: Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Alexander Lobakin , Michal Kubiak , Larysa Zaremba , Maciej Fijalkowski , Jesse Brandeburg , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 0/2] iavf: fix double-broken HW hash report Date: Tue, 28 Feb 2023 17:46:11 +0100 Message-Id: <20230228164613.1360409-1-aleksander.lobakin@intel.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759094194388602954?= X-GMAIL-MSGID: =?utf-8?q?1759094194388602954?= Currently, passing HW hash from descriptors to skb is broken two times. The first bug effectively disables hash from being filled at all, unless %NETIF_F_RXHASH is *disabled* via Ethtool. The second incorrectly says that IPv6 UDP packets are L3, which also triggers CPU hashing when needed (the networking core treats only L4 HW hash as "true"). The very same problems were fixed in i40e and ice, but not in iavf, although each of the original commits bugged at least two drivers. It's never too late (I hope), so fix iavf this time. Alexander Lobakin (2): iavf: fix inverted Rx hash condition leading to disabled hash iavf: fix non-tunneled IPv6 UDP packet type and hashing drivers/net/ethernet/intel/iavf/iavf_common.c | 2 +- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- To Tony: this is very trivial and tested for a while already, I hope it could hit one of the first couple RCs :p