mbox series

[0/4] pwm: Ensure .polarity is set in .get_state()

Message ID 20230228135508.1798428-1-u.kleine-koenig@pengutronix.de
Headers
Series pwm: Ensure .polarity is set in .get_state() |

Message

Uwe Kleine-König Feb. 28, 2023, 1:55 p.m. UTC 
  Hello,

in the context of the discussion with Munehisa Kamata about the meson driver
not setting .polarity in .get_state() I checked the other drivers for the same
issue. The identified drivers are fixed here. For three of them
zero-initializing *state would be good enough, still I think setting the
polarity explicitly is a good idea. For the hibvt driver (that supports
both polarities) the change is a real improvement.

Note I didn't touch the meson driver here that requires some non-trivial
updates that I don't want to tackle without hardware to test.

Best regards
Uwe

Uwe Kleine-König (4):
  pwm: hibvt: Explicitly set .polarity in .get_state()
  pwm: cros-ec: Explicitly set .polarity in .get_state()
  pwm: iqs620a: Explicitly set .polarity in .get_state()
  pwm: sprd: Explicitly set .polarity in .get_state()

 drivers/pwm/pwm-cros-ec.c | 1 +
 drivers/pwm/pwm-hibvt.c   | 1 +
 drivers/pwm/pwm-iqs620a.c | 1 +
 drivers/pwm/pwm-sprd.c    | 1 +
 4 files changed, 4 insertions(+)


base-commit: 7a77daf8223e772a225d6aa6202a5b1ae2392caf

Comments

patchwork-bot+chrome-platform@kernel.org May 8, 2023, 3:45 a.m. UTC | #1 
Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Thierry Reding <thierry.reding@gmail.com>:

On Tue, 28 Feb 2023 14:55:04 +0100 you wrote:
> Hello,
> 
> in the context of the discussion with Munehisa Kamata about the meson driver
> not setting .polarity in .get_state() I checked the other drivers for the same
> issue. The identified drivers are fixed here. For three of them
> zero-initializing *state would be good enough, still I think setting the
> polarity explicitly is a good idea. For the hibvt driver (that supports
> both polarities) the change is a real improvement.
> 
> [...]

Here is the summary with links:
  - [2/4] pwm: cros-ec: Explicitly set .polarity in .get_state()
    https://git.kernel.org/chrome-platform/c/30006b77c7e1

You are awesome, thank you!
patchwork-bot+chrome-platform@kernel.org May 8, 2023, 3:56 a.m. UTC | #2 
Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Thierry Reding <thierry.reding@gmail.com>:

On Tue, 28 Feb 2023 14:55:04 +0100 you wrote:
> Hello,
> 
> in the context of the discussion with Munehisa Kamata about the meson driver
> not setting .polarity in .get_state() I checked the other drivers for the same
> issue. The identified drivers are fixed here. For three of them
> zero-initializing *state would be good enough, still I think setting the
> polarity explicitly is a good idea. For the hibvt driver (that supports
> both polarities) the change is a real improvement.
> 
> [...]

Here is the summary with links:
  - [2/4] pwm: cros-ec: Explicitly set .polarity in .get_state()
    https://git.kernel.org/chrome-platform/c/30006b77c7e1

You are awesome, thank you!