Message ID | 20230221113428.19324-1-bp@alien8.de |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1812194wrn; Tue, 21 Feb 2023 03:35:58 -0800 (PST) X-Google-Smtp-Source: AK7set+gD7et/8jnRpZo0xRXdT6rQnMMKfiL09Te477gCCYzNKYPdF9IQ2Y9WgCr+L1dj3FoXvu8 X-Received: by 2002:a05:6a20:3d24:b0:be:a3b2:cc7d with SMTP id y36-20020a056a203d2400b000bea3b2cc7dmr13298324pzi.6.1676979357968; Tue, 21 Feb 2023 03:35:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676979357; cv=none; d=google.com; s=arc-20160816; b=u0EvJ1P4dGD20VxeBoNjym9qtTZgbrPBeY3U3H9CtDn4hN5a384I+oEKTHe7K4/4Sk ytUi+I3LLLiIG3KMg/7upNtX6xj50k9AtADAKOdGZ/CHzl21ZY4FNm4jNGmrKzWT6xuY +k2zb0WXjG/Lv251Rznba4a78pTuW05ALwawbO+4wFwC5eUy6dyrwoETmzDRAMBYasW5 iKX4fF3opK85oxTO4Hr4zqqOWNmgb97hmUhI0mqEvrofbJT8jdshr7rwrYNY7GNFehdw +5EYPToPh/3mRkpty2WICWpC6bIA0pOC8tCr5Z4+RsN3btcJwg87GbjKV3AwCTXeSwsQ WTfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Zc+FvdgAq+QqiQboJPX6s91pJhvJT91tnVAaN+emh38=; b=L29pzpq/evFcBIqgUraduVxfaX8Dr6r0cJQgBIV9C3fxuLhlSAYUZ5OozmoUE/Wii+ o1qLUS9HqIiyGsy4GCU+Ldbbivctl5OOjvueGHAlLfQYL2N3TF1X1cOlPI5CRJ8Nzrpb rfHYzsMLcMBKNfDFoOkZfRt9Yc72YUxHPPYm5nOvSldSQBezviO4VWzAhLbU3pQEAMS7 3yS6KGzI2zYoRyaJ0CGIYBvujDJBw+RTOIRY2Y07aHZtNLuvy8Gt7NDUVwgyRHVoyONA BWpy4UOjdBbe+0VqH3MZYLdAXYFvfsi0lSUqI7YYuGLGF2BO8ylZcVbbhcbIJ7miGvQQ wXrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=VBNmsYxc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f29-20020aa7969d000000b005aa804c4afesi15146678pfk.300.2023.02.21.03.35.45; Tue, 21 Feb 2023 03:35:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=VBNmsYxc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233460AbjBULej (ORCPT <rfc822;kautuk.consul.80@gmail.com> + 99 others); Tue, 21 Feb 2023 06:34:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233151AbjBULei (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 21 Feb 2023 06:34:38 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB2B233FD for <linux-kernel@vger.kernel.org>; Tue, 21 Feb 2023 03:34:37 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D41F41EC059E; Tue, 21 Feb 2023 12:34:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1676979275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=Zc+FvdgAq+QqiQboJPX6s91pJhvJT91tnVAaN+emh38=; b=VBNmsYxcKLZVuHnRS1XhM9NdJxTCjEriunvxze38rhNuEwfqjumJ2xLQ7uTwmNT0nMLrpm jViBRWcQ6njtPLADJ9X5GcgtnvhCXbNtIteqTn6R36G/qD+f1wefiWbDTvWVPKyAOIKUud hXSG82V1pwy/0NpnGnXuKcGEmAgy5kQ= From: Borislav Petkov <bp@alien8.de> To: LKML <linux-kernel@vger.kernel.org> Cc: Dionna Glaze <dionnaglaze@google.com>, Joerg Roedel <jroedel@suse.de>, Michael Roth <michael.roth@amd.com>, Nikunj A Dadhania <nikunj@amd.com>, Peter Gonda <pgonda@google.com>, Tom Lendacky <Thomas.Lendacky@amd.com>, linux-coco@lists.linux.dev, x86@kernel.org Subject: [PATCH -v2 00/11] SEV: Cleanup sev-guest a bit and add throttling Date: Tue, 21 Feb 2023 12:34:17 +0100 Message-Id: <20230221113428.19324-1-bp@alien8.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758440307059789331?= X-GMAIL-MSGID: =?utf-8?q?1758440307059789331?= |
Series |
SEV: Cleanup sev-guest a bit and add throttling
|
|
Message
Borislav Petkov
Feb. 21, 2023, 11:34 a.m. UTC
From: "Borislav Petkov (AMD)" <bp@alien8.de>
Hi,
ok, here's v2 with the pending stuff fixed.
Thx.
Changelog:
----------
v1:
---
so I've been looking at Dionna's patches adding the SEV guest throttling
and that request issuing spaghetti was getting on my nerves. And it
would've become even worse with more stuff piling ontop so here's
a first round of cleanups before adding more stuff and making it an
unmaintainable mess.
The final result is a lot easier to read with proper separation of
functionality between functions. I want to get rid of more input/output
params being passed back'n'forth and use a struct instead and Nikunj's
patches have stuff which goes in that direction but first things first.
After the cleanup, the new stuff being added is a lot less code and
almost trivial. But I've been staring at this for a while now so it
could be only me who thinks it is trivial now. But we'll see.
Initial smoke testing seems to work ok but I might've introduced some
funky bugs, ofc.
Comments and suggestions are appreciated, as always.
Thanks and thanks, Tom, for the help!
Borislav Petkov (AMD) (7):
virt/coco/sev-guest: Check SEV_SNP attribute at probe time
virt/coco/sev-guest: Simplify extended guest request handling
virt/coco/sev-guest: Remove the disable_vmpck label in
handle_guest_request()
virt/coco/sev-guest: Carve out the request issuing logic into a helper
virt/coco/sev-guest: Do some code style cleanups
virt/coco/sev-guest: Convert the sw_exit_info_2 checking to a
switch-case
crypto: ccp: Get rid of __sev_platform_init_locked()'s local function
pointer
Dionna Glaze (3):
virt/coco/sev-guest: Add throttling awareness
virt/coco/sev-guest: Double-buffer messages
x86/sev: Change snp_guest_issue_request()'s fw_err argument
Peter Gonda (1):
crypto: ccp - Name -1 return value as SEV_RET_NO_FW_CALL
Documentation/virt/coco/sev-guest.rst | 20 ++-
arch/x86/include/asm/sev-common.h | 3 -
arch/x86/include/asm/sev.h | 8 +-
arch/x86/kernel/sev.c | 33 +++--
drivers/crypto/ccp/sev-dev.c | 22 +--
drivers/virt/coco/sev-guest/sev-guest.c | 173 +++++++++++++++---------
include/uapi/linux/psp-sev.h | 7 +
include/uapi/linux/sev-guest.h | 18 ++-
8 files changed, 186 insertions(+), 98 deletions(-)