From patchwork Tue Feb 21 10:14:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 5671 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1787043wrn; Tue, 21 Feb 2023 02:29:33 -0800 (PST) X-Google-Smtp-Source: AK7set+OedDUjY2LtmUMAFecV8053casXxxjpNI/fEqPaVOfy9fdgRaHQES7N2r07Hr7/4+krO2z X-Received: by 2002:a17:906:86d4:b0:87b:3d29:2982 with SMTP id j20-20020a17090686d400b0087b3d292982mr12266205ejy.11.1676975373644; Tue, 21 Feb 2023 02:29:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676975373; cv=none; d=google.com; s=arc-20160816; b=uJNemwLFU+V+9yq5uk6EPopClOBdqbzlBgO/J2xfSk4ojkNryL6hVmSsvPGFUvah+t +SjAJy0bnPQw3fg32z7V28sTS2VrdEorTj4wOF8Ex+RpiyuvLKI32UDSqnlND+FwbWqQ JyO8u1Hi8gVUhZdzmKZnCbGEqEecLMRrjbKgOxwSD/aPo3laEvrN9eJe758dWUJMPMTd 3pZE1xLOhob+U2MQQ7tZ2AMPl0UAyggScfmhbSlk3qTpuVzgOLfttMeXPLY4bUH+LPOP Lw+Y1kk8iKZD/P9/NCef/Glb5sLkl1mrszI8/j6NWjWF5z4W/LgahNg2u8xn+Dk/zQny 7CWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=awE4fPHWPWciRdpwDXdwYCP25hYdBbviAVtw2q9MW8Y=; b=uHL12n1CYMgLPzP0Gzq3XRJEXGDmErQ1KqWewsztpthZ+4LSQbWou9RsaiBFW9oWkO DNaVc+dNny7IaCnjZ2ne/H/LeoKEbpFcaX7gO81Cl3RXb4HppQa+EUpvTxNI5BmIxOYI sR6Ehm1K9P2SjhuFLIlXeqRUP0j8iptKBQcnD4l9x2mtIwBw5ouTD64zZjbzWd07A0Bo OBs3nRTSDgsuuOMHKl3rNbu0H+QuqoisisJA/pPW23gmRpZA2V2TjYZP0nGiFjx6gK9Y 6/tFDgZ/coDMnQTlMULiVO/AumfNSmMshpbR8cKHq2osDV+KsZov/zOGskVFTN8Tcvy5 OqhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rcXnBgvh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cq18-20020a170906d51200b008b223aa7a2esi13524845ejc.82.2023.02.21.02.29.09; Tue, 21 Feb 2023 02:29:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rcXnBgvh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233724AbjBUKQt (ORCPT + 99 others); Tue, 21 Feb 2023 05:16:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233675AbjBUKQr (ORCPT ); Tue, 21 Feb 2023 05:16:47 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E31C23334; Tue, 21 Feb 2023 02:16:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 01A0B60FC8; Tue, 21 Feb 2023 10:16:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5799BC4339C; Tue, 21 Feb 2023 10:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676974605; bh=LUsoC6iSVQT5Y3MM/3YfkP1p/LvHRVSyJ+N/makA+N8=; h=From:To:Cc:Subject:Date:From; b=rcXnBgvhaj6iNKopEWQjVQr3aV4U3Ca/n+r22TxKwIJyrYcLABchJSvyK9nBAxfbh DT6GvN7i1hDH4Cc70yAAUXa1+Taa5/TYX6qjZiahdTllrZP10/EtnE0k4FtOTxBFPz Ghh1zezU4xyboYI4ZUFnPT2DS610X3SRE5NeqUUpdt3WdD5HTjnDO59YAEmybpZNxE 4mjUudbWBy1BTeN0v6GSsiN9bIFAPlNhzKjOj62RtwjbS9TioWGvSKZ6iaQ9pc9CRW G6q6etakyCVKw4RXU6XcrJfZ2bgC2Dtq8ur+JnI9q6KsgywauRm7YpdnVmW6caiNSj eTrgbD87u43gg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pUPhX-0003oD-5w; Tue, 21 Feb 2023 11:16:47 +0100 From: Johan Hovold To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov Cc: Sean Paul , David Airlie , Daniel Vetter , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 0/4] drm/msm/adreno: fix runtime PM imbalance at unbind Date: Tue, 21 Feb 2023 11:14:26 +0100 Message-Id: <20230221101430.14546-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758436129189570428?= X-GMAIL-MSGID: =?utf-8?q?1758436129189570428?= As reported by Bjorn, we can end up with an unbalanced runtime PM disable count if unbind() is called before the drm device is opened (e.g. if component bind fails due to the panel driver not having been loaded yet). As runtime PM must currently stay disabled until the firmware has been loaded, fix this by making the runtime PM disable call at unbind() conditional. The rest of the series removes a bogus pm_runtime_set_active() call and drops the redundant pm_runtime_disable() from adreno_gpu_cleanup(). Included is also a related indentation cleanup. Johan Johan Hovold (4): drm/msm/adreno: fix runtime PM imbalance at unbind drm/msm/adreno: drop bogus pm_runtime_set_active() drm/msm/adreno: drop redundant pm_runtime_disable() drm/msm/adreno: clean up component ops indentation drivers/gpu/drm/msm/adreno/adreno_device.c | 10 ++++------ drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 ----- 2 files changed, 4 insertions(+), 11 deletions(-)