mbox series

[v2,net-next,0/5] add ethtool categorized statistics

Message ID 20230217110211.433505-1-rakesh.sankaranarayanan@microchip.com
Headers
Series add ethtool categorized statistics |

Message

Rakesh Sankaranarayanan Feb. 17, 2023, 11:02 a.m. UTC 
  Patch series contain following changes:
- add categorized ethtool statistics for Microchip KSZ series switches,
  support "eth-mac",  "eth-phy", "eth-ctrl", "rmon" parameters with
  ethtool statistics command. mib parameter index are same for all
  KSZ family switches except KSZ8830. So, functions can be re-used
  across all KSZ Families (except KSZ8830) and LAN937x series. Create
  separate functions for KSZ8830 with their mib parameters.
- Remove num_alus member from ksz_chip_data structure since it is unused

v2
- updated all constants as capital
- removed counters that are not supported in hardware
- updated the FramesTransmittedOK and OctetsTransmittedOK counters as
  per standards

v1
- Initial submission

Rakesh Sankaranarayanan (5):
  net: dsa: microchip: add rmon grouping for ethtool statistics
  net: dsa: microchip: add eth ctrl grouping for ethtool statistics
  net: dsa: microchip: add eth mac grouping for ethtool statistics
  net: dsa: microchip: add eth phy grouping for ethtool statistics
  net: dsa: microchip: remove num_alus_variable

 drivers/net/dsa/microchip/Makefile      |   1 +
 drivers/net/dsa/microchip/ksz_common.c  |  70 +++--
 drivers/net/dsa/microchip/ksz_common.h  |  10 +-
 drivers/net/dsa/microchip/ksz_ethtool.c | 348 ++++++++++++++++++++++++
 drivers/net/dsa/microchip/ksz_ethtool.h |  31 +++
 5 files changed, 443 insertions(+), 17 deletions(-)
 create mode 100644 drivers/net/dsa/microchip/ksz_ethtool.c
 create mode 100644 drivers/net/dsa/microchip/ksz_ethtool.h

Comments

Alexander Lobakin Feb. 17, 2023, 2:54 p.m. UTC | #1 
From: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
Date: Fri, 17 Feb 2023 16:32:06 +0530

> [PATCH v2 net-next 0/5] add ethtool categorized statistics

I'd like to see the cover letter's subject prefixed as well, e.g.

[PATCH v2 net-next 0/5] net: dsa: microchip: add ethtool categorized
statistics

...or so, depending on the usual prefix for ksz.
Otherwise, it looks like you're adding something generic and only
realize it targets a particular driver only after opening the thread itself.

> Patch series contain following changes:
> - add categorized ethtool statistics for Microchip KSZ series switches,
>   support "eth-mac",  "eth-phy", "eth-ctrl", "rmon" parameters with
>   ethtool statistics command. mib parameter index are same for all
>   KSZ family switches except KSZ8830. So, functions can be re-used
>   across all KSZ Families (except KSZ8830) and LAN937x series. Create
>   separate functions for KSZ8830 with their mib parameters.
> - Remove num_alus member from ksz_chip_data structure since it is unused
> 
> v2
> - updated all constants as capital
> - removed counters that are not supported in hardware
> - updated the FramesTransmittedOK and OctetsTransmittedOK counters as
>   per standards
> 
> v1
> - Initial submission
> 
> Rakesh Sankaranarayanan (5):
>   net: dsa: microchip: add rmon grouping for ethtool statistics
>   net: dsa: microchip: add eth ctrl grouping for ethtool statistics
>   net: dsa: microchip: add eth mac grouping for ethtool statistics
>   net: dsa: microchip: add eth phy grouping for ethtool statistics
>   net: dsa: microchip: remove num_alus_variable
> 
>  drivers/net/dsa/microchip/Makefile      |   1 +
>  drivers/net/dsa/microchip/ksz_common.c  |  70 +++--
>  drivers/net/dsa/microchip/ksz_common.h  |  10 +-
>  drivers/net/dsa/microchip/ksz_ethtool.c | 348 ++++++++++++++++++++++++
>  drivers/net/dsa/microchip/ksz_ethtool.h |  31 +++
>  5 files changed, 443 insertions(+), 17 deletions(-)
>  create mode 100644 drivers/net/dsa/microchip/ksz_ethtool.c
>  create mode 100644 drivers/net/dsa/microchip/ksz_ethtool.h
> 
Thanks,
Olek
Vladimir Oltean Feb. 17, 2023, 4:48 p.m. UTC | #2 
On Fri, Feb 17, 2023 at 03:54:48PM +0100, Alexander Lobakin wrote:
> From: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
> Date: Fri, 17 Feb 2023 16:32:06 +0530
> 
> > [PATCH v2 net-next 0/5] add ethtool categorized statistics
> 
> I'd like to see the cover letter's subject prefixed as well, e.g.
> 
> [PATCH v2 net-next 0/5] net: dsa: microchip: add ethtool categorized
> statistics
> 
> ...or so, depending on the usual prefix for ksz.
> Otherwise, it looks like you're adding something generic and only
> realize it targets a particular driver only after opening the thread itself.

+1

some people just look at the KSZ DSA driver all day, and so in their mind, it
then becomes implicit in the subject. But the cover letter description gets
turned by the netdev maintainers into a branch name for a merge commit, see:

fa15072b650a Merge branch 'sfc-devlink-support-for-ef100'
e9ab2559e2c5 Merge branch 'net-sched-transition-actions-to-pcpu-stats-and-rcu'
10d13421a6ae Merge branch 'net-core-commmon-prints-for-promisc'
a1d83abc8f2f Merge branch 'net-sched-retire-some-tc-qdiscs-and-classifiers'

and so, the naming of the cover letter has non-zero importance.

I agree that the contents of this patch set is absolutely disappointing
for someone reading the title and expecting some new ethtool counters.