Message ID | 20230217-import-hid-tools-tests-v1-0-d1c48590d0ee@redhat.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp980632wrn; Fri, 17 Feb 2023 08:27:45 -0800 (PST) X-Google-Smtp-Source: AK7set8Zloh1vXPDiznOnScz9Jjd3cXLHft3yE57frvhLOiqRovY7zU2cxek2losHsY1RzYvCEmk X-Received: by 2002:a17:907:9543:b0:8b2:c2fc:178e with SMTP id ex3-20020a170907954300b008b2c2fc178emr1819678ejc.74.1676651265696; Fri, 17 Feb 2023 08:27:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676651265; cv=none; d=google.com; s=arc-20160816; b=VK0L4M9IUnshjqXqyZlaIpn/iP/rfGnCX4iyyGDqwqNWHqWlEcZJ6GNkEs7xjjiLpj SFLz8dJTICHr+Z/VFx40iphrltuZeMhmEWKXr9W5VExrRXcNclYYlp8kenuoKfqiCOOF jOkjnaRE3rkXJqg4hsHGUbeOOpWFD4ygVHTghVs+2Dxtgjiq6zxHGuxabZ2pCCVbHaMU BsbZRnd8KURGdwgV9FIzAK0AXTZyKIsorJlQ4PZdn4/JzkaYOXps2nvq/x56zyaCvsLf BgFDJCujbvhZr+E5Vu86J15SKOgY6c62JeWD4DT37U+WOf+4Ohjbf0e/J0zcqapFbgh2 v2Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=fd9az+jWzHsVZPXaXnCt7gp0LBlrNfk46pVDYhI5kgA=; b=mzHKuyw6v6SotymkPPHiaqV/58NhPago7tt0aMjFTjYkHbN06juREGBeEU7eRDPBnp UsgQNq0GSjbFzFgMy5NjoxTnCCfbzqvlaH6ziPxSVfOmpFrJUgVwq16a7L+HkjH6Nz/Y Ku38rdBCaHcStRDg+cEl5Pk0D/xgFoZpks6FQk98dSZPJtvPZcyADtICZjtKGdevAMc8 nhFKKgBGkIT5xOAbAPuY930vObTOGzdciiXPr3Xl8IlwQnly+/8NMOrDovrX9JetExhZ tdgl7VshV77lUR0bv0OcmUcinfy4UhbMREnTq2hy8jkPf8I9nsg/pBs2KJOiFhCxpy1d HAwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CdGlZiMM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v30-20020a17090651de00b0086f0552517asi6276071ejk.830.2023.02.17.08.27.02; Fri, 17 Feb 2023 08:27:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CdGlZiMM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229687AbjBQQUC (ORCPT <rfc822;aimixsaka@gmail.com> + 99 others); Fri, 17 Feb 2023 11:20:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbjBQQUA (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 17 Feb 2023 11:20:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C06F711BD for <linux-kernel@vger.kernel.org>; Fri, 17 Feb 2023 08:18:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676650723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fd9az+jWzHsVZPXaXnCt7gp0LBlrNfk46pVDYhI5kgA=; b=CdGlZiMMn4v1gDkkncIY5XhbqXZf/MSCBAKaU4dh9F9NwDkicVoKS+58tMy8kVswHyVvw1 frI1lGVHTdclvP3+wfEVXP+0t4prS6MvEOYuBVX0zHIq1ioMbVMDb4D+7F26SQxw6fwehb tDsDYfO9xfSDxeVq4e4KTQudLp0uAak= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-xL5r2vlXNtqnNJajSNjfoQ-1; Fri, 17 Feb 2023 11:18:41 -0500 X-MC-Unique: xL5r2vlXNtqnNJajSNjfoQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4DE8E830F83; Fri, 17 Feb 2023 16:18:40 +0000 (UTC) Received: from xps-13.local (unknown [10.39.193.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A65FC15BA0; Fri, 17 Feb 2023 16:18:35 +0000 (UTC) From: Benjamin Tissoires <benjamin.tissoires@redhat.com> Subject: [PATCH 00/11] selftests: hid: import the tests from hid-tools Date: Fri, 17 Feb 2023 17:17:54 +0100 Message-Id: <20230217-import-hid-tools-tests-v1-0-d1c48590d0ee@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIALKo72MC/x3NywrCMBCF4VcpWTvaJqLFVxEXuUzMgCZhJohQ+ u4mLn84H2dTgkwo6jZtivFDQiX3WA6T8snmJwKF3krP2sx6uQK9a+EGiQK0Ul4CDaUJBD/7cI7 Gr3ZVHTsrCI5t9mnwWBguR3MazNU4FpUx0vd/fX/s+w913lcWigAAAA== To: Jiri Kosina <jikos@kernel.org>, Shuah Khan <shuah@kernel.org> Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Peter Hutterer <peter.hutterer@who-t.net>, Candle Sun <candle.sun@unisoc.com>, Jose Torreguitar <jtguitar@google.com>, Roderick Colenbrander <roderick.colenbrander@sony.com>, Silvan Jegen <s.jegen@gmail.com>, Kai-Heng Feng <kai.heng.feng@canonical.com>, =?utf-8?b?0L3QsNCx?= <nabijaczleweli@nabijaczleweli.xyz>, =?utf-8?q?Bla?= =?utf-8?q?=C5=BE_Hrastnik?= <blaz@mxxn.io>, Jason Gerecke <killertofu@gmail.com>, Nicolas Saenz Julienne <nsaenz@kernel.org> X-Developer-Signature: v=1; a=ed25519-sha256; t=1676650715; l=4330; i=benjamin.tissoires@redhat.com; s=20230215; h=from:subject:message-id; bh=vf/0i+vdcQrCIUgM/0h0n4e3SxwKRVx880EwDdDlGlI=; b=TaMT3TeG1yeSDaLpn1hG3Lcu1wn9PZB/zBmYNcrHzcraK0Ew2dymjgPQQ+qT3KkzAcikrU+bd xIwS9SfhSsmBhB2vopcgxfSQYQN4xXNAcvs7LKgDaJt3RuC6o7P52Zo X-Developer-Key: i=benjamin.tissoires@redhat.com; a=ed25519; pk=7D1DyAVh6ajCkuUTudt/chMuXWIJHlv2qCsRkIizvFw= X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758096277796035691?= X-GMAIL-MSGID: =?utf-8?q?1758096277796035691?= |
Series |
selftests: hid: import the tests from hid-tools
|
|
Message
Benjamin Tissoires
Feb. 17, 2023, 4:17 p.m. UTC
I have been running hid-tools for a while, but it was in its own
separate repository for multiple reasons. And the past few weeks
I finally managed to make the kernel tests in that repo in a
state where we can merge them in the kernel tree directly:
- the tests run in ~2 to 3 minutes
- the tests are way more reliable than previously
- the tests are mostly self-contained now (to the exception
of the Sony ones)
To be able to run the tests we need to use the latest release
of hid-tools, as this project still keeps the HID parsing logic
and is capable of generating the HID events.
The series also ensures we can run the tests with vmtest.sh,
allowing for a quick development and test in the tree itself.
This should allow us to require tests to be added to a series
when we see fit and keep them alive properly instead of having
to deal with 2 repositories.
In Cc are all of the people who participated in the elaboration
of those tests, so please send back a signed-off-by for each
commit you are part of.
This series applies on top of the for-6.3/hid-bpf branch, which
is the one that added the tools/testing/selftests/hid directory.
Given that this is unlikely this series will make the cut for
6.3, we might just consider this series to be based on top of
the future 6.3-rc1.
Cheers,
Benjamin
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Benjamin Tissoires (11):
selftests: hid: make vmtest rely on make
selftests: hid: import hid-tools hid-core tests
selftests: hid: import hid-tools hid-gamepad tests
selftests: hid: import hid-tools hid-keyboards tests
selftests: hid: import hid-tools hid-mouse tests
selftests: hid: import hid-tools hid-multitouch and hid-tablets tests
selftests: hid: import hid-tools wacom tests
selftests: hid: import hid-tools hid-apple tests
selftests: hid: import hid-tools hid-ite tests
selftests: hid: import hid-tools hid-sony and hid-playstation tests
selftests: hid: import hid-tools usb-crash tests
tools/testing/selftests/hid/Makefile | 12 +
tools/testing/selftests/hid/config | 11 +
tools/testing/selftests/hid/hid-apple.sh | 7 +
tools/testing/selftests/hid/hid-core.sh | 7 +
tools/testing/selftests/hid/hid-gamepad.sh | 7 +
tools/testing/selftests/hid/hid-ite.sh | 7 +
tools/testing/selftests/hid/hid-keyboard.sh | 7 +
tools/testing/selftests/hid/hid-mouse.sh | 7 +
tools/testing/selftests/hid/hid-multitouch.sh | 7 +
tools/testing/selftests/hid/hid-sony.sh | 7 +
tools/testing/selftests/hid/hid-tablet.sh | 7 +
tools/testing/selftests/hid/hid-usb_crash.sh | 7 +
tools/testing/selftests/hid/hid-wacom.sh | 7 +
tools/testing/selftests/hid/run-hid-tools-tests.sh | 28 +
tools/testing/selftests/hid/settings | 3 +
tools/testing/selftests/hid/tests/__init__.py | 2 +
tools/testing/selftests/hid/tests/base.py | 345 ++++
tools/testing/selftests/hid/tests/conftest.py | 81 +
.../selftests/hid/tests/descriptors_wacom.py | 1360 +++++++++++++
.../selftests/hid/tests/test_apple_keyboard.py | 440 +++++
tools/testing/selftests/hid/tests/test_gamepad.py | 209 ++
tools/testing/selftests/hid/tests/test_hid_core.py | 154 ++
.../selftests/hid/tests/test_ite_keyboard.py | 166 ++
tools/testing/selftests/hid/tests/test_keyboard.py | 485 +++++
tools/testing/selftests/hid/tests/test_mouse.py | 977 +++++++++
.../testing/selftests/hid/tests/test_multitouch.py | 2088 ++++++++++++++++++++
tools/testing/selftests/hid/tests/test_sony.py | 282 +++
tools/testing/selftests/hid/tests/test_tablet.py | 872 ++++++++
.../testing/selftests/hid/tests/test_usb_crash.py | 103 +
.../selftests/hid/tests/test_wacom_generic.py | 844 ++++++++
tools/testing/selftests/hid/vmtest.sh | 25 +-
31 files changed, 8554 insertions(+), 10 deletions(-)
---
base-commit: 2f7f4efb9411770b4ad99eb314d6418e980248b4
change-id: 20230217-import-hid-tools-tests-dc0cd4f3c8a8
Best regards,
Comments
On Feb 17 2023, Benjamin Tissoires wrote: > I have been running hid-tools for a while, but it was in its own > separate repository for multiple reasons. And the past few weeks > I finally managed to make the kernel tests in that repo in a > state where we can merge them in the kernel tree directly: > > - the tests run in ~2 to 3 minutes > - the tests are way more reliable than previously > - the tests are mostly self-contained now (to the exception > of the Sony ones) > > To be able to run the tests we need to use the latest release > of hid-tools, as this project still keeps the HID parsing logic > and is capable of generating the HID events. > > The series also ensures we can run the tests with vmtest.sh, > allowing for a quick development and test in the tree itself. > > This should allow us to require tests to be added to a series > when we see fit and keep them alive properly instead of having > to deal with 2 repositories. > > In Cc are all of the people who participated in the elaboration > of those tests, so please send back a signed-off-by for each > commit you are part of. > > This series applies on top of the for-6.3/hid-bpf branch, which > is the one that added the tools/testing/selftests/hid directory. > Given that this is unlikely this series will make the cut for > 6.3, we might just consider this series to be based on top of > the future 6.3-rc1. > > Cheers, > Benjamin > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- Jiri, do you mind if I push that code in the hid tree with the following changes: - Peter privately gave me his signed-off-by - I included changes from https://gitlab.freedesktop.org/libevdev/hid-tools/-/merge_requests/143 to fix the failing sony tests in v6.3 I am not a big fan of sending a v2 because the ML are not happy with the amount of changes... Cheers, Benjamin > Benjamin Tissoires (11): > selftests: hid: make vmtest rely on make > selftests: hid: import hid-tools hid-core tests > selftests: hid: import hid-tools hid-gamepad tests > selftests: hid: import hid-tools hid-keyboards tests > selftests: hid: import hid-tools hid-mouse tests > selftests: hid: import hid-tools hid-multitouch and hid-tablets tests > selftests: hid: import hid-tools wacom tests > selftests: hid: import hid-tools hid-apple tests > selftests: hid: import hid-tools hid-ite tests > selftests: hid: import hid-tools hid-sony and hid-playstation tests > selftests: hid: import hid-tools usb-crash tests > > tools/testing/selftests/hid/Makefile | 12 + > tools/testing/selftests/hid/config | 11 + > tools/testing/selftests/hid/hid-apple.sh | 7 + > tools/testing/selftests/hid/hid-core.sh | 7 + > tools/testing/selftests/hid/hid-gamepad.sh | 7 + > tools/testing/selftests/hid/hid-ite.sh | 7 + > tools/testing/selftests/hid/hid-keyboard.sh | 7 + > tools/testing/selftests/hid/hid-mouse.sh | 7 + > tools/testing/selftests/hid/hid-multitouch.sh | 7 + > tools/testing/selftests/hid/hid-sony.sh | 7 + > tools/testing/selftests/hid/hid-tablet.sh | 7 + > tools/testing/selftests/hid/hid-usb_crash.sh | 7 + > tools/testing/selftests/hid/hid-wacom.sh | 7 + > tools/testing/selftests/hid/run-hid-tools-tests.sh | 28 + > tools/testing/selftests/hid/settings | 3 + > tools/testing/selftests/hid/tests/__init__.py | 2 + > tools/testing/selftests/hid/tests/base.py | 345 ++++ > tools/testing/selftests/hid/tests/conftest.py | 81 + > .../selftests/hid/tests/descriptors_wacom.py | 1360 +++++++++++++ > .../selftests/hid/tests/test_apple_keyboard.py | 440 +++++ > tools/testing/selftests/hid/tests/test_gamepad.py | 209 ++ > tools/testing/selftests/hid/tests/test_hid_core.py | 154 ++ > .../selftests/hid/tests/test_ite_keyboard.py | 166 ++ > tools/testing/selftests/hid/tests/test_keyboard.py | 485 +++++ > tools/testing/selftests/hid/tests/test_mouse.py | 977 +++++++++ > .../testing/selftests/hid/tests/test_multitouch.py | 2088 ++++++++++++++++++++ > tools/testing/selftests/hid/tests/test_sony.py | 282 +++ > tools/testing/selftests/hid/tests/test_tablet.py | 872 ++++++++ > .../testing/selftests/hid/tests/test_usb_crash.py | 103 + > .../selftests/hid/tests/test_wacom_generic.py | 844 ++++++++ > tools/testing/selftests/hid/vmtest.sh | 25 +- > 31 files changed, 8554 insertions(+), 10 deletions(-) > --- > base-commit: 2f7f4efb9411770b4ad99eb314d6418e980248b4 > change-id: 20230217-import-hid-tools-tests-dc0cd4f3c8a8 > > Best regards, > -- > Benjamin Tissoires <benjamin.tissoires@redhat.com> >
On Mon, Apr 03, 2023 at 06:20:24PM +0200, Benjamin Tissoires wrote: > On Feb 17 2023, Benjamin Tissoires wrote: > > I have been running hid-tools for a while, but it was in its own > > separate repository for multiple reasons. And the past few weeks > > I finally managed to make the kernel tests in that repo in a > > state where we can merge them in the kernel tree directly: > > > > - the tests run in ~2 to 3 minutes > > - the tests are way more reliable than previously > > - the tests are mostly self-contained now (to the exception > > of the Sony ones) > > > > To be able to run the tests we need to use the latest release > > of hid-tools, as this project still keeps the HID parsing logic > > and is capable of generating the HID events. > > > > The series also ensures we can run the tests with vmtest.sh, > > allowing for a quick development and test in the tree itself. > > > > This should allow us to require tests to be added to a series > > when we see fit and keep them alive properly instead of having > > to deal with 2 repositories. > > > > In Cc are all of the people who participated in the elaboration > > of those tests, so please send back a signed-off-by for each > > commit you are part of. > > > > This series applies on top of the for-6.3/hid-bpf branch, which > > is the one that added the tools/testing/selftests/hid directory. > > Given that this is unlikely this series will make the cut for > > 6.3, we might just consider this series to be based on top of > > the future 6.3-rc1. > > > > Cheers, > > Benjamin > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > --- > > Jiri, do you mind if I push that code in the hid tree with the following > changes: > - Peter privately gave me his signed-off-by Apologies, this fell off my list after the initial ack in a meeting with Benjamin. This time publicly: Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> for the relevant commits. Cheers, Peter > - I included changes from https://gitlab.freedesktop.org/libevdev/hid-tools/-/merge_requests/143 > to fix the failing sony tests in v6.3 > > I am not a big fan of sending a v2 because the ML are not happy with the > amount of changes... > > Cheers, > Benjamin > > > Benjamin Tissoires (11): > > selftests: hid: make vmtest rely on make > > selftests: hid: import hid-tools hid-core tests > > selftests: hid: import hid-tools hid-gamepad tests > > selftests: hid: import hid-tools hid-keyboards tests > > selftests: hid: import hid-tools hid-mouse tests > > selftests: hid: import hid-tools hid-multitouch and hid-tablets tests > > selftests: hid: import hid-tools wacom tests > > selftests: hid: import hid-tools hid-apple tests > > selftests: hid: import hid-tools hid-ite tests > > selftests: hid: import hid-tools hid-sony and hid-playstation tests > > selftests: hid: import hid-tools usb-crash tests > > > > tools/testing/selftests/hid/Makefile | 12 + > > tools/testing/selftests/hid/config | 11 + > > tools/testing/selftests/hid/hid-apple.sh | 7 + > > tools/testing/selftests/hid/hid-core.sh | 7 + > > tools/testing/selftests/hid/hid-gamepad.sh | 7 + > > tools/testing/selftests/hid/hid-ite.sh | 7 + > > tools/testing/selftests/hid/hid-keyboard.sh | 7 + > > tools/testing/selftests/hid/hid-mouse.sh | 7 + > > tools/testing/selftests/hid/hid-multitouch.sh | 7 + > > tools/testing/selftests/hid/hid-sony.sh | 7 + > > tools/testing/selftests/hid/hid-tablet.sh | 7 + > > tools/testing/selftests/hid/hid-usb_crash.sh | 7 + > > tools/testing/selftests/hid/hid-wacom.sh | 7 + > > tools/testing/selftests/hid/run-hid-tools-tests.sh | 28 + > > tools/testing/selftests/hid/settings | 3 + > > tools/testing/selftests/hid/tests/__init__.py | 2 + > > tools/testing/selftests/hid/tests/base.py | 345 ++++ > > tools/testing/selftests/hid/tests/conftest.py | 81 + > > .../selftests/hid/tests/descriptors_wacom.py | 1360 +++++++++++++ > > .../selftests/hid/tests/test_apple_keyboard.py | 440 +++++ > > tools/testing/selftests/hid/tests/test_gamepad.py | 209 ++ > > tools/testing/selftests/hid/tests/test_hid_core.py | 154 ++ > > .../selftests/hid/tests/test_ite_keyboard.py | 166 ++ > > tools/testing/selftests/hid/tests/test_keyboard.py | 485 +++++ > > tools/testing/selftests/hid/tests/test_mouse.py | 977 +++++++++ > > .../testing/selftests/hid/tests/test_multitouch.py | 2088 ++++++++++++++++++++ > > tools/testing/selftests/hid/tests/test_sony.py | 282 +++ > > tools/testing/selftests/hid/tests/test_tablet.py | 872 ++++++++ > > .../testing/selftests/hid/tests/test_usb_crash.py | 103 + > > .../selftests/hid/tests/test_wacom_generic.py | 844 ++++++++ > > tools/testing/selftests/hid/vmtest.sh | 25 +- > > 31 files changed, 8554 insertions(+), 10 deletions(-) > > --- > > base-commit: 2f7f4efb9411770b4ad99eb314d6418e980248b4 > > change-id: 20230217-import-hid-tools-tests-dc0cd4f3c8a8 > > > > Best regards, > > -- > > Benjamin Tissoires <benjamin.tissoires@redhat.com> > > >
Hi Benjamin, I like the direction of bundling the tests with the kernel and should make it easier in case there are driver changes breaking tests as well. Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com> Thanks, Roderick Colenbrander On Mon, Apr 3, 2023 at 6:54 PM Peter Hutterer <peter.hutterer@who-t.net> wrote: > > On Mon, Apr 03, 2023 at 06:20:24PM +0200, Benjamin Tissoires wrote: > > On Feb 17 2023, Benjamin Tissoires wrote: > > > I have been running hid-tools for a while, but it was in its own > > > separate repository for multiple reasons. And the past few weeks > > > I finally managed to make the kernel tests in that repo in a > > > state where we can merge them in the kernel tree directly: > > > > > > - the tests run in ~2 to 3 minutes > > > - the tests are way more reliable than previously > > > - the tests are mostly self-contained now (to the exception > > > of the Sony ones) > > > > > > To be able to run the tests we need to use the latest release > > > of hid-tools, as this project still keeps the HID parsing logic > > > and is capable of generating the HID events. > > > > > > The series also ensures we can run the tests with vmtest.sh, > > > allowing for a quick development and test in the tree itself. > > > > > > This should allow us to require tests to be added to a series > > > when we see fit and keep them alive properly instead of having > > > to deal with 2 repositories. > > > > > > In Cc are all of the people who participated in the elaboration > > > of those tests, so please send back a signed-off-by for each > > > commit you are part of. > > > > > > This series applies on top of the for-6.3/hid-bpf branch, which > > > is the one that added the tools/testing/selftests/hid directory. > > > Given that this is unlikely this series will make the cut for > > > 6.3, we might just consider this series to be based on top of > > > the future 6.3-rc1. > > > > > > Cheers, > > > Benjamin > > > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > --- > > > > Jiri, do you mind if I push that code in the hid tree with the following > > changes: > > - Peter privately gave me his signed-off-by > > Apologies, this fell off my list after the initial ack in a meeting with > Benjamin. This time publicly: > Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> > for the relevant commits. > > Cheers, > Peter > > > > - I included changes from https://gitlab.freedesktop.org/libevdev/hid-tools/-/merge_requests/143 > > to fix the failing sony tests in v6.3 > > > > I am not a big fan of sending a v2 because the ML are not happy with the > > amount of changes... > > > > Cheers, > > Benjamin > > > > > Benjamin Tissoires (11): > > > selftests: hid: make vmtest rely on make > > > selftests: hid: import hid-tools hid-core tests > > > selftests: hid: import hid-tools hid-gamepad tests > > > selftests: hid: import hid-tools hid-keyboards tests > > > selftests: hid: import hid-tools hid-mouse tests > > > selftests: hid: import hid-tools hid-multitouch and hid-tablets tests > > > selftests: hid: import hid-tools wacom tests > > > selftests: hid: import hid-tools hid-apple tests > > > selftests: hid: import hid-tools hid-ite tests > > > selftests: hid: import hid-tools hid-sony and hid-playstation tests > > > selftests: hid: import hid-tools usb-crash tests > > > > > > tools/testing/selftests/hid/Makefile | 12 + > > > tools/testing/selftests/hid/config | 11 + > > > tools/testing/selftests/hid/hid-apple.sh | 7 + > > > tools/testing/selftests/hid/hid-core.sh | 7 + > > > tools/testing/selftests/hid/hid-gamepad.sh | 7 + > > > tools/testing/selftests/hid/hid-ite.sh | 7 + > > > tools/testing/selftests/hid/hid-keyboard.sh | 7 + > > > tools/testing/selftests/hid/hid-mouse.sh | 7 + > > > tools/testing/selftests/hid/hid-multitouch.sh | 7 + > > > tools/testing/selftests/hid/hid-sony.sh | 7 + > > > tools/testing/selftests/hid/hid-tablet.sh | 7 + > > > tools/testing/selftests/hid/hid-usb_crash.sh | 7 + > > > tools/testing/selftests/hid/hid-wacom.sh | 7 + > > > tools/testing/selftests/hid/run-hid-tools-tests.sh | 28 + > > > tools/testing/selftests/hid/settings | 3 + > > > tools/testing/selftests/hid/tests/__init__.py | 2 + > > > tools/testing/selftests/hid/tests/base.py | 345 ++++ > > > tools/testing/selftests/hid/tests/conftest.py | 81 + > > > .../selftests/hid/tests/descriptors_wacom.py | 1360 +++++++++++++ > > > .../selftests/hid/tests/test_apple_keyboard.py | 440 +++++ > > > tools/testing/selftests/hid/tests/test_gamepad.py | 209 ++ > > > tools/testing/selftests/hid/tests/test_hid_core.py | 154 ++ > > > .../selftests/hid/tests/test_ite_keyboard.py | 166 ++ > > > tools/testing/selftests/hid/tests/test_keyboard.py | 485 +++++ > > > tools/testing/selftests/hid/tests/test_mouse.py | 977 +++++++++ > > > .../testing/selftests/hid/tests/test_multitouch.py | 2088 ++++++++++++++++++++ > > > tools/testing/selftests/hid/tests/test_sony.py | 282 +++ > > > tools/testing/selftests/hid/tests/test_tablet.py | 872 ++++++++ > > > .../testing/selftests/hid/tests/test_usb_crash.py | 103 + > > > .../selftests/hid/tests/test_wacom_generic.py | 844 ++++++++ > > > tools/testing/selftests/hid/vmtest.sh | 25 +- > > > 31 files changed, 8554 insertions(+), 10 deletions(-) > > > --- > > > base-commit: 2f7f4efb9411770b4ad99eb314d6418e980248b4 > > > change-id: 20230217-import-hid-tools-tests-dc0cd4f3c8a8 > > > > > > Best regards, > > > -- > > > Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > > >
On Wed, Apr 5, 2023 at 1:22 AM Roderick Colenbrander <thunderbird2k@gmail.com> wrote: > > Hi Benjamin, > > I like the direction of bundling the tests with the kernel and should > make it easier in case there are driver changes breaking tests as > well. > > Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com> Thanks everybody. I have now pushed this series with the sony fixes from hid-tools in the branch for-6.4/tests, in the hid tree. Cheers, Benjamin > > Thanks, > Roderick Colenbrander > > On Mon, Apr 3, 2023 at 6:54 PM Peter Hutterer <peter.hutterer@who-t.net> wrote: > > > > On Mon, Apr 03, 2023 at 06:20:24PM +0200, Benjamin Tissoires wrote: > > > On Feb 17 2023, Benjamin Tissoires wrote: > > > > I have been running hid-tools for a while, but it was in its own > > > > separate repository for multiple reasons. And the past few weeks > > > > I finally managed to make the kernel tests in that repo in a > > > > state where we can merge them in the kernel tree directly: > > > > > > > > - the tests run in ~2 to 3 minutes > > > > - the tests are way more reliable than previously > > > > - the tests are mostly self-contained now (to the exception > > > > of the Sony ones) > > > > > > > > To be able to run the tests we need to use the latest release > > > > of hid-tools, as this project still keeps the HID parsing logic > > > > and is capable of generating the HID events. > > > > > > > > The series also ensures we can run the tests with vmtest.sh, > > > > allowing for a quick development and test in the tree itself. > > > > > > > > This should allow us to require tests to be added to a series > > > > when we see fit and keep them alive properly instead of having > > > > to deal with 2 repositories. > > > > > > > > In Cc are all of the people who participated in the elaboration > > > > of those tests, so please send back a signed-off-by for each > > > > commit you are part of. > > > > > > > > This series applies on top of the for-6.3/hid-bpf branch, which > > > > is the one that added the tools/testing/selftests/hid directory. > > > > Given that this is unlikely this series will make the cut for > > > > 6.3, we might just consider this series to be based on top of > > > > the future 6.3-rc1. > > > > > > > > Cheers, > > > > Benjamin > > > > > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > > --- > > > > > > Jiri, do you mind if I push that code in the hid tree with the following > > > changes: > > > - Peter privately gave me his signed-off-by > > > > Apologies, this fell off my list after the initial ack in a meeting with > > Benjamin. This time publicly: > > Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> > > for the relevant commits. > > > > Cheers, > > Peter > > > > > > > - I included changes from https://gitlab.freedesktop.org/libevdev/hid-tools/-/merge_requests/143 > > > to fix the failing sony tests in v6.3 > > > > > > I am not a big fan of sending a v2 because the ML are not happy with the > > > amount of changes... > > > > > > Cheers, > > > Benjamin > > > > > > > Benjamin Tissoires (11): > > > > selftests: hid: make vmtest rely on make > > > > selftests: hid: import hid-tools hid-core tests > > > > selftests: hid: import hid-tools hid-gamepad tests > > > > selftests: hid: import hid-tools hid-keyboards tests > > > > selftests: hid: import hid-tools hid-mouse tests > > > > selftests: hid: import hid-tools hid-multitouch and hid-tablets tests > > > > selftests: hid: import hid-tools wacom tests > > > > selftests: hid: import hid-tools hid-apple tests > > > > selftests: hid: import hid-tools hid-ite tests > > > > selftests: hid: import hid-tools hid-sony and hid-playstation tests > > > > selftests: hid: import hid-tools usb-crash tests > > > > > > > > tools/testing/selftests/hid/Makefile | 12 + > > > > tools/testing/selftests/hid/config | 11 + > > > > tools/testing/selftests/hid/hid-apple.sh | 7 + > > > > tools/testing/selftests/hid/hid-core.sh | 7 + > > > > tools/testing/selftests/hid/hid-gamepad.sh | 7 + > > > > tools/testing/selftests/hid/hid-ite.sh | 7 + > > > > tools/testing/selftests/hid/hid-keyboard.sh | 7 + > > > > tools/testing/selftests/hid/hid-mouse.sh | 7 + > > > > tools/testing/selftests/hid/hid-multitouch.sh | 7 + > > > > tools/testing/selftests/hid/hid-sony.sh | 7 + > > > > tools/testing/selftests/hid/hid-tablet.sh | 7 + > > > > tools/testing/selftests/hid/hid-usb_crash.sh | 7 + > > > > tools/testing/selftests/hid/hid-wacom.sh | 7 + > > > > tools/testing/selftests/hid/run-hid-tools-tests.sh | 28 + > > > > tools/testing/selftests/hid/settings | 3 + > > > > tools/testing/selftests/hid/tests/__init__.py | 2 + > > > > tools/testing/selftests/hid/tests/base.py | 345 ++++ > > > > tools/testing/selftests/hid/tests/conftest.py | 81 + > > > > .../selftests/hid/tests/descriptors_wacom.py | 1360 +++++++++++++ > > > > .../selftests/hid/tests/test_apple_keyboard.py | 440 +++++ > > > > tools/testing/selftests/hid/tests/test_gamepad.py | 209 ++ > > > > tools/testing/selftests/hid/tests/test_hid_core.py | 154 ++ > > > > .../selftests/hid/tests/test_ite_keyboard.py | 166 ++ > > > > tools/testing/selftests/hid/tests/test_keyboard.py | 485 +++++ > > > > tools/testing/selftests/hid/tests/test_mouse.py | 977 +++++++++ > > > > .../testing/selftests/hid/tests/test_multitouch.py | 2088 ++++++++++++++++++++ > > > > tools/testing/selftests/hid/tests/test_sony.py | 282 +++ > > > > tools/testing/selftests/hid/tests/test_tablet.py | 872 ++++++++ > > > > .../testing/selftests/hid/tests/test_usb_crash.py | 103 + > > > > .../selftests/hid/tests/test_wacom_generic.py | 844 ++++++++ > > > > tools/testing/selftests/hid/vmtest.sh | 25 +- > > > > 31 files changed, 8554 insertions(+), 10 deletions(-) > > > > --- > > > > base-commit: 2f7f4efb9411770b4ad99eb314d6418e980248b4 > > > > change-id: 20230217-import-hid-tools-tests-dc0cd4f3c8a8 > > > > > > > > Best regards, > > > > -- > > > > Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > > > > > >