mbox series

[v3,0/3] can: esd_usb: Some more preparation for supporting esd CAN-USB/3

Message ID 20230216190450.3901254-1-frank.jungclaus@esd.eu
Headers
Series can: esd_usb: Some more preparation for supporting esd CAN-USB/3 |

Message

Frank Jungclaus Feb. 16, 2023, 7:04 p.m. UTC 
  Another small batch of patches to be seen as preparation for adding
support of the newly available esd CAN-USB/3 to esd_usb.c.

Due to some unresolved questions adding support for
CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
patches.

*Resend of the whole series as v3 for easier handling.*
---
* Changelog *

v2 -> v3:
 * More specific subjects
 * Try to use imperative instead of past tense

v1 -> v2:
 * [Patch v2 1/3]: No changes.
 * [Patch v2 2/3]: Make use of can_change_state() and relocate testing
   alloc_can_err_skb() for NULL to the end of esd_usb_rx_event(), to
   have things like can_bus_off(), can_change_state() working even in
   out of memory conditions.
 * [Patch v2 3/3]: No changes. I will 'declare esd_usb_msg as an union
   instead of a struct' in a separate follow-up patch.

v1:
Link: https://lore.kernel.org/all/20221219212013.1294820-1-frank.jungclaus@esd.eu/
Link: https://lore.kernel.org/all/20221219212717.1298282-1-frank.jungclaus@esd.eu/


Frank Jungclaus (3):
  can: esd_usb: Move mislocated storage of SJA1000_ECC_SEG bits in case
    of a bus error
  can: esd_usb: Make use of can_change_state() and relocate checking skb
    for NULL
  can: esd_usb: Improve readability on decoding ESD_EV_CAN_ERROR_EXT
    messages

 drivers/net/can/usb/esd_usb.c | 70 ++++++++++++++++++++---------------
 1 file changed, 40 insertions(+), 30 deletions(-)


base-commit: fa1d915a624f72b153a9ff9700232056758a2b6c

Comments

Marc Kleine-Budde Feb. 16, 2023, 8:05 p.m. UTC | #1 
On 16.02.2023 20:04:47, Frank Jungclaus wrote:
> Another small batch of patches to be seen as preparation for adding
> support of the newly available esd CAN-USB/3 to esd_usb.c.
> 
> Due to some unresolved questions adding support for
> CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
> patches.
> 
> *Resend of the whole series as v3 for easier handling.*

Applied to linux-can-next/testing.

Thanks,
Marc