From patchwork Wed Feb 15 12:00:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 5450 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp152987wrn; Wed, 15 Feb 2023 04:08:35 -0800 (PST) X-Google-Smtp-Source: AK7set9fAC5FEQX70vpBBB5IRNBe3Fnwq0P5n59ZJgSpWt+9u4USPqwC4Vp9107u+TjjQkN2+Z19 X-Received: by 2002:a62:384d:0:b0:5a8:af22:32e7 with SMTP id f74-20020a62384d000000b005a8af2232e7mr1675375pfa.6.1676462915113; Wed, 15 Feb 2023 04:08:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676462915; cv=none; d=google.com; s=arc-20160816; b=oyzRxutNrh+az/1M7zBMRZn6978/gx0aU9kIAwSkMyjkt530VOchdPTr5xiIoBuzhu lTp7DRLnj8BsoHbHgrIBFcq/vhU6QNxMCt9ZKRSMvMb8FcIRAiGXJmJ96swt5ydSuAU+ 2EGZeALFjmu04c6vbJ26Wi6/XMblpL1R/w8NGPtHwLSk+TS91NEQKhWG45Oa6KzO24NA rKg3eK+DcTVyguzCSuilhDAq+DVfFRDc0lEuuSQam81sT40XAjK3615rZKEWEJ01H1gY EgJLGYQqp8AYCM3sVsOLeOFZInaKgn7MOPLi1dVP97FVNRiQf8Fyj/1Ku2eTXdT8hWoN ga3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=4VUdCGE49XRzHSapC26DVNo0zyTxpm/781TlQ/JM0hk=; b=Vu2/FAwdCIHyZbC8xNIPKRsfAS/H7heNb0hekU1eYIS2mJABFrGmuP+Z5pxJzTWTA5 AovT0LDS0kvqoFwvmnIGt3wO5/NwjuKKZlzPphAzosPC4m7r3LBc6sxBWlDkd8oaE3c/ 12C7DmmsF5GX+jbvShuVQElOcBQH/fg5zpSoaA9xpCeIdb2aB762OWPtjF7wdgfI4uhm NRXSnI5YsI3pStezPdEztmYYhJmsuHbAEeN6St+qknnUT01XLH3IYp/+kfxE1NCTl58g cvgl+PhvLhIm+JIXKyJf1RyJKI28ub8T72UCWeXW94cT0kRUkC014QX5nEIkdIEiJ+2l BU3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WzXC4h4b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 21-20020a621915000000b005a8d4f27a2esi5909388pfz.50.2023.02.15.04.08.22; Wed, 15 Feb 2023 04:08:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WzXC4h4b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233452AbjBOMA4 (ORCPT + 99 others); Wed, 15 Feb 2023 07:00:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233930AbjBOMAx (ORCPT ); Wed, 15 Feb 2023 07:00:53 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F39B38029 for ; Wed, 15 Feb 2023 04:00:43 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id u21so21730329edv.3 for ; Wed, 15 Feb 2023 04:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=4VUdCGE49XRzHSapC26DVNo0zyTxpm/781TlQ/JM0hk=; b=WzXC4h4b9erT7h/NVTKsWubM7WnbXMEVDjLnATSbHHKXVr9Hue4pPMQhKxFKBzzZDe OwLX0YPR/wTYDjNQXTnJm0iXeo2bZq1SF38cjtgaYgAwA7VZfzmCONX0xZ/6iU+GLxbJ JVZ/WQL3g0v7hmdAdALL+HvjAAVAa2zpGBd9xAA7VQKHeUKKdRh5ZYkkxO7dj9TBpnyH Fkg95R4If1CaruvQdj8dV3vs+38lsOypQuTGQGos5IfQx0s/rBlQK6xEgD4glYr4Mnjm oELKMsBxoi29MDlefKELd4oXSzBgwTnAZL8DfAF53Q6lRW4zt9wh7wNqoFIcO/5tFEE7 nKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4VUdCGE49XRzHSapC26DVNo0zyTxpm/781TlQ/JM0hk=; b=Tk/bb5sAWs0P4mG7qGI7O/NrFitzcTSr78yx0VRCqP80PgrdKMW4ZZObLuawU+zLYk 4/MUkemz8wMsJ92cG2zvI7/V7yzCKFERSQtBEDvuyeFNqxknloXo+z0Vi179UPtlqJpK 9pQQGpuQ6/u2xSaJYZz/8Ma6PKkGEF+lljjtxC3Ad0a4FriJKKEL86CoUUdAyY5jeIBF hB9UNGKj49RolL3fuNpNKbJhYdwqeSJzfy3LxiJslka5lhNPObGzjZn3C1xt+e/ECVVy qZuW7FHSgEpaTZGo2OYZq+4VcvNd3DS71TXrI+tRJgNTHELQ74Plf9dXSDKZZZwBBznC GNBA== X-Gm-Message-State: AO0yUKXkxoLcilqZsNyvR8XmT8tFsTHAWc6yXj5usLpmMqCvdiwkP2Cc bOY74ABorFLRtXOj7L0o8UF6mQ== X-Received: by 2002:aa7:d590:0:b0:4ac:bdf7:dffd with SMTP id r16-20020aa7d590000000b004acbdf7dffdmr1652543edq.12.1676462441534; Wed, 15 Feb 2023 04:00:41 -0800 (PST) Received: from [192.168.1.101] (abxh117.neoplus.adsl.tpnet.pl. [83.9.1.117]) by smtp.gmail.com with ESMTPSA id h2-20020a056402094200b004acb42134c4sm7001477edz.70.2023.02.15.04.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 04:00:41 -0800 (PST) From: Konrad Dybcio Subject: [PATCH 0/2] Revert boot-breaking changes in fs/ Date: Wed, 15 Feb 2023 13:00:37 +0100 Message-Id: <20230215-topic-next-20230214-revert-v1-0-c58cd87b9086@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGXJ7GMC/y2MQQqAMAzAviI9W3BTEfzNrFULUmWbIsj+bg8eE 0heSByFE4zVC5FvSXKogasroC3oyiizMfjGt413PebjFELlJ+PvOrSQY0YibmlZ3EBdDzaYQmK cYlDabKHXvpfyAUrgY5dxAAAA To: Alexander Viro , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mm@kvack.org, Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1676462440; l=1045; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Pk9Em+bfGAgf2e3KWWPVe2M5izGtozUbvqt4nZPzw3w=; b=AgaZWdOrEtG7yPe/2cMEuuiDpK04G3/UjW2o/dHw6W9oZj9z/YCE7ikh9viiSSH86j7Q6d+X3IiY nWs65LgUAJNmJKxkuOLxTpEfsmr3l+tO8KhzWcDEZ5bvH16X2poj X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757898778107610137?= X-GMAIL-MSGID: =?utf-8?q?1757898778107610137?= next-20230213 introduced commit d9722a475711 ("splice: Do splice read from a buffered file without using ITER_PIPE") which broke booting on any Qualcomm ARM64 device I grabbed, dereferencing a null pointer in generic_filesplice_read+0xf8/x598. Revert it (and its dependency) (or accept better solutions should anybody come up with such) to make them bootable again. Signed-off-by: Konrad Dybcio --- Konrad Dybcio (2): Revert "iov_iter: Kill ITER_PIPE" Revert "splice: Do splice read from a buffered file without using ITER_PIPE" fs/cifs/file.c | 8 +- fs/splice.c | 159 +++---------------- include/linux/uio.h | 14 ++ lib/iov_iter.c | 435 +++++++++++++++++++++++++++++++++++++++++++++++++++- mm/filemap.c | 3 +- 5 files changed, 479 insertions(+), 140 deletions(-) --- base-commit: 3ebb0ac55efaf1d0fb1b106f852c114e5021f7eb change-id: 20230215-topic-next-20230214-revert-cce3cff17c45 Best regards,