mbox series

[v3,00/17] Mass convert GPIO IRQ chips to be immutable

Message ID 20230215-immutable-chips-v3-0-972542092a77@linaro.org
Headers
Series Mass convert GPIO IRQ chips to be immutable |

Message

Linus Walleij March 9, 2023, 7:45 a.m. UTC 
  We are getting tired of these irq_chips not getting converted
to be immutable, so I just take out the big hammer and fix
some that I deem not too complex as best I can.

I stopped after doing some, I will take another sweep at some
point I guess.

This is v6.4 material.

The last two patches to pci-idio-* (patch 15 and 16) can be
omitted if William's patches to convert this driver to
regmap GPIO are merged first.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v3:
- Deleted the irq_chip->name assignment in the Aspeed driver
- Fold in a patch from Joel to make aspeed IRQs compulsory
- Link to v2: https://lore.kernel.org/r/20230215-immutable-chips-v2-0-d6b0e3f2d991@linaro.org

Changes in v2:
- Rebased on v6.3-rc1
- Collected some test and ACK tags
- Link to v1: https://lore.kernel.org/r/20230215-immutable-chips-v1-0-51a8f224a5d0@linaro.org

---
Joel Stanley (1):
      gpio: aspeed: Always register the irqchip

Linus Walleij (16):
      gpio: altera: Convert to immutable irq_chip
      gpio: adnp: Convert to immutable irq_chip
      gpio: aspeed: Convert to immutable irq_chip
      gpio: aspeed-sgpio: Convert to immutable irq_chip
      gpio: ath79: Convert to immutable irq_chip
      gpio: cadence: Convert to immutable irq_chip
      gpio: hisi: Convert to immutable irq_chip
      gpio: hlwd: Convert to immutable irq_chip
      gpio: idt3243x: Convert to immutable irq_chip
      gpio: msc313: Convert to immutable irq_chip
      gpio: mlxbf2: Convert to immutable irq_chip
      gpio: max732x: Convert to immutable irq_chip
      gpio: omap: Drop irq_base
      gpio: omap: Convert to immutable irq_chip
      gpio: pci-idio-16: Convert to immutable irq_chip
      gpio: pcie-idio-24: Convert to immutable irq_chip

 drivers/gpio/gpio-adnp.c         |  9 ++++-
 drivers/gpio/gpio-altera.c       | 25 +++++++-----
 drivers/gpio/gpio-aspeed-sgpio.c | 44 +++++++++++++++++----
 drivers/gpio/gpio-aspeed.c       | 82 ++++++++++++++++++++++++++-------------
 drivers/gpio/gpio-ath79.c        |  8 +++-
 drivers/gpio/gpio-cadence.c      | 10 +++--
 drivers/gpio/gpio-hisi.c         | 25 +++++++-----
 drivers/gpio/gpio-hlwd.c         | 33 ++++++++++++----
 drivers/gpio/gpio-idt3243x.c     | 11 ++++--
 drivers/gpio/gpio-max732x.c      |  8 +++-
 drivers/gpio/gpio-mlxbf2.c       | 32 ++++++++++++----
 drivers/gpio/gpio-msc313.c       | 26 +++++++++++--
 drivers/gpio/gpio-omap.c         | 83 ++++++++++++++++++++++------------------
 drivers/gpio/gpio-pci-idio-16.c  | 12 ++++--
 drivers/gpio/gpio-pcie-idio-24.c | 12 ++++--
 15 files changed, 290 insertions(+), 130 deletions(-)
---
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
change-id: 20230215-immutable-chips-762922277f1e

Best regards,

Comments

Bartosz Golaszewski March 10, 2023, 3:25 p.m. UTC | #1 
On Thu, Mar 9, 2023 at 8:45 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> We are getting tired of these irq_chips not getting converted
> to be immutable, so I just take out the big hammer and fix
> some that I deem not too complex as best I can.
>
> I stopped after doing some, I will take another sweep at some
> point I guess.
>
> This is v6.4 material.
>
> The last two patches to pci-idio-* (patch 15 and 16) can be
> omitted if William's patches to convert this driver to
> regmap GPIO are merged first.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Changes in v3:
> - Deleted the irq_chip->name assignment in the Aspeed driver
> - Fold in a patch from Joel to make aspeed IRQs compulsory
> - Link to v2: https://lore.kernel.org/r/20230215-immutable-chips-v2-0-d6b0e3f2d991@linaro.org
>
> Changes in v2:
> - Rebased on v6.3-rc1
> - Collected some test and ACK tags
> - Link to v1: https://lore.kernel.org/r/20230215-immutable-chips-v1-0-51a8f224a5d0@linaro.org
>
> ---
> Joel Stanley (1):
>       gpio: aspeed: Always register the irqchip
>
> Linus Walleij (16):
>       gpio: altera: Convert to immutable irq_chip
>       gpio: adnp: Convert to immutable irq_chip
>       gpio: aspeed: Convert to immutable irq_chip
>       gpio: aspeed-sgpio: Convert to immutable irq_chip
>       gpio: ath79: Convert to immutable irq_chip
>       gpio: cadence: Convert to immutable irq_chip
>       gpio: hisi: Convert to immutable irq_chip
>       gpio: hlwd: Convert to immutable irq_chip
>       gpio: idt3243x: Convert to immutable irq_chip
>       gpio: msc313: Convert to immutable irq_chip
>       gpio: mlxbf2: Convert to immutable irq_chip
>       gpio: max732x: Convert to immutable irq_chip
>       gpio: omap: Drop irq_base
>       gpio: omap: Convert to immutable irq_chip
>       gpio: pci-idio-16: Convert to immutable irq_chip
>       gpio: pcie-idio-24: Convert to immutable irq_chip
>
>  drivers/gpio/gpio-adnp.c         |  9 ++++-
>  drivers/gpio/gpio-altera.c       | 25 +++++++-----
>  drivers/gpio/gpio-aspeed-sgpio.c | 44 +++++++++++++++++----
>  drivers/gpio/gpio-aspeed.c       | 82 ++++++++++++++++++++++++++-------------
>  drivers/gpio/gpio-ath79.c        |  8 +++-
>  drivers/gpio/gpio-cadence.c      | 10 +++--
>  drivers/gpio/gpio-hisi.c         | 25 +++++++-----
>  drivers/gpio/gpio-hlwd.c         | 33 ++++++++++++----
>  drivers/gpio/gpio-idt3243x.c     | 11 ++++--
>  drivers/gpio/gpio-max732x.c      |  8 +++-
>  drivers/gpio/gpio-mlxbf2.c       | 32 ++++++++++++----
>  drivers/gpio/gpio-msc313.c       | 26 +++++++++++--
>  drivers/gpio/gpio-omap.c         | 83 ++++++++++++++++++++++------------------
>  drivers/gpio/gpio-pci-idio-16.c  | 12 ++++--
>  drivers/gpio/gpio-pcie-idio-24.c | 12 ++++--
>  15 files changed, 290 insertions(+), 130 deletions(-)
> ---
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> change-id: 20230215-immutable-chips-762922277f1e
>
> Best regards,
> --
> Linus Walleij <linus.walleij@linaro.org>
>

Normally these irq_chip conversions would go upstream as fixes but
this time there are too many at once. I applied them to my
gpio/for-next branch. Let's give them some time in next and later we
can backport them if necessary.

Bartosz
Linus Walleij March 10, 2023, 10:44 p.m. UTC | #2 
On Fri, Mar 10, 2023 at 4:25 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Thu, Mar 9, 2023 at 8:45 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > We are getting tired of these irq_chips not getting converted
> > to be immutable, so I just take out the big hammer and fix
> > some that I deem not too complex as best I can.
> >
> > I stopped after doing some, I will take another sweep at some
> > point I guess.

> Normally these irq_chip conversions would go upstream as fixes but
> this time there are too many at once. I applied them to my
> gpio/for-next branch. Let's give them some time in next and later we
> can backport them if necessary.

That's fine since the maintainers didn't get around to fixing it themselves
yet anyway it can't be that important to them.

I will try to take a second sweep and see what is left on the floor, and
then I guess a sweep over the gpio_chips in pinctrl as well.

Yours,
Linus Walleij