mbox series

[v2,0/18] pata_parport: protocol drivers fixes and cleanups

Message ID 20230214230010.20318-1-linux@zary.sk
Headers
Series pata_parport: protocol drivers fixes and cleanups |

Message

Ondrej Zary Feb. 14, 2023, 10:59 p.m. UTC 
  This patch series fixes two bugs and cleans up pata_parport protocol drivers,
making the code simpler with no changes in behavior (except logged messages).

Signed-off-by: Ondrej Zary <linux@zary.sk>
---
Changes in v2:
 - added two bugfixes (first two patches)
 - addressed Sergey's comments (mostly split patches)

 drivers/ata/pata_parport/aten.c                            |  45 ++++----------
 drivers/ata/pata_parport/bpck.c                            |  86 ++++++++------------------
 drivers/ata/pata_parport/bpck6.c                           | 107 ++++++++-------------------------
 drivers/ata/pata_parport/comm.c                            |  52 +++++-----------
 drivers/ata/pata_parport/dstr.c                            |  45 ++++----------
 drivers/ata/pata_parport/epat.c                            |  48 ++++++---------
 drivers/ata/pata_parport/epia.c                            |  55 +++++------------
 drivers/ata/pata_parport/fit2.c                            |  37 ++++--------
 drivers/ata/pata_parport/fit3.c                            |  39 ++++--------
 drivers/ata/pata_parport/friq.c                            |  56 ++++++-----------
 drivers/ata/pata_parport/frpw.c                            |  71 ++++++----------------
 drivers/ata/pata_parport/kbic.c                            |  66 +++++++++-----------
 drivers/ata/pata_parport/ktti.c                            |  38 ++++--------
 drivers/ata/pata_parport/on20.c                            |  45 ++++----------
 drivers/ata/pata_parport/on26.c                            |  52 ++++------------
 drivers/ata/pata_parport/pata_parport.c                    |  31 +++++-----
 {include/linux => drivers/ata/pata_parport}/pata_parport.h |  41 ++++---------
 17 files changed, 271 insertions(+), 643 deletions(-)

Comments

Damien Le Moal Feb. 14, 2023, 11:50 p.m. UTC | #1 
On 2/15/23 07:59, Ondrej Zary wrote:
> This patch series fixes two bugs and cleans up pata_parport protocol drivers,
> making the code simpler with no changes in behavior (except logged messages).
> 
> Signed-off-by: Ondrej Zary <linux@zary.sk>

Sergey did send you some reviewed-by tags for some of the patches. But I
do not see any in this v2. Did you forget to add the tags to the reviewed
patches ? That is nice to do so that I do not have to keep track of
reviews across series versions...

> ---
> Changes in v2:
>  - added two bugfixes (first two patches)
>  - addressed Sergey's comments (mostly split patches)
> 
>  drivers/ata/pata_parport/aten.c                            |  45 ++++----------
>  drivers/ata/pata_parport/bpck.c                            |  86 ++++++++------------------
>  drivers/ata/pata_parport/bpck6.c                           | 107 ++++++++-------------------------
>  drivers/ata/pata_parport/comm.c                            |  52 +++++-----------
>  drivers/ata/pata_parport/dstr.c                            |  45 ++++----------
>  drivers/ata/pata_parport/epat.c                            |  48 ++++++---------
>  drivers/ata/pata_parport/epia.c                            |  55 +++++------------
>  drivers/ata/pata_parport/fit2.c                            |  37 ++++--------
>  drivers/ata/pata_parport/fit3.c                            |  39 ++++--------
>  drivers/ata/pata_parport/friq.c                            |  56 ++++++-----------
>  drivers/ata/pata_parport/frpw.c                            |  71 ++++++----------------
>  drivers/ata/pata_parport/kbic.c                            |  66 +++++++++-----------
>  drivers/ata/pata_parport/ktti.c                            |  38 ++++--------
>  drivers/ata/pata_parport/on20.c                            |  45 ++++----------
>  drivers/ata/pata_parport/on26.c                            |  52 ++++------------
>  drivers/ata/pata_parport/pata_parport.c                    |  31 +++++-----
>  {include/linux => drivers/ata/pata_parport}/pata_parport.h |  41 ++++---------
>  17 files changed, 271 insertions(+), 643 deletions(-)
> 
>
Sergey Shtylyov Feb. 15, 2023, 5:14 p.m. UTC | #2 
On 2/15/23 2:50 AM, Damien Le Moal wrote:
[...]
>> This patch series fixes two bugs and cleans up pata_parport protocol drivers,
>> making the code simpler with no changes in behavior (except logged messages).
>>
>> Signed-off-by: Ondrej Zary <linux@zary.sk>
> 
> Sergey did send you some reviewed-by tags for some of the patches. But I
> do not see any in this v2. Did you forget to add the tags to the reviewed
> patches ? That is nice to do so that I do not have to keep track of
> reviews across series versions...

   Yes, it would also simplify my further reviews (I have low bandwidth currently
due to being somewhat overload at work)...

>> ---
>> Changes in v2:
>>  - added two bugfixes (first two patches)
>>  - addressed Sergey's comments (mostly split patches)

   Well, you're supposed to be more detailed about what you really
did to the series, preferably listing the changes in each patch (usually
after the --- tearline)...

[...]

MBR, Sergey