mbox series

[v2,0/3] can: esd_usb: Some more preparation for supporting esd CAN-USB/3

Message ID 20230214160223.1199464-1-frank.jungclaus@esd.eu
Headers
Series can: esd_usb: Some more preparation for supporting esd CAN-USB/3 |

Message

Frank Jungclaus Feb. 14, 2023, 4:02 p.m. UTC 
  Another small batch of patches to be seen as preparation for adding
support of the newly available esd CAN-USB/3 to esd_usb.c.

Due to some unresolved questions adding support for
CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
patches.

*Resend of the whole series as v2 for easier handling.*
---
* Changelog *

v1:
Link: https://lore.kernel.org/all/20221219212013.1294820-1-frank.jungclaus@esd.eu/
Link: https://lore.kernel.org/all/20221219212717.1298282-1-frank.jungclaus@esd.eu/

v1 -> v2:

 * [Patch v2 1/3]: No changes.

 * [Patch v2 2/3]: Make use of can_change_state() and relocate testing
   alloc_can_err_skb() for NULL to the end of esd_usb_rx_event(), to
   have things like can_bus_off(), can_change_state() working even in
   out of memory conditions.

 * [Patch v2 3/3]: No changes. I will 'declare esd_usb_msg as an union
   instead of a struct' in a separate follow-up patch.


Frank Jungclaus (3):
  can: esd_usb: Improved behavior on esd CAN_ERROR_EXT event (1)
  can: esd_usb: Improved behavior on esd CAN_ERROR_EXT event (2)
  can: esd_usb: Improved decoding for ESD_EV_CAN_ERROR_EXT messages

 drivers/net/can/usb/esd_usb.c | 70 ++++++++++++++++++++---------------
 1 file changed, 40 insertions(+), 30 deletions(-)


base-commit: fa1d915a624f72b153a9ff9700232056758a2b6c

Comments

Marc Kleine-Budde Feb. 15, 2023, 8:52 a.m. UTC | #1 
On 14.02.2023 17:02:20, Frank Jungclaus wrote:
> Another small batch of patches to be seen as preparation for adding
> support of the newly available esd CAN-USB/3 to esd_usb.c.
> 
> Due to some unresolved questions adding support for
> CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
> patches.
> 
> *Resend of the whole series as v2 for easier handling.*

As Vincent pointed out in review of a completely different patch series,
bu this applies here, too:

| For the titles, please use imperative (e.g. add) instead of past tense
| (e.g. Added). This also applies to the description.

Further, the subject ob patches 1 and 2 can be improved a bit, e.g.
patch 1 could mention to move the SJA1000_ECC_SEG for a specific reason.

regards,
Marc
Frank Jungclaus Feb. 16, 2023, 6:36 p.m. UTC | #2 
On Wed, 2023-02-15 at 09:52 +0100, Marc Kleine-Budde wrote:
> On 14.02.2023 17:02:20, Frank Jungclaus wrote:
> > Another small batch of patches to be seen as preparation for adding
> > support of the newly available esd CAN-USB/3 to esd_usb.c.
> > 
> > Due to some unresolved questions adding support for
> > CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
> > patches.
> > 
> > *Resend of the whole series as v2 for easier handling.*
> 
> As Vincent pointed out in review of a completely different patch series,
> bu this applies here, too:
> 
> > For the titles, please use imperative (e.g. add) instead of past tense
> > (e.g. Added). This also applies to the description.
> 
> Further, the subject ob patches 1 and 2 can be improved a bit, e.g.
> patch 1 could mention to move the SJA1000_ECC_SEG for a specific reason.
> 
> regards,
> Marc
> 
Hi Marc, 
ok, I'll resend this series as v3 soon to address your comments.

Regards, Frank