From patchwork Tue Feb 14 02:29:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Bin X-Patchwork-Id: 5367 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2708177wrn; Mon, 13 Feb 2023 18:16:30 -0800 (PST) X-Google-Smtp-Source: AK7set+dfJWwoBUNWR8BkfUtMXTCY/xnnsK9wazPI4sp6FR/jMjY72F30WqIt1stWFEdbonIFBK8 X-Received: by 2002:a17:903:5cf:b0:19a:b869:f2ef with SMTP id kf15-20020a17090305cf00b0019ab869f2efmr86197plb.15.1676340989773; Mon, 13 Feb 2023 18:16:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676340989; cv=none; d=google.com; s=arc-20160816; b=qIpgnbRuu9NBa8A8HMI4BHlLE7GUXord0ZK0LIEmb6uMHhuv4TMrxhiLgFqGaXe7bT TJC0wsn2Wjz7gIWucfy7tvnqmYohAGtAlmOCj85PONZY4lXDKmBtvZV6rqVMIwLgb2YU KmwaW+nCCIxmJ/PgtMk60pWg8AElNv52TwG3LvXjFF/L+qWF/jlKzFPLOAm1Rkl3fSwN 1hqVyvU0SvSvSBF3NFruPqBfw7YdMT5e4PO+ZOKTEh/f0H2f4LB38Vd/vwCPhpgyA5kt icLQaYBItdVo45YMIkDMku3TSetY8QNizoaLh0hoWPwUEzYYbG1K2Iv+52/Bny7lBvdK qLGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=fqGpmQeir94/L22/ySTK+9YHdZV7n3Wq6ThfEvmTxK0=; b=xsuKq6E+SC9WS/FwJ4YEy51bwoaQZu8ZD0Q5t1pm3cSYMPiIF2beIEhX6gR9hiLP82 /nYJyM6SVFVWjv3sJHqi5bBCdG+axhonuTxxZ1uGpLMtfEd8nwqPF3zKsgIu0/yZxzpK SStRk+pf5RPOBXVEMbL6VARia+38+CvbFpcrVLQcEdOYwhlUAzzWqL5WdM7VcUxdmdDa SfH8+ei4JBAII9J/bwvZGJQezKOR+8R8ePop3pPa3TMveBkmtgK2NLSHB7SNPjtXQmVf bom9hCiBXPO3NjIOHgH0sn/Ok1qv+wZbIrbBpy9Kp+E5oZeB602iVQGVHwrqTEGs9waj SohA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s7-20020a170902988700b00189c47baf1esi11926692plp.26.2023.02.13.18.16.17; Mon, 13 Feb 2023 18:16:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231239AbjBNCFi (ORCPT + 99 others); Mon, 13 Feb 2023 21:05:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbjBNCFc (ORCPT ); Mon, 13 Feb 2023 21:05:32 -0500 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C973113F6; Mon, 13 Feb 2023 18:05:29 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4PG4Kv6234z4f3l7r; Tue, 14 Feb 2023 10:05:23 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.127.227]) by APP3 (Coremail) with SMTP id _Ch0CgCnUiBk7OpjvrkRDQ--.53521S4; Tue, 14 Feb 2023 10:05:25 +0800 (CST) From: Ye Bin To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Cc: linux-kernel@vger.kernel.org, jack@suse.cz, Ye Bin Subject: [PATCH v3 0/2] fix error flag covered by journal recovery Date: Tue, 14 Feb 2023 10:29:03 +0800 Message-Id: <20230214022905.765088-1-yebin@huaweicloud.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-CM-TRANSID: _Ch0CgCnUiBk7OpjvrkRDQ--.53521S4 X-Coremail-Antispam: 1UD129KBjvJXoW7WF4fGFW5Gr17KF1kWr4fGrg_yoW8Ww1xpa 95ur98KrWvqF1IyF93Aay7t3ykX3s5AFWrWFsruw1Iyw15Gr1av3s7tF4agFWUKr1Sg3yj qF18J34rKa4qkFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUgKb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCj c4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4 CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1x MIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJV Cq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBI daVFxhVjvjDU0xZFpf9x07UWE__UUUUU= X-CM-SenderInfo: p1hex046kxt4xhlfz01xgou0bp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757770929868055000?= X-GMAIL-MSGID: =?utf-8?q?1757770929868055000?= From: Ye Bin Diff v3 Vs v2: Only fix fs error flag lost when previous journal errno is not record in disk. As this may lead to drop orphan list, however fs not record error flag, then fsck will not repair deeply. Diff v2 vs v1: Move call 'j_replay_prepare_callback' and 'j_replay_end_callback' from ext4_load_journal() to jbd2_journal_recover(). When do fault injection test, got issue as follows: EXT4-fs (dm-5): warning: mounting fs with errors, running e2fsck is recommended EXT4-fs (dm-5): Errors on filesystem, clearing orphan list. EXT4-fs (dm-5): recovery complete EXT4-fs (dm-5): mounted filesystem with ordered data mode. Opts: data_err=abort,errors=remount-ro EXT4-fs (dm-5): recovery complete EXT4-fs (dm-5): mounted filesystem with ordered data mode. Opts: data_err=abort,errors=remount-ro Without do file system check, file system is clean when do second mount. Theoretically, the kernel will not clear fs error flag. In errors=remount-ro mode the last super block is commit directly. So super block in journal is not uptodate. When do jounral recovery, the uptodate super block will be covered by jounral data. If super block submit all failed after recover journal, then file system error flag is lost. When do "fsck -a" couldn't repair file system deeply. To solve above issue we need to do extra handle when do super block journal recovery. Ye Bin (2): ext4: commit super block if fs record error when journal record without error ext4: make sure fs error flag setted before clear journal error fs/ext4/super.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)