mbox series

[0/2] arch: arm64: dts: apple: Disable unused PCIe ports

Message ID 20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@jannau.net
Headers
Series arch: arm64: dts: apple: Disable unused PCIe ports |

Message

Janne Grunau Feb. 14, 2023, 2:07 p.m. UTC 
  The t8103 and t600x device trees deleted unused PCIe ports. This was
probably done to replicate Apple's device tree which doesn't has nodes
for most unused hardware.
A more accurate description of the hardware is to disable unused
hardware.

This was discovered during the review of the t8112 device trees in
https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/

Signed-off-by: Janne Grunau <j@jannau.net>
---
Janne Grunau (2):
      arm64: dts: apple: t8103: Disable unused PCIe ports
      arm64: dts: apple: t600x: Disable unused PCIe ports

 arch/arm64/boot/dts/apple/t600x-die0.dtsi      |  4 ++++
 arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi | 11 -----------
 arch/arm64/boot/dts/apple/t600x-j375.dtsi      | 11 +++++++++++
 arch/arm64/boot/dts/apple/t8103-j274.dts       | 10 ++++++++++
 arch/arm64/boot/dts/apple/t8103-j293.dts       | 15 ---------------
 arch/arm64/boot/dts/apple/t8103-j313.dts       | 15 ---------------
 arch/arm64/boot/dts/apple/t8103-j456.dts       | 10 ++++++++++
 arch/arm64/boot/dts/apple/t8103-j457.dts       | 11 +++--------
 arch/arm64/boot/dts/apple/t8103.dtsi           |  4 ++++
 9 files changed, 42 insertions(+), 49 deletions(-)
---
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
change-id: 20230214-apple_dts_pcie_disable_unused-03c08218b8af

Best regards,

Comments

Sven Peter Feb. 19, 2023, 12:41 p.m. UTC | #1 
On Tue, Feb 14, 2023, at 15:07, Janne Grunau wrote:
> The t8103 and t600x device trees deleted unused PCIe ports. This was
> probably done to replicate Apple's device tree which doesn't has nodes
> for most unused hardware.
> A more accurate description of the hardware is to disable unused
> hardware.
>
> This was discovered during the review of the t8112 device trees in
> https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> Janne Grunau (2):
>       arm64: dts: apple: t8103: Disable unused PCIe ports
>       arm64: dts: apple: t600x: Disable unused PCIe ports

For the entire series:

Reviewed-by: Sven Peter <sven@svenpeter.dev>


Thanks,


Sven
Hector Martin March 28, 2023, 11:07 a.m. UTC | #2 
On 14/02/2023 23.07, Janne Grunau wrote:
> The t8103 and t600x device trees deleted unused PCIe ports. This was
> probably done to replicate Apple's device tree which doesn't has nodes
> for most unused hardware.
> A more accurate description of the hardware is to disable unused
> hardware.
> 
> This was discovered during the review of the t8112 device trees in
> https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/
> 
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> Janne Grunau (2):
>       arm64: dts: apple: t8103: Disable unused PCIe ports
>       arm64: dts: apple: t600x: Disable unused PCIe ports
> 
>  arch/arm64/boot/dts/apple/t600x-die0.dtsi      |  4 ++++
>  arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi | 11 -----------
>  arch/arm64/boot/dts/apple/t600x-j375.dtsi      | 11 +++++++++++
>  arch/arm64/boot/dts/apple/t8103-j274.dts       | 10 ++++++++++
>  arch/arm64/boot/dts/apple/t8103-j293.dts       | 15 ---------------
>  arch/arm64/boot/dts/apple/t8103-j313.dts       | 15 ---------------
>  arch/arm64/boot/dts/apple/t8103-j456.dts       | 10 ++++++++++
>  arch/arm64/boot/dts/apple/t8103-j457.dts       | 11 +++--------
>  arch/arm64/boot/dts/apple/t8103.dtsi           |  4 ++++
>  9 files changed, 42 insertions(+), 49 deletions(-)
> ---
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> change-id: 20230214-apple_dts_pcie_disable_unused-03c08218b8af
> 
> Best regards,

Thanks, applied to asahi-soc/dt!

- Hector