From patchwork Sun Feb 12 14:52:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 5292 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1937110wrn; Sun, 12 Feb 2023 07:08:57 -0800 (PST) X-Google-Smtp-Source: AK7set8XFBS1IPfuY+I/z4+GwwNodUp1QJNGoIt07n/yf6QjXr2jjm8hki8rHmnTslgFLzkBUWBH X-Received: by 2002:a05:6a21:370c:b0:be:ffb5:e41d with SMTP id yl12-20020a056a21370c00b000beffb5e41dmr17349383pzb.25.1676214536785; Sun, 12 Feb 2023 07:08:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676214536; cv=none; d=google.com; s=arc-20160816; b=pn30xqm+utMtR4s9Gdhec92mMU3UglS6Fp3VUScgLLV8jnzDulQMFYPa1q+w+2E6fm PlsEWPlL3xxVDtTOUUSms+l/6aNCPV6ksp+ZBywNcuZZSrUXMGJS0dC1qoSNhG4GSlUa 9oKGGubYFFZTzryAP1V4RB/ufDpBg0n2fp2TJ05KDYao/ELftQ1qrDcrtlAHmWQJdB8Z 27EeuzliA6GqB1PHQmi9fGEi5kK6W1RskVcVH5CHTDfCOTzzuf69covloUBd0rO221ln EYoIOzs3DBF6U/4QB3I37VOWCI/vU2rz9VP+4c5wlsJGAP3GgBFuk6Qe+Y5izdMyOgQ3 uQWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=1BOm5AF/SVPewGAsff3Q3TCQ4aozkAkOLj7Mo396mAE=; b=qpKFRW14+UjAjz9OfTujum6RcKTWigzRd1DCKNs5tTm9EqSUQtUeflQbtFB6yCqEKc 86Irtv2/WBzyKUvJpqWY4c0TMN1+aER1LfK5NC9Ybzhrm5icnDSbnC8KwXWpEcycLIux 8jyzWCZ3MYklqaVlMuVvLvQeOYbb/fMOD9aYNtTWdQV6WxGjvrB4IU91/Fh2UUmC1y8T 2JywC6LOh2lAi6cirtXDgD05zV6+/J/4P8/eKlckdLRFyyD7WLLViha/qjuNFYtSqEhh FBGKk1Py0ygexpXxVXzr64NYaTdFETKrAn0ar+Kau/2tJ2dcwsEKc0tDBAfJZMed7u58 c6MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=HWiNqTf6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a6566c5000000b00477c217a5eesi9101159pgw.317.2023.02.12.07.08.43; Sun, 12 Feb 2023 07:08:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=HWiNqTf6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjBLOxA (ORCPT + 99 others); Sun, 12 Feb 2023 09:53:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbjBLOw5 (ORCPT ); Sun, 12 Feb 2023 09:52:57 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FBAD3A9A; Sun, 12 Feb 2023 06:52:56 -0800 (PST) Received: from fpc.. (unknown [46.242.14.200]) by mail.ispras.ru (Postfix) with ESMTPSA id 2D4C140D403D; Sun, 12 Feb 2023 14:52:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 2D4C140D403D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1676213574; bh=1BOm5AF/SVPewGAsff3Q3TCQ4aozkAkOLj7Mo396mAE=; h=From:To:Cc:Subject:Date:From; b=HWiNqTf6viB3SkNSJIpMeGSyqyOZnFh1lrs096bNFBD4OwxPj6tOY93Yue5jmyRjs 2Y762XhvHCYPEiYeGGLaRb49aeFK8jYbY+yCaLywabHsLSgMc28w2qaQP3U21Avm2c fXLttrcQlZhMr9RZB7YVSGSSuDHjTHj2AjMEQOMo= From: Fedor Pchelkin To: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Fedor Pchelkin , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "John W. Linville" , Vasanthakumar Thiagarajan , Senthil Balasubramanian , Sujith , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: [PATCH 0/1] wifi: ath9k: hif_usb: fix memory leak of remain_skbs Date: Sun, 12 Feb 2023 17:52:37 +0300 Message-Id: <20230212145238.123055-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_SBL_CSS,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757638334074756081?= X-GMAIL-MSGID: =?utf-8?q?1757638334074756081?= Hello, the problem is described in the following patch. Some remarks: I'm not quite sure if the function proposed in the patch should be placed somewhere else in the code... The patch now calls it during device deinitialization after urbs deallocation, and I suppose the interrupt callback ath9k_hif_usb_rx_stream() not to be executed during/after that period (in this case the leak would still remain, but I couldn't reproduce this particular case). Maybe the function freeing remain_skbs should be placed right before calling 'kfree(hif_dev)'? The patch is made on top of [1] master branch. [1] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/ --- Regards, Fedor