From patchwork Sat Feb 11 19:59:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 5282 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1637279wrn; Sat, 11 Feb 2023 12:06:50 -0800 (PST) X-Google-Smtp-Source: AK7set/y99mMC8pSxmNN4tagrWMsJTlqkm+zP6uSI81uhtE/tBliwgPoTVVobIj/kBVjLwpToPyw X-Received: by 2002:a17:90a:1a02:b0:230:9802:fbaf with SMTP id 2-20020a17090a1a0200b002309802fbafmr22191450pjk.35.1676146009793; Sat, 11 Feb 2023 12:06:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676146009; cv=none; d=google.com; s=arc-20160816; b=WGMA7iCcbPOjfZyJWCuyYH9KrHZDTfIU6oVFCmp7su88FPwwgatjc0pfwW4UZPMWBh CLa3kt/58nqSTL1XJgBdjXvZ7qLQBiGR/MA2Eaac0JyjQcW936nJn0SABnL6pL5jPp7A FpZ+GUFso69X8P/bwZ4To4WM8nr8F8zlt6oY+jhzAEpEY5IAkhRGT1vtdQTHzRhI2Q+s hKO1eKpNRrT9VbmVIPTV9K5SU43XPBVYJtLMAD0OhtwKhjQ+Zi//Oh6R9DuV8kzKksFJ 1uVz852wkoRkjWmjESxfXZD1OZhyew7vOT4Ah5miVhAC+ctcgpGy4aMjXxcyAIf6rjyT JPtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=9zZWgSw2dv+vNDtDe9Rvl8F7Fv/omJW33B6s3CwSepw=; b=dbg5Ui29S/78faisaEgApeVWmAMcQcl/P7e45ljXh4YBdhcSj9kXZ0H8cAZDNlZDBi H1Ol+YYhv30Tam7Qf2xHT43m06LKIWpSMoocJeNcuFG/33QchqOlKRqNB1eUXWxRYiTf FCyfTG8TElmcwxCPIwMySEQa3twDwn+hSTbAgSMiGrBqLBGdEotrf4vtTS9wGRyrV39K wSdnuGOy4L+0Itus2iDFmO5kLNHmpGRE0+gg5kT1yqZklS4SmPuWZkfSiCZtiUz+g14j myTixiyNhoCDTWj1TQBhBvt+38Y04HkUhfxlSxuFJBpWojwQHqYKVPRbs+vNjxNDeNcH MB4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b="UV8cC8i/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nl18-20020a17090b385200b00229732d501fsi12590819pjb.155.2023.02.11.12.06.37; Sat, 11 Feb 2023 12:06:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b="UV8cC8i/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbjBKUAT (ORCPT + 99 others); Sat, 11 Feb 2023 15:00:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjBKUAQ (ORCPT ); Sat, 11 Feb 2023 15:00:16 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7196016327; Sat, 11 Feb 2023 12:00:14 -0800 (PST) Received: from fpc.. (unknown [46.242.14.200]) by mail.ispras.ru (Postfix) with ESMTPSA id F329840737BC; Sat, 11 Feb 2023 20:00:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru F329840737BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1676145607; bh=9zZWgSw2dv+vNDtDe9Rvl8F7Fv/omJW33B6s3CwSepw=; h=From:To:Cc:Subject:Date:From; b=UV8cC8i/VJR6dOw5qrWQVjrvZobF4sAHOKO77Dx2Olqw71vl+31G7UsLhS1nkWpfW 58CMu34LCak4dnoqrykA+37uVW1/2/CCWuw5liMg7ovorVKf7PD1Qt4rqtzhfgDTa+ TthFD0JyphXqEbDSU4MvCRhHQmYy9m44AKjWDDzw= From: Fedor Pchelkin To: Ian Kent Cc: Fedor Pchelkin , Matthew Wilcox , Andrei Vagin , Takeshi Misawa , autofs@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: [PATCH 0/1] autofs: fix memory leak of waitqueues in autofs_catatonic_mode Date: Sat, 11 Feb 2023 22:59:49 +0300 Message-Id: <20230211195950.452364-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757566478607141682?= X-GMAIL-MSGID: =?utf-8?q?1757566478607141682?= Syzkaller reports the leak [1]. It is reproducible. The following patch fixes the leak. It was proposed by Takeshi Misawa and tested by Syzbot. In other places of the code the waitqueue is freed when its wait_ctr becomes zero (see autofs_wait_release). So I think it is not actually supposed that inside autofs_catatonic_mode wait_ctr cannot be decreased to zero. Please correct me if I'm wrong. Also, looking at the discussion [2] of the '[PATCH] autofs4: use wake_up() instead of wake_up_interruptible', shouldn't wake_up_interruptible() inside autofs_catatonic_mode() be replaced with wake_up()? [1] https://syzkaller.appspot.com/bug?id=a9412f636e2d733130f8def7975897d0b57f6e37 [2] https://www.spinics.net/lists/autofs/msg01875.html