Message ID | 20230210092642.685905-1-s.hauer@pengutronix.de |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp854149wrn; Fri, 10 Feb 2023 01:37:05 -0800 (PST) X-Google-Smtp-Source: AK7set888PCzN3UWBudAE54jYiwhV8XBVtZOd/bHCFxkmaKkFd+f0fySvdtG2YjKN5Q6IrRqDFwn X-Received: by 2002:a17:906:1511:b0:88d:d304:3432 with SMTP id b17-20020a170906151100b0088dd3043432mr14881894ejd.60.1676021825094; Fri, 10 Feb 2023 01:37:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676021825; cv=none; d=google.com; s=arc-20160816; b=YTR12OVH1K9DcczL8OMlxs2B65DD3PxpWUY0Em3nsQHIb0hqCb5tkyXvnj+wGZcB+Y TAwUQdzjlVxCU73Zqst+NoKJhrNatF2JY3aBhKAXKXACRzdtxwAs+Y+dxZGYtdhLoZz0 /9fU4oz5osssBSEgYoIDvcfNkOkcPVKHRbgnuBcM5sxhX0Uw2NVGi015nMx1Ou04dh/e ldH14ba6iuuHiQY10LAeEU85B7DOUF4ftOfO86ZKfKU+DXXq18Ep7rtvGlEMIoZJbKRR 6KvQSNXApbq1aHKnhIb+ehwK76LMs+bM5aKsk9UyAaJLroVJ3uU+08S4kD5dAW7we/iB De8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=zCZUf4hvgLS5leRwzzEKLy/r78vlmksKqpNKs6lV1P0=; b=OhUp9BTARkZgVeXbIn4XPZni7wcrqPH68koENDR+YpE1oLHsn4QSa/f++h5I8IBev3 2scoOi+c7BOQaSX7euqlGhKWqX6PxPYV0Ly740ymzVX/w5NvS3h2Bk2VKWkLLqDh5XEf LF1vO07BDg795u5nXgFxgdddy4k++2RIFcLWOSgL3QazwbN3GGqrlTD9bIC3UcnVodFT jdO6aEb8xVaWeQlGX3UQfAiQBNq379C9TXRNcIGUwpH7vV+6UoqiAMA1mGdmAD2Fmiz0 yu8+cDPqCKziQPNiSZUBqdnqZYr5hC8eTZtV8++TPIWBh+9FRPQGqKOHYPOoceNs+XPE jrkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 26-20020a170906021a00b0087868ccbcf9si7476465ejd.885.2023.02.10.01.36.42; Fri, 10 Feb 2023 01:37:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231896AbjBJJ1P (ORCPT <rfc822;ybw1215001957@gmail.com> + 99 others); Fri, 10 Feb 2023 04:27:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231667AbjBJJ1L (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 10 Feb 2023 04:27:11 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BECF25BA1 for <linux-kernel@vger.kernel.org>; Fri, 10 Feb 2023 01:27:10 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <sha@pengutronix.de>) id 1pQPgI-0003Uo-2u; Fri, 10 Feb 2023 10:26:58 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <sha@pengutronix.de>) id 1pQPg9-003w5z-LF; Fri, 10 Feb 2023 10:26:50 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <sha@pengutronix.de>) id 1pQPg9-002tIB-Tw; Fri, 10 Feb 2023 10:26:49 +0100 From: Sascha Hauer <s.hauer@pengutronix.de> To: linux-wireless@vger.kernel.org Cc: Neo Jou <neojou@gmail.com>, Hans Ulli Kroll <linux@ulli-kroll.de>, Ping-Ke Shih <pkshih@realtek.com>, Yan-Hsuan Chuang <tony0620emma@gmail.com>, Kalle Valo <kvalo@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, kernel@pengutronix.de, Alexander Hochbaum <alex@appudo.com>, Da Xue <da@libre.computer>, Po-Hao Huang <phhuang@realtek.com>, Andreas Henriksson <andreas@fatal.se>, Viktor Petrenko <g0000ga@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de> Subject: [PATCH 0/2] wifi: rtw88: USB fixes Date: Fri, 10 Feb 2023 10:26:40 +0100 Message-Id: <20230210092642.685905-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757436261520105935?= X-GMAIL-MSGID: =?utf-8?q?1757436261520105935?= |
Series |
wifi: rtw88: USB fixes
|
|
Message
Sascha Hauer
Feb. 10, 2023, 9:26 a.m. UTC
This series addresses issues for the recently added RTW88 USB support reported by Andreas Henriksson and also our customer. The hardware can't handle urbs that have a size of multiple of the bulkout_size (usually 512 bytes). The symptom is that the hardware stalls completely. The issue can be reproduced by sending a suitably sized ping packet from the device: ping -s 394 <somehost> (It's 394 bytes here on a RTL8822CU and RTL8821CU, the actual size may differ on other chips, it was 402 bytes on a RTL8723DU) Other than that qsel was not set correctly. The sympton here is that only one of multiple bulk endpoints was used to send data. Sascha Sascha Hauer (2): wifi: rtw88: usb: Set qsel correctly wifi: rtw88: usb: Fix urbs with size multiple of bulkout_size drivers/net/wireless/realtek/rtw88/tx.h | 2 ++ drivers/net/wireless/realtek/rtw88/usb.c | 36 +++++++++++++++--------- 2 files changed, 25 insertions(+), 13 deletions(-)