mbox series

[v2,0/3] mm/damon: deprecate DAMON debugfs interface

Message ID 20230210044838.63723-1-sj@kernel.org
Headers
Series mm/damon: deprecate DAMON debugfs interface |

Message

SeongJae Park Feb. 10, 2023, 4:48 a.m. UTC 
  Changes from v1
(https://lore.kernel.org/damon/20230209192009.7885-1-sj@kernel.org/)
- Split DAMON debugfs file open warning message (Randy Dunlap)

-----

DAMON debugfs interface has announced to be deprecated after >v5.15 LTS
kernel is released.  And, v6.1.y has announced to be an LTS[1].

Though the announcement was there for a while, some people might not
noticed that so far.  Also, some users could depend on it and have
problems at  movng to the alternative (DAMON sysfs interface).

For such cases, keep the code and documents with warning messages and
contacts to ask helps for the deprecation.

[1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c

SeongJae Park (3):
  Docs/admin-guide/mm/damon/usage: add DAMON debugfs interface
    deprecation notice
  mm/damon/Kconfig: add DAMON debugfs interface deprecation notice
  mm/damon/dbgfs: print DAMON debugfs interface deprecation message

 Documentation/admin-guide/mm/damon/usage.rst | 20 +++++++++++++-------
 mm/damon/Kconfig                             |  7 ++++---
 mm/damon/dbgfs.c                             | 19 +++++++++++++++++++
 3 files changed, 36 insertions(+), 10 deletions(-)

Comments

SeongJae Park Feb. 10, 2023, 6:28 p.m. UTC | #1 
On Fri, 10 Feb 2023 04:48:35 +0000 SeongJae Park <sj@kernel.org> wrote:

> Changes from v1
> (https://lore.kernel.org/damon/20230209192009.7885-1-sj@kernel.org/)
> - Split DAMON debugfs file open warning message (Randy Dunlap)

I usually sent this kind of update for after-merged-into-mm-unstable tree
patches individusally as fixup, but this time I sent whole patchset as a new
version, because I was out of my mind.

For someone who may prefer the usual for-fixup individual patch, attaching the
version below.


Thanks,
SJ

================================= 8< ==========================================
From: SeongJae Park <sj@kernel.org>
Date: Fri, 10 Feb 2023 04:37:19 +0000
Subject: [PATCH mm-unstable] mm/damon/dbgfs: break too long deprecation
 warning message

DAMON debugfs interface deprecation message, which is introduced by
commit 234a68e24b12 ("mm/damon/dbgfs: print DAMON debugfs interface
deprecation message") of mm-unstable, is too long.  Break down into
multiple strings for better code readability.

Fixes: 234a68e24b12 ("mm/damon/dbgfs: print DAMON debugfs interface deprecation message") # mm-unstable
Suggested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/dbgfs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c
index e551a20b35e3..124f0f8c97b7 100644
--- a/mm/damon/dbgfs.c
+++ b/mm/damon/dbgfs.c
@@ -22,7 +22,10 @@ static DEFINE_MUTEX(damon_dbgfs_lock);

 static void damon_dbgfs_warn_deprecation(void)
 {
-       pr_warn_once("DAMON debugfs interface is deprecated, so users should move to the sysfs interface (DAMON_SYSFS).  If you depend on this and cannot move, please report your usecase to damon@lists.linux.dev and linux-mm@kvack.org.\n");
+       pr_warn_once("DAMON debugfs interface is deprecated, "
+                    "so users should move to DAMON_SYSFS. If you cannot, "
+                    "please report your usecase to damon@lists.linux.dev and "
+                    "linux-mm@kvack.org.\n");
 }

 /*
--
2.25.1