From patchwork Sun Feb 5 23:17:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Xu X-Patchwork-Id: 4979 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1961783wrn; Sun, 5 Feb 2023 15:22:23 -0800 (PST) X-Google-Smtp-Source: AK7set84Qe2iSQVZEHu832z6uGLTGssyJuhgD0BySfcs8hb+Fm2QAz7jzG+jMA1P3MZ9/9sMNr6E X-Received: by 2002:a17:906:6a1b:b0:88f:8ef7:c71e with SMTP id qw27-20020a1709066a1b00b0088f8ef7c71emr15410622ejc.14.1675639343450; Sun, 05 Feb 2023 15:22:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675639343; cv=none; d=google.com; s=arc-20160816; b=zeSgxqu339cOWxWJ2nbRQ8J5Md7fgl6oNDPFXeloeNc6rZ4rwxVpBri2+A69BhZgV2 1k000OOxnGAE0jhQtnvNAUC/2Nvj2PPY+jln0IHQSKj833gFCx+nPEWMSQN+iUKmTsj0 4Y0D4vT24DgRcEpH7ei19L4fds6lByN/1hBg5sEYOl1GFfkYTZAOg5KWSAmg5lGMrowQ FEUX8OM2woUHISzucHaj+gEhHoim98aNXHx7zDyLLT4BAIYT8ffWFIhkTHwesPN4BH9A iO028d9IcuGKgsjLsSZ8Ac53/5e7DVjmGY5uE3tS18V7yqbdfUa4bawqOrv2423sSMbp T0qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hczbFL+ar/tk/IYpzPCczVyi3teFQZrB1wxKh73TL0g=; b=tF0G5z7Z//R1tf5lVlpdC7oR/LS0ij7gW0ihcGXIIiUZv932xuw2P8pxqf541d8nzp eVrnMQ3vdShISz2FCn4oLiO8tjObhwjDee74/mHoAFvVwMYsXtGJQ3oCBxN/3p8dAu2s TIrqIIyCcTScMj8BcqA/I1nEjEdvdu4e8iicUBlds3/WVFMz8b5mdlXD1Za+NQRQ6Q+W 8nrUAfccalAu7oPpEADZHpoXAS2mOR7nTonPlYTh/koGLwXKKpgIn5gHYmELU1Jo3st4 DB+2AiLD0Ch/cErfKT/5+VVT6y/TxyRLvlGc9j1jMrJqCGTybkvmmhI7SJjYOLIga5iV 0UDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gLAF8qii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id um37-20020a170907cb2500b0087d9362c240si9856621ejc.509.2023.02.05.15.22.00; Sun, 05 Feb 2023 15:22:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gLAF8qii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229654AbjBEXSA (ORCPT + 99 others); Sun, 5 Feb 2023 18:18:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjBEXR5 (ORCPT ); Sun, 5 Feb 2023 18:17:57 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 119291968A for ; Sun, 5 Feb 2023 15:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675639028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hczbFL+ar/tk/IYpzPCczVyi3teFQZrB1wxKh73TL0g=; b=gLAF8qii/iuEwBLmyjF0T1Y6jdTmzsBC9JuY0dGdh0wfaJT5S3EVu2dbG1NVRhRY5s3/qE N9oJQO4aR+tuSd4Tv5avZh18HY12a1KQrdBvMwzPxV/1bAT0qOGIqGET5XMhUQDeqVv7Qx TiHo+i9cLl60RIy6ikPdU2GrH0/l5dA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-528-xdLjNT1pPCu_S-B8s8B-Cg-1; Sun, 05 Feb 2023 18:17:06 -0500 X-MC-Unique: xdLjNT1pPCu_S-B8s8B-Cg-1 Received: by mail-qk1-f198.google.com with SMTP id u11-20020a05620a430b00b007052a66d201so6892546qko.23 for ; Sun, 05 Feb 2023 15:17:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hczbFL+ar/tk/IYpzPCczVyi3teFQZrB1wxKh73TL0g=; b=CHZmEcz2SHCZZM4NVRrhkAtaSzJd1sNpQsldofPcL3/7CUiIAPWl8JjCuqLsV/dJTk GaHVrJl2rzK87F04wzbMueOQVIvmbLSeeec3q+S2xNaEp4lL6bIaVFxvhQ9qYl+Hkdp8 aDtxcbaO8TiSKXiYGg1P9yQjI5bvFLJmq0ZSgRkmIakPvg8D9dFlN9Zixna02UIPRUTt TJQDSHEOLW85kgRSXGW44GRPzFV3BqxnpH8pikdHztylfDk+8x037f6mEI1106XCcdIK A431Kdk8r0q4A+YS2sR5lPkmW6flwh7ZmI0D91EKu0vs1Ed27Gw1GBfNWYscYWaPvHma M6Tw== X-Gm-Message-State: AO0yUKU1n60eQnBoNk6+uEdCfBzeAAkFcAJpanvS6i5Uaqcp/AP+oji7 mheKSDtR+XqPb7fF5Ty0z9ZzfpHgD75Hj3QOQct5EEFIvwfkpNVji9pI+oKTBSW6a5JEM08KSHL yJFRB80KftJ5ACemooIuTdK9p X-Received: by 2002:a05:622a:a15:b0:3b8:695b:aad1 with SMTP id bv21-20020a05622a0a1500b003b8695baad1mr31166805qtb.1.1675639026387; Sun, 05 Feb 2023 15:17:06 -0800 (PST) X-Received: by 2002:a05:622a:a15:b0:3b8:695b:aad1 with SMTP id bv21-20020a05622a0a1500b003b8695baad1mr31166787qtb.1.1675639026141; Sun, 05 Feb 2023 15:17:06 -0800 (PST) Received: from x1n.redhat.com (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id h26-20020ac8515a000000b003b82cb8748dsm5986545qtn.96.2023.02.05.15.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Feb 2023 15:17:05 -0800 (PST) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: peterx@redhat.com, Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: [PATCH 0/3] mm/arch: Fix a few collide definition on private use of VM_FAULT_* Date: Sun, 5 Feb 2023 18:17:01 -0500 Message-Id: <20230205231704.909536-1-peterx@redhat.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757035200047313693?= X-GMAIL-MSGID: =?utf-8?q?1757035200047313693?= I noticed a few collision usage on VM_FAULT_* definition in the page fault path on arm/arm64/s390 where the VM_FAULT_* can overlap with the generic definition of vm_fault_reason. The major overlapped part being VM_FAULT_HINDEX_MASK which is used only by the hugetlb hwpoisoning. I'm not sure whether any of them can have a real impact, but that does not look like to be expected. I didn't copy stable, if anyone thinks it should please shoot. Nor did I test them in any form - I just changed the allocations from top bits and added a comment for each of them. Please have a look, thanks. Peter Xu (3): mm/arm: Define private VM_FAULT_* reasons from top bits mm/arm64: Define private VM_FAULT_* reasons from top bits mm/s390: Define private VM_FAULT_* reasons from top bits arch/arm/mm/fault.c | 8 ++++++-- arch/arm64/mm/fault.c | 8 ++++++-- arch/s390/mm/fault.c | 14 +++++++++----- 3 files changed, 21 insertions(+), 9 deletions(-)