From patchwork Sun Feb 5 22:43:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qais Yousef X-Patchwork-Id: 4978 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1951553wrn; Sun, 5 Feb 2023 14:47:13 -0800 (PST) X-Google-Smtp-Source: AK7set8ppBX7lQzsZsQejhU/3OEqbdzlW869kJzzDwQvZ1h095pTVlfirJGsljv9NMQFMqxpk+gi X-Received: by 2002:a17:906:e118:b0:878:7662:7c8e with SMTP id gj24-20020a170906e11800b0087876627c8emr18189342ejb.55.1675637232995; Sun, 05 Feb 2023 14:47:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675637232; cv=none; d=google.com; s=arc-20160816; b=GLum8pVy5eoGikEydHEV909vMWMhFjlhI0edjpWn0RvTBEpK0Gk1+TYieaFyBWDZfK EiUYTDH65GgGRR0GSERq/+pbL4PuvwCop1SedSErPBbDI3hM95V4BUn0rur8ymaNRjcO o/l0ufXuuXfBt4oOYnwt8IHmPxRdrdhLfHI8UB4CJPp5upTH4JKNzIaSz+00YSq4Z+Ix qJxT07T8gpkPHtI51lRwV2LIdr7k3HkNe4Tj9LGib7oqp9HgWkJveB4DlGKrEZCfrUyP 8b8vXEVVpe8i0FhuOyyr37KwXcUnaxRNV3g4QZas//kE+4e9ujMJvz1u9aeC3PJ2qYVg teHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1J3XyqEQxBVec+OJzxFprhMNdYo0Joqgd8k6vAa+lMo=; b=tabz+cy/QYDdol7utRHHcMGwsG7HdgBQwp1KDHQzcAN4BGd036k92CRfont9ud9gOf zXnqMl6TpKxOdYnC2UHcWLRndClgTjxozY3xIScS+UOboPmVBmUFUVkUFfPOg9fPtqND lMORD0VLKjq6wKYqYxhWSozFYUOTqPeAYyVKziszKaua0lftIitfJ2GFnsTuUYln3/Ct nZLoYYA749KNxSxxwBAbkt5eEBLS4GkYRycoLWojznrqKmp0UTxy6knoyLPSbBBXsJcR 4Z2iTSBCYSNnq+x789ciIgUOFm9+F+GbNh8CsHbh/dHWinyKCmIP1gbbiWpc9n3hKtqk RaUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@layalina-io.20210112.gappssmtp.com header.s=20210112 header.b="kyaVD0Q/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 18-20020a170906009200b00888161349c7si12691308ejc.656.2023.02.05.14.46.50; Sun, 05 Feb 2023 14:47:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@layalina-io.20210112.gappssmtp.com header.s=20210112 header.b="kyaVD0Q/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229581AbjBEWne (ORCPT + 99 others); Sun, 5 Feb 2023 17:43:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjBEWnd (ORCPT ); Sun, 5 Feb 2023 17:43:33 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4753519F2D for ; Sun, 5 Feb 2023 14:43:31 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id bk15so29426584ejb.9 for ; Sun, 05 Feb 2023 14:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1J3XyqEQxBVec+OJzxFprhMNdYo0Joqgd8k6vAa+lMo=; b=kyaVD0Q/xHQiVH9DbCAkcqf7ZSurcmBBwcNYvRmfC6+MpULMNDpIhbYqXLpJn1ByHl 7cU+oPblagiCuqT/Lxaaef5dqVWO/8vfskaCQBxg3ADY6a6OZvg6arjohfivwoN3CU8K Y++gnm6+/jFpkoC9nBPzWlXHqqEkwggmUEYBKPDHyFg5XdcnpHl/2Y9SR3pDxgnHxhbr eZqqFXLvkkviUKeUauZvxzWOM8G2c3jmAWvuScvjfw1FqsLIz9JfazeFNj7KDT0mVP08 iXvvrjlJDaAu+yQ9GRBzFGJ9ybo8K18HYWYGE3k0DltmzdjTbdH7SCF9IDlfS4GuaFDV 5nMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1J3XyqEQxBVec+OJzxFprhMNdYo0Joqgd8k6vAa+lMo=; b=WSHupPvSGzH4n6od6JnKQvMc+JRm20kLf0R/+XHjnTLfLyE6oWNJMkSZHJXJ7chF9b VdoqKvMUU1RbrvoTFZmZeB1D4t2IfPt/3Nnn1rC/fIaro52gGm+1LcP1WeLGoQbabJYn GMPEKo4Rjg3oiADkPMdD4KMThiyKfE/4WVRGr7D+Nr/e+9kAjEg5BiU5eT1CJRewFY4h l7Xqc5HQ5sv4CfDljdNTo9KzvigMiwIFyoFvhpFhZdeZK7XY1OPuv5h0sUzPp1sjMlez VXbb6cyvwTzob5nqhbT1cbymzFsSIUywkOl1m6nJKdkBhTbrwN1C/IRRMOYPS4kDEG2L Uk/Q== X-Gm-Message-State: AO0yUKW8ifHJO1nplRZpFftRIARiOQbaAmxB+Zhgsh7zAX41XBdJFykc tyMbpagME6GTZFUuSw2jnOJh8Q== X-Received: by 2002:a17:906:5a4c:b0:87b:7c1e:7d58 with SMTP id my12-20020a1709065a4c00b0087b7c1e7d58mr17552876ejc.53.1675637009849; Sun, 05 Feb 2023 14:43:29 -0800 (PST) Received: from localhost.localdomain (host86-163-35-10.range86-163.btcentralplus.com. [86.163.35.10]) by smtp.gmail.com with ESMTPSA id m15-20020a1709061ecf00b0087bd2924e74sm4550779ejj.205.2023.02.05.14.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Feb 2023 14:43:29 -0800 (PST) From: Qais Yousef To: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann Cc: linux-kernel@vger.kernel.org, Lukasz Luba , Wei Wang , Xuewen Yan , Hank , Jonathan JMChen , Qais Yousef Subject: [PATCH v2 0/3] Fix a couple of corner cases in feec() when using uclamp_max Date: Sun, 5 Feb 2023 22:43:15 +0000 Message-Id: <20230205224318.2035646-1-qyousef@layalina.io> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757032986973463960?= X-GMAIL-MSGID: =?utf-8?q?1757032986973463960?= Changes in v2: * Use long instead of unsigned long to keep the comparison simple in spite of being inconsistent with how capacity type. * Fix missing termination parenthesis that caused build error. * Rebase on latest tip/sched/core and Vincent v5 of Unlink misift patch. v1 link: https://lore.kernel.org/lkml/20230129161444.1674958-1-qyousef@layalina.io/ Patch 1 addresses a bug because forcing a task on a small CPU to honour uclamp_max hint means we can end up with spare_capacity = 0; but the logic is constructed such that spare_capacity = 0 leads to ignoring this CPU as a candidate to compute_energy(). Patch 2 addresses a bug due to an optimization in feec() that could lead to ignoring tasks whose uclamp_max = 0 but task_util(0) != 0. Patch 3 adds a new tracepoint in compute_energy() as it was helpful in debugging these two problems. This is based on tip/sched/core + Vincent's v5 of Unlink util_fits_cpu()... patch [1] [1] https://lore.kernel.org/lkml/20230201143628.270912-1-vincent.guittot@linaro.org/ Qais Yousef (3): sched/uclamp: Set max_spare_cap_cpu even if max_spare_cap is 0 sched/uclamp: Ignore (util == 0) optimization in feec() when p_util_max = 0 sched/tp: Add new tracepoint to track compute energy computation include/trace/events/sched.h | 4 ++++ kernel/sched/core.c | 1 + kernel/sched/fair.c | 18 +++++++++++------- 3 files changed, 16 insertions(+), 7 deletions(-)