Message ID | 20230205080559.8319-1-straube.linux@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1684407wrn; Sun, 5 Feb 2023 00:14:22 -0800 (PST) X-Google-Smtp-Source: AK7set83vAquP+LmLrPGf3OwPWNCjHlGpqKiMjL8OnIGxCths1bw/Eq+eTIxzLDyRrY0gvbegk9O X-Received: by 2002:a17:907:7f94:b0:888:bb84:7a73 with SMTP id qk20-20020a1709077f9400b00888bb847a73mr19941677ejc.56.1675584862328; Sun, 05 Feb 2023 00:14:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675584862; cv=none; d=google.com; s=arc-20160816; b=ejCfuuKBeYVMdNoFt0lXEZE3JZhm/3zMpEfeQvNuiL7mDzSakKmRi6aCrHD4QEQpx8 vE2eVP1VCAfbi23GWSM77aXzNx/LeDxQL0KAZU+ENKv436N6FYGb8lfeh9xRK5oK9+3y FWRxUjja3iUsca66x8V5KB/epXRPGFePug7wyS9XZMEmLwSaWRBv1qo2r5FZSTptalSK nwMj/tlAL9+SKV8VLN8YBfU+SqmXZmxUvNnSmYmm83UN25M5BNE+FKbYuEuvD45OFMc0 dG8HqTQlVLohjALCBtMIiLfBfx38ggFzAh94GK75vZOisi9IPc9VzsMnCzroxRQCVvkP GE1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Cf43ZAC9d9vV87Brf749qwDNEbTSGBab1FS9DyewXkE=; b=Wz0rvSgYVMYM1HQUlSj6OCNagEv4fZHdsVjVzyRtE8IViBp6ed4Ue7F75I4I+Zt8BI A+BOb3C4acBrGxV4JpAaTKZ8TMhcOsCNV5iu8WtlVInXQuOKK0d6KXxp5vnFMgJPEN0c aizEZh8XHyrVaBfv1c2ykViFlvw6Tt7+GK2oYBQOoI5vnaeZlHlZbHIWg8jXQFI4ZTXH mk0EPNLHI7BXTavV+Sog12MyMUn071qxprYDqA/JRMJryePEPvMwwM7zfBXXlURuz49X CmzQO0nVJjuLAyNoxF/lnbXDw5C8Tgz0OjSV96mSZVCVolquf39gjM26rS03Y1KdkijH nb3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IYzxAnFf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fe18-20020a1709072a5200b0089df7e8bbacsi999523ejc.787.2023.02.05.00.13.52; Sun, 05 Feb 2023 00:14:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IYzxAnFf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229495AbjBEIGR (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others); Sun, 5 Feb 2023 03:06:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjBEIGO (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 5 Feb 2023 03:06:14 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CF2720D21 for <linux-kernel@vger.kernel.org>; Sun, 5 Feb 2023 00:06:13 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id ee13so2229900edb.5 for <linux-kernel@vger.kernel.org>; Sun, 05 Feb 2023 00:06:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Cf43ZAC9d9vV87Brf749qwDNEbTSGBab1FS9DyewXkE=; b=IYzxAnFf7wdql5pNk1TmzsC9UPQ7Cwt72Sz7/xF0jPG2kf2CTMAE+6qsUjmcs75YFm gwYr9dCg+Fvih+BixjfsA69bk5FMag3n88eqUg/QxrcTvHs1Jt8tAtuc37Ln3pk0Wg1d ZPkoP1Ft5Y9Q501jx7BOlqX9ZJjxGkGK3t2hxnG4rql05HsfbWRumyn0MFlbongnY4eF gs6FtfWbF7y1MU8jOx72EQGG59RdV0oin6Tq5Esh3jMk9z6a6rit4qFE1MFpftq1XKIb xO8RDtbygHZ16oLbLGgtCFUM5uzIVHq33VqfHFVGjwEZ70GQcIr8z5NInXZg2TZ9aZUw pBNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cf43ZAC9d9vV87Brf749qwDNEbTSGBab1FS9DyewXkE=; b=hzeHmI3eCCnhd7XRAAF5cCKvk6eeByABGHB+AEz3JVjLUvRVYi5YBJ6SjDDwHD5pFB A0shlK0x3C2gRSc2yhtLoRDw8LhGfwV+zq03OKz/L/ZojbjU3QVBCETh+G2WzZ/G7sKz ktUMyDOotBfiDdcEEneK5AgxwewH3xcReLzff0uvyU2SHq2SO2nFlRO2i1+NxIePD2IJ hhsGvLu4h9BAv7nK5h4RPzMdEg0l9/+oAJ6wnSmVdpcbkRosT774idP+ve2VxzPMxujd nE/VoOF3h9gYBKbXB44gjM9quP6f0OYibwjgGT66oQbR4DvTCCvjK8GnJFrSr9IdW05k yTHg== X-Gm-Message-State: AO0yUKUnbedd7rNAggCPm0EetdumfV+FbzmRsrZgORc6JaBgfd6sAuyX zs8tLjBlcP2CXaTaTGdkG+E= X-Received: by 2002:a05:6402:2206:b0:4a2:1b97:228c with SMTP id cq6-20020a056402220600b004a21b97228cmr13979648edb.28.1675584370914; Sun, 05 Feb 2023 00:06:10 -0800 (PST) Received: from localhost.localdomain (ip5f5abbf9.dynamic.kabel-deutschland.de. [95.90.187.249]) by smtp.gmail.com with ESMTPSA id q10-20020a056402518a00b00463bc1ddc76sm3441379edd.28.2023.02.05.00.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Feb 2023 00:06:10 -0800 (PST) From: Michael Straube <straube.linux@gmail.com> To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube <straube.linux@gmail.com> Subject: [PATCH v2 0/2] staging: r8188eu: correct error logic of two functions Date: Sun, 5 Feb 2023 09:05:57 +0100 Message-Id: <20230205080559.8319-1-straube.linux@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756978072696070419?= X-GMAIL-MSGID: =?utf-8?q?1756978072696070419?= |
Series |
staging: r8188eu: correct error logic of two functions
|
|
Message
Michael Straube
Feb. 5, 2023, 8:05 a.m. UTC
This series converts two functions away from returning _SUCCESS and _FAIL. Another tiny step to get rid of _FAIL / _SUCCESS someday. Tested on x86_64 with Inter-Tech DMG 02. v2: Removed the initialization of the variable err in _rtw_init_recv_priv() since it's not needed. Michael Straube (2): staging: r8188eu: correct error logic of rtl8188eu_init_recv_priv() staging: r8188eu: correct error logic of _rtw_init_recv_priv() drivers/staging/r8188eu/core/rtw_recv.c | 30 +++++++++-------------- drivers/staging/r8188eu/os_dep/os_intfs.c | 2 +- 2 files changed, 12 insertions(+), 20 deletions(-)
Comments
On 2/5/23 09:05, Michael Straube wrote: > This series converts two functions away from returning _SUCCESS and > _FAIL. Another tiny step to get rid of _FAIL / _SUCCESS someday. > > Tested on x86_64 with Inter-Tech DMG 02. > > v2: > Removed the initialization of the variable err in _rtw_init_recv_priv() > since it's not needed. > > Michael Straube (2): > staging: r8188eu: correct error logic of rtl8188eu_init_recv_priv() > staging: r8188eu: correct error logic of _rtw_init_recv_priv() > > drivers/staging/r8188eu/core/rtw_recv.c | 30 +++++++++-------------- > drivers/staging/r8188eu/os_dep/os_intfs.c | 2 +- > 2 files changed, 12 insertions(+), 20 deletions(-) > Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150