From patchwork Fri Feb 3 22:48:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 4953 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1096237wrn; Fri, 3 Feb 2023 14:54:32 -0800 (PST) X-Google-Smtp-Source: AK7set8v7PIHDCFok0ezAf3MgnSrAj0bNvQtN9ZujR0UI8SUEA9dvRGpcgKy3BzQCNx4a9kJB/Al X-Received: by 2002:a17:906:4b09:b0:883:4ce3:99c2 with SMTP id y9-20020a1709064b0900b008834ce399c2mr10689456eju.34.1675464872550; Fri, 03 Feb 2023 14:54:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675464872; cv=none; d=google.com; s=arc-20160816; b=poUyPaMLog15+mRblS+biPgzRgSVPB5KtCTBt7mHcBtgDo4/YLMHfWeor9XUTWEkZZ uGZ+kxTwJrOrD0eWBPBibe+jwr+sxYAquVYjYpflgs64rwyh7ionZKSvsN4uumUGJQJu V0Zbj3lwrt0YjBui7lft0MjqBtLNYj0cz5wMr3Eni1xsHgnm3mnXZ9mJpDZCMjFMQf99 1zAmsQUmXxgN4QH1tr5lbnkH3i7Xy18PXB+fbdJt5J/EMGBhV4vStrcZMxymF+IKkqja 1/K/mcxuuaNFUOlK9+43MhXBZhOzi3x0BzUQ74tPydpje+S1w/wg5hgR1JLlQhlAAJ7K Us/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FP7nci/77RSPAT28XsCY8KBkLpJSYOpYjkSuDp2G2GQ=; b=jui/ANsi3+3/163Bt1tyjYuI2sDQ4v61Jym0qte1p0ZRWhYCxR8mIfo122wGXmKPRz H+adADiVoNluUDSAd6DfCXgDHZc7m5iW50DUvn+URkQQwdDCHmVM0Z9RBw+6fyr36ie2 TVC4oGmm1dFIaRcRdkMIGiLjgeb9HbmtLzsbEELnmRZJyI493OaBNT9a/hgctJuI+egh p7oFZEWir5pmPTlhg9l5fMDm1+i9xkgdBWzckrwqpQXdfFrUKFGEP0+Vroe1VETWUzf6 5fCsrvyLf5U9H9NGAp/rQNRibdvsSLsggBORWA5fKrZ4UTxJ3TYi8GHvLqdU3RyzrHEC O2Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bMX0KtOX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l2-20020a170906a40200b007c0b56b90f5si3916858ejz.307.2023.02.03.14.54.07; Fri, 03 Feb 2023 14:54:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bMX0KtOX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232616AbjBCWsa (ORCPT + 99 others); Fri, 3 Feb 2023 17:48:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231495AbjBCWs3 (ORCPT ); Fri, 3 Feb 2023 17:48:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 278C94ED2; Fri, 3 Feb 2023 14:48:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C0A376202D; Fri, 3 Feb 2023 22:48:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8411C433D2; Fri, 3 Feb 2023 22:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675464507; bh=L+j3zyBTSLXoDH9WzKEgDlfEwY4t1m/PDI2fWFFLV3E=; h=From:To:Cc:Subject:Date:From; b=bMX0KtOXiYKeOA5750I10ZIzIEvztf9yqY+oQAumllUWUlWCwe7jnxvULn916P9AF d8MtDtPPjmX5P384kmZ6+0x+5mvc7bz+ugH2aSA4O8ulnKQrFMCatoHh0TJrWI5uWB W8h8sExl2uXjBUSoQMwaBNVQctlWd5djqu3H9m9cm71AL4wZQY2wWxItYex2elvk2g mvtsuLVEIkKPqxRscLczjX/rQpKYC0O3MFwgF5RnCeDDkwjNOLjI1psX8EhRGGgZG/ kKNXu0oyqzcGsITDfHdOuEiOV7iIz1AdPl2SaCyuhlhO1eubjo/Uv/V8vbRZzikJP1 M+Q+Ghez64wbg== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Thomas Witt , Vidya Sagar , linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 0/2] Revert ASPM L1 Substates updates Date: Fri, 3 Feb 2023 16:48:18 -0600 Message-Id: <20230203224820.2056582-1-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756852254523372581?= X-GMAIL-MSGID: =?utf-8?q?1756852254523372581?= From: Bjorn Helgaas Thomas Witt reported that 5e85eba6f50d ("PCI/ASPM: Refactor L1 PM Substates Control Register programming") broke suspend/resume on a Tuxedo Infinitybook S 14 v5, which seems to use a Clevo L140CU Mainboard. See https://bugzilla.kernel.org/show_bug.cgi?id=216877 Since we haven't figured out a root cause, revert the relevant patches for now. Note that reverting "Save L1 PM Substates Capability for suspend/resume" means machines will use more power after suspend/resume because the L1 Substates configuration is lost, but they should still work correctly. Bjorn Helgaas (2): Revert "PCI/ASPM: Save L1 PM Substates Capability for suspend/resume" Revert "PCI/ASPM: Refactor L1 PM Substates Control Register programming" drivers/pci/pci.c | 7 --- drivers/pci/pci.h | 4 -- drivers/pci/pcie/aspm.c | 109 ++++++++++++---------------------------- 3 files changed, 33 insertions(+), 87 deletions(-)