mbox series

[0/2] Script style improvements in lib/coresight.sh

Message ID 20230201214945.127474-1-didi.debian@cknow.org
Headers
Series Script style improvements in lib/coresight.sh |

Message

Diederik de Haas Feb. 1, 2023, 9:49 p.m. UTC 
  These 2 patches improve the efficiency and quality of the
lib/coresight.sh script.

The first one uses grep's `-c` parameter to count the results instead of
piping it to `wc -l`.
The second one replaces the use of backticks (`...`) with $(...) as the
former has several potential issues while the latter does not.

Diederik de Haas (2):
  perf test: Replace 'grep | wc -l' with 'grep -c'
  perf test: Replace legacy `...` with $(...)

 tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Comments

Arnaldo Carvalho de Melo Feb. 2, 2023, 1:53 a.m. UTC | #1 
Em Wed, Feb 01, 2023 at 10:49:43PM +0100, Diederik de Haas escreveu:
> These 2 patches improve the efficiency and quality of the
> lib/coresight.sh script.
> 
> The first one uses grep's `-c` parameter to count the results instead of
> piping it to `wc -l`.
> The second one replaces the use of backticks (`...`) with $(...) as the
> former has several potential issues while the latter does not.
> 
> Diederik de Haas (2):
>   perf test: Replace 'grep | wc -l' with 'grep -c'
>   perf test: Replace legacy `...` with $(...)



Thanks, applied.

- Arnaldo
Carsten Haitzler Feb. 2, 2023, 8:38 a.m. UTC | #2 
On 2/1/23 21:49, Diederik de Haas wrote:
> These 2 patches improve the efficiency and quality of the
> lib/coresight.sh script.
>
> The first one uses grep's `-c` parameter to count the results instead of
> piping it to `wc -l`.
> The second one replaces the use of backticks (`...`) with $(...) as the
> former has several potential issues while the latter does not.
>
> Diederik de Haas (2):
>    perf test: Replace 'grep | wc -l' with 'grep -c'
>    perf test: Replace legacy `...` with $(...)
>
>   tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
ACK to all of this series.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Arnaldo Carvalho de Melo Feb. 2, 2023, 1 p.m. UTC | #3 
Em Thu, Feb 02, 2023 at 08:38:46AM +0000, Carsten Haitzler escreveu:
> On 2/1/23 21:49, Diederik de Haas wrote:
> > These 2 patches improve the efficiency and quality of the
> > lib/coresight.sh script.
> >
> > The first one uses grep's `-c` parameter to count the results instead of
> > piping it to `wc -l`.
> > The second one replaces the use of backticks (`...`) with $(...) as the
> > former has several potential issues while the latter does not.
> >
> > Diederik de Haas (2):
> >    perf test: Replace 'grep | wc -l' with 'grep -c'
> >    perf test: Replace legacy `...` with $(...)
> >
> >   tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++---------
> >   1 file changed, 9 insertions(+), 9 deletions(-)
> >
> ACK to all of this series.

Thanks, added to the two patches, that I processed yesterday, still in
tmp.perf/core.

- Arnaldo