Message ID | 20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1995914wrn; Sun, 29 Jan 2023 20:00:46 -0800 (PST) X-Google-Smtp-Source: AK7set8xFYFyAUoDGjTQazhmN7QExU8bnx7+JkMwcLdU9qetybCx66Aq9cX8K6h1r5o64C4T+Tfe X-Received: by 2002:a17:907:6e20:b0:87a:7097:ebcf with SMTP id sd32-20020a1709076e2000b0087a7097ebcfmr17249938ejc.42.1675051246543; Sun, 29 Jan 2023 20:00:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675051246; cv=none; d=google.com; s=arc-20160816; b=q9YhiLu4lU27kltQD4HrGfT+i0HJ5RcdYboPk8Bg72ZaHmye0Ti3dis9zs9FO+WIYC yWCK01uVtr8zluV0orSjPQhJu9VAzSBLmapQIKPSTHhJTYo4xtsWN3OW+LwyJKcJWoi0 GtSS+s1UlP8t+cjIj5KR0SMtiFc1ZlxobUHLuym8k5M/j56Oonm8y4QHfdgSttzc87WG l9atk4ib0s19SBjzvjNcWIT9cZeXtAq5QbHXtI/GmORNmC8d6z1sTsJmCUCmC95jS2Mj lEFeGJpW9O3EZ4M9vwHREGdtQ5ceLzM+Dicq4fCTRyjOoNZeSuCcF886nuogeXkh40ti CYZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:dkim-signature:from; bh=Bi0QSFITj32vRVHvwdbcNh4bXCqzHSO6pLziI9q7AAw=; b=bhhZX6FJdCJtOCzcdQ+0QtK42iwlYnO2nlKMGwFL6Y3lEX2opX8/BDPWmztpvz2x+i Mmvio/nP09jaTalBWvf4mvEc7dCgohYxpiYNo25QA4G6ywcdCOEpxmf3lMGJ26/dQ/hF gKWhnguff3HAil5Gq1MXD/22bWD8FHAazUU+s+m3In9qBZLTJXZuo5QqMI1s5tZLpfhM ZUm94lAlDMk2hwHWtXYP+c0vUDaQivIPyR6BKrzUa4WPKIlveD1WW8insxzsakFNsX8e n5+QGrSx2UHnWcvYybvY1rPBVR9+6sNplCdy91WLVfHPzgv26Ywur249kQNe7NTQ21/e LAwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=URXQEDOM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fv22-20020a170907509600b007c177c92bcfsi6275452ejc.977.2023.01.29.20.00.22; Sun, 29 Jan 2023 20:00:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=URXQEDOM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235519AbjA3EAJ (ORCPT <rfc822;n2h9z4@gmail.com> + 99 others); Sun, 29 Jan 2023 23:00:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234930AbjA3EAD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 29 Jan 2023 23:00:03 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D49991448D; Sun, 29 Jan 2023 19:59:49 -0800 (PST) From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net> DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1675051187; bh=iX47upW85gfJMHXCNpRtaH9985qjJ/jS5RtXWPSoIgg=; h=From:Subject:Date:To:Cc:From; b=URXQEDOMQ30evZignf53zq4fcP+gjLYiP8q4WOrWjvftKlFLN5pDksPfGwtSfKYfj 7GWr6NC6zgSyblLQuOIz5ROb9kgxN5qjcg/vtbb8/nGH4iqPDPmGC6k7CazHH/9ZSm P7AyjEgkp8JEVtwfP3uF4ruicpBanmnISCxFI87I= Subject: [PATCH 0/9] HID: Constify lowlevel HID drivers Date: Mon, 30 Jan 2023 03:59:36 +0000 Message-Id: <20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAKhA12MC/x2NQQoCMQwAv7LkbKDdXsSviIe2SW2gZCXRRVj27 xaPMzDMAc4m7HBbDjDexWXTCfGyQO1Zn4xCk2ENawoxBexCWDf1N46BZLKzYauNKOUWY7nCLEt 2xmJZa5+tfsaY8mXc5Ptf3R/n+QNb+Cy3egAAAA== To: Basavaraj Natikar <basavaraj.natikar@amd.com>, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, "K. Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>, =?utf-8?q?Filipe_La=C3=ADns?= <lains@riseup.net>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Maximilian Luz <luzmaximilian@gmail.com>, Corentin Chary <corentin.chary@gmail.com>, Hans de Goede <hdegoede@redhat.com>, Mark Gross <markgross@kernel.org>, Viresh Kumar <vireshk@kernel.org>, Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net> X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1675051184; l=1428; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=iX47upW85gfJMHXCNpRtaH9985qjJ/jS5RtXWPSoIgg=; b=wUViSb0tGQR60ua/5uXJ4ubJuesnlmDI25uiARSVmgdEPgnthqmmTYYrXBbv5el7sWYGYDodKxYP cdNZVeuGB1p0HWiMJ6mcEVfNyvmNoYYYAXwfHnGmb5Jg7ff6SGQI X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756418535411875772?= X-GMAIL-MSGID: =?utf-8?q?1756418535411875772?= |
Series |
HID: Constify lowlevel HID drivers
|
|
Message
Thomas Weißschuh
Jan. 30, 2023, 3:59 a.m. UTC
Since 52d225346904 ("HID: Make lowlevel driver structs const") the
lowlevel HID drivers are only exposed as const.
Take advantage of this to constify the underlying structures, too.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (9):
HID: amd_sfh: Constify lowlevel HID driver
HID: hyperv: Constify lowlevel HID driver
HID: logitech-dj: Constify lowlevel HID driver
HID: steam: Constify lowlevel HID driver
HID: intel-ish-hid: Constify lowlevel HID driver
HID: surface-hid: Constify lowlevel HID driver
platform/x86: asus-tf103c-dock: Constify lowlevel HID driver
platform/x86: asus-tf103c-dock: Constify toprow keymap
staging: greybus: hid: Constify lowlevel HID driver
drivers/hid/amd-sfh-hid/amd_sfh_hid.c | 2 +-
drivers/hid/hid-hyperv.c | 2 +-
drivers/hid/hid-logitech-dj.c | 4 ++--
drivers/hid/hid-steam.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/surface-hid/surface_hid_core.c | 2 +-
drivers/platform/x86/asus-tf103c-dock.c | 4 ++--
drivers/staging/greybus/hid.c | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
---
base-commit: e04955db6a7c3fc4a1e6978649b61a6f5f8028e3
change-id: 20230130-hid-const-ll-driver-fcfdd3af11b8
Best regards,
Comments
Hi, On 1/30/23 04:59, Thomas Weißschuh wrote: > Since 52d225346904 ("HID: Make lowlevel driver structs const") the > lowlevel HID drivers are only exposed as const. > > Take advantage of this to constify the underlying structures, too. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Thanks, series looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> I'll also pick up / merge patches 7 + 8 into pdx86/for-next sometime this week. Regards, Hans > --- > Thomas Weißschuh (9): > HID: amd_sfh: Constify lowlevel HID driver > HID: hyperv: Constify lowlevel HID driver > HID: logitech-dj: Constify lowlevel HID driver > HID: steam: Constify lowlevel HID driver > HID: intel-ish-hid: Constify lowlevel HID driver > HID: surface-hid: Constify lowlevel HID driver > platform/x86: asus-tf103c-dock: Constify lowlevel HID driver > platform/x86: asus-tf103c-dock: Constify toprow keymap > staging: greybus: hid: Constify lowlevel HID driver > > drivers/hid/amd-sfh-hid/amd_sfh_hid.c | 2 +- > drivers/hid/hid-hyperv.c | 2 +- > drivers/hid/hid-logitech-dj.c | 4 ++-- > drivers/hid/hid-steam.c | 2 +- > drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- > drivers/hid/surface-hid/surface_hid_core.c | 2 +- > drivers/platform/x86/asus-tf103c-dock.c | 4 ++-- > drivers/staging/greybus/hid.c | 2 +- > 8 files changed, 10 insertions(+), 10 deletions(-) > --- > base-commit: e04955db6a7c3fc4a1e6978649b61a6f5f8028e3 > change-id: 20230130-hid-const-ll-driver-fcfdd3af11b8 > > Best regards,
Hi Hans, On Mon, Jan 30, 2023 at 09:36:32AM +0100, Hans de Goede wrote: > Hi, > > On 1/30/23 04:59, Thomas Weißschuh wrote: > > Since 52d225346904 ("HID: Make lowlevel driver structs const") the > > lowlevel HID drivers are only exposed as const. > > > > Take advantage of this to constify the underlying structures, too. > > > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > > Thanks, series looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > I'll also pick up / merge patches 7 + 8 into pdx86/for-next > sometime this week. Please note that patch 7 depends on commit 52d225346904 ("HID: Make lowlevel driver structs const") which is not yet in Linus' tree, only in the HID tree (branch for-6.3/hid-core). Maybe it's better to take it via the HID tree or I can resend when the prerequisites are in Linus' tree. > Regards, > > Hans > > > > > --- > > Thomas Weißschuh (9): > > HID: amd_sfh: Constify lowlevel HID driver > > HID: hyperv: Constify lowlevel HID driver > > HID: logitech-dj: Constify lowlevel HID driver > > HID: steam: Constify lowlevel HID driver > > HID: intel-ish-hid: Constify lowlevel HID driver > > HID: surface-hid: Constify lowlevel HID driver > > platform/x86: asus-tf103c-dock: Constify lowlevel HID driver > > platform/x86: asus-tf103c-dock: Constify toprow keymap > > staging: greybus: hid: Constify lowlevel HID driver > > > > drivers/hid/amd-sfh-hid/amd_sfh_hid.c | 2 +- > > drivers/hid/hid-hyperv.c | 2 +- > > drivers/hid/hid-logitech-dj.c | 4 ++-- > > drivers/hid/hid-steam.c | 2 +- > > drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- > > drivers/hid/surface-hid/surface_hid_core.c | 2 +- > > drivers/platform/x86/asus-tf103c-dock.c | 4 ++-- > > drivers/staging/greybus/hid.c | 2 +- > > 8 files changed, 10 insertions(+), 10 deletions(-) > > --- > > base-commit: e04955db6a7c3fc4a1e6978649b61a6f5f8028e3 > > change-id: 20230130-hid-const-ll-driver-fcfdd3af11b8 > > > > Best regards, >
Hi, On 1/30/23 14:26, Thomas Weißschuh wrote: > Hi Hans, > > On Mon, Jan 30, 2023 at 09:36:32AM +0100, Hans de Goede wrote: >> Hi, >> >> On 1/30/23 04:59, Thomas Weißschuh wrote: >>> Since 52d225346904 ("HID: Make lowlevel driver structs const") the >>> lowlevel HID drivers are only exposed as const. >>> >>> Take advantage of this to constify the underlying structures, too. >>> >>> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> >> >> Thanks, series looks good to me: >> >> Reviewed-by: Hans de Goede <hdegoede@redhat.com> >> >> I'll also pick up / merge patches 7 + 8 into pdx86/for-next >> sometime this week. > > Please note that patch 7 depends on commit 52d225346904 > ("HID: Make lowlevel driver structs const") which is not yet in Linus' > tree, only in the HID tree (branch for-6.3/hid-core). > > Maybe it's better to take it via the HID tree or I can resend when the > prerequisites are in Linus' tree. Ah yes then it would be better to take the entire set through the HID tree, here is my ack for that: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans >>> --- >>> Thomas Weißschuh (9): >>> HID: amd_sfh: Constify lowlevel HID driver >>> HID: hyperv: Constify lowlevel HID driver >>> HID: logitech-dj: Constify lowlevel HID driver >>> HID: steam: Constify lowlevel HID driver >>> HID: intel-ish-hid: Constify lowlevel HID driver >>> HID: surface-hid: Constify lowlevel HID driver >>> platform/x86: asus-tf103c-dock: Constify lowlevel HID driver >>> platform/x86: asus-tf103c-dock: Constify toprow keymap >>> staging: greybus: hid: Constify lowlevel HID driver >>> >>> drivers/hid/amd-sfh-hid/amd_sfh_hid.c | 2 +- >>> drivers/hid/hid-hyperv.c | 2 +- >>> drivers/hid/hid-logitech-dj.c | 4 ++-- >>> drivers/hid/hid-steam.c | 2 +- >>> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- >>> drivers/hid/surface-hid/surface_hid_core.c | 2 +- >>> drivers/platform/x86/asus-tf103c-dock.c | 4 ++-- >>> drivers/staging/greybus/hid.c | 2 +- >>> 8 files changed, 10 insertions(+), 10 deletions(-) >>> --- >>> base-commit: e04955db6a7c3fc4a1e6978649b61a6f5f8028e3 >>> change-id: 20230130-hid-const-ll-driver-fcfdd3af11b8 >>> >>> Best regards, >> >
On Mon, 30 Jan 2023 03:59:36 +0000, Thomas Weißschuh wrote: > Since 52d225346904 ("HID: Make lowlevel driver structs const") the > lowlevel HID drivers are only exposed as const. > > Take advantage of this to constify the underlying structures, too. > > Applied to hid/hid.git (for-6.3/hid-core), thanks! [1/9] HID: amd_sfh: Constify lowlevel HID driver https://git.kernel.org/hid/hid/c/65b7015bfe16 [2/9] HID: hyperv: Constify lowlevel HID driver https://git.kernel.org/hid/hid/c/d38213a911c5 [3/9] HID: logitech-dj: Constify lowlevel HID driver https://git.kernel.org/hid/hid/c/662eee8d46df [4/9] HID: steam: Constify lowlevel HID driver https://git.kernel.org/hid/hid/c/ddb6792f0ef2 [5/9] HID: intel-ish-hid: Constify lowlevel HID driver https://git.kernel.org/hid/hid/c/3352c3e0bf9b [6/9] HID: surface-hid: Constify lowlevel HID driver https://git.kernel.org/hid/hid/c/dd350afc1757 [7/9] platform/x86: asus-tf103c-dock: Constify lowlevel HID driver https://git.kernel.org/hid/hid/c/63509b149f1b [8/9] platform/x86: asus-tf103c-dock: Constify toprow keymap https://git.kernel.org/hid/hid/c/783c3394b493 [9/9] staging: greybus: hid: Constify lowlevel HID driver https://git.kernel.org/hid/hid/c/ff17bb876014 Cheers,