Message ID | 20230126074356.431306-1-francesco@dolcini.it |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp149895wrn; Wed, 25 Jan 2023 23:45:27 -0800 (PST) X-Google-Smtp-Source: AK7set/amHfGPFcD+pGENUEyxDMwOLY0czS1i5QOIdqhtQUu8fL6TGcLyILXhr+FRFO/9FQJj+se X-Received: by 2002:a17:90b:3e83:b0:22b:f9c2:d1a0 with SMTP id rj3-20020a17090b3e8300b0022bf9c2d1a0mr1357012pjb.6.1674719127471; Wed, 25 Jan 2023 23:45:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674719127; cv=none; d=google.com; s=arc-20160816; b=pv/LqzuqQ0TxKBbXOZGL1+/RymJqUJuT3V6mkOWIC1vxIv0O6tzJIo4SVL3rxnmVZu qmCyXHXvEcUhY4ZDzThdtaX2pYcBVI/Kcr9T/eJklNzrnaFBtfH8FaQ5yIF3QdMw1oeT xy6jt0ImVF3q9sjozw3Q7iL14uB+C165RETCFfMVXQGxrBXgp2hv4jbsplwSrMMTpfaj xCD1gzRxseNDzQGgmPizfl4kVnMbigGHPrpL7dKaG2WI/FhUVp4Q0/SD6L43iUgQm88u lD8oaDmeZJdx6Ie7BO4iJut2JTUGsaNb+odEyBoAdiVCYpAUFNMoMcgPoJ+8FRBOSxgN vZ0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cdYi4yZkkETzYULHKll0GvfQ+Q+J+E3EG1q+AQq6leg=; b=TF1tpxuSpNuo5eJ2lVZEx0MwwfDVFsPpf7RRvpyHcApBQ2b4VdnlQUR5uNc11tVMV+ IPpttZEpeZAEoj8NjNemt39UtR3laqgr4vatZXCKhb4C3GmvvZP8JdDJGkdrZ7BZejzR 0ggZ5cGmvB5h+XOHzcLc0WKnwl8e26lWB+VVwj42KoNM25b/TwviH0ZrzpOsiQ73WvUJ 3lxAlt9WJ9a8pu0fg8rLi6cLpIXe2grd8fB/fMM4jX4+2TrCL1fwNuD5i9Btkk5YR7P7 h7yi1n1yfimPacR9TxxFD3FSyR7ox2z+8FG4sKF0HYQ1KeH11gzrauMlhQchjY2exd6F ldbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailserver.it header.s=mailsrv header.b=bJrxRTYw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w13-20020a17090aea0d00b0022670f5de3dsi4614208pjy.0.2023.01.25.23.45.15; Wed, 25 Jan 2023 23:45:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailserver.it header.s=mailsrv header.b=bJrxRTYw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233130AbjAZHok (ORCPT <rfc822;lekhanya01809@gmail.com> + 99 others); Thu, 26 Jan 2023 02:44:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbjAZHoj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 26 Jan 2023 02:44:39 -0500 Received: from smtp-out-06.comm2000.it (smtp-out-06.comm2000.it [212.97.32.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11C1F1BAF6; Wed, 25 Jan 2023 23:44:36 -0800 (PST) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: francesco@dolcini.it) by smtp-out-06.comm2000.it (Postfix) with ESMTPSA id 0B1D85611D4; Thu, 26 Jan 2023 08:44:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailserver.it; s=mailsrv; t=1674719072; bh=3G/SbvmzPiZfuAmwVmCOJNiD9b1gSTVCAfILv/DUq/Y=; h=From:To:Cc:Subject:Date; b=bJrxRTYwMAnf3nRk/ayrKGhxD4Hi4mfUPVGG6LkhC43P7HzfszYSEqNX+/OlyPGAM 5uQtQsqiauEmeOoXyg3/fwtMuG/G6HsKZ5HXVkHY/4FionmiTJVjgCtZ9fJB0+RcRX WeTu48ANFMU6y/MAtAMUFx4Wuek8MTmWl3D7D744yHMqcxJIn6SyTwzDk+kMTYJHX9 rriQfFH+uXAt9GDCv/gRIYxNwVh88d7CUL7tESPqUuF2ptc8H/q053DnlqeXvQqAic YhI7JBUcytJclhzXksDv1NO7AOuS7hQibAxrPyHtDkvZOZFntQe44KPTNWBaEat7/3 x7IVRz8jrQq0w== From: Francesco Dolcini <francesco@dolcini.it> To: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>, Luiz Augusto von Dentz <luiz.dentz@gmail.com>, linux-arm-kernel@lists.infradead.org Cc: Francesco Dolcini <francesco.dolcini@toradex.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Johan Hedberg <johan.hedberg@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com> Subject: [PATCH v2 0/5] Bluetooth: hci_mrvl: Add serdev support for 88W8997 Date: Thu, 26 Jan 2023 08:43:51 +0100 Message-Id: <20230126074356.431306-1-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756070283362329608?= X-GMAIL-MSGID: =?utf-8?q?1756070283362329608?= |
Series |
Bluetooth: hci_mrvl: Add serdev support for 88W8997
|
|
Message
Francesco Dolcini
Jan. 26, 2023, 7:43 a.m. UTC
From: Francesco Dolcini <francesco.dolcini@toradex.com>
Add serdev support for the 88W8997 from NXP (previously Marvell). It includes
support for changing the baud rate. The command to change the baud rate is
taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth
interfaces) from NXP.
v2:
- Fix the subject as pointed out by Krzysztof. Thanks!
- Fix indentation in marvell-bluetooth.yaml
- Fix compiler warning for kernel builds without CONFIG_OF enabled
Stefan Eichenberger (5):
dt-bindings: bluetooth: marvell: add 88W8997
dt-bindings: bluetooth: marvell: add max-speed property
Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids
Bluetooth: hci_mrvl: Add serdev support for 88W8997
arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4
.../bindings/net/marvell-bluetooth.yaml | 20 +++-
.../dts/freescale/imx8mp-verdin-wifi.dtsi | 5 +
drivers/bluetooth/hci_mrvl.c | 92 +++++++++++++++++--
3 files changed, 106 insertions(+), 11 deletions(-)
Comments
Hello all, On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > support for changing the baud rate. The command to change the baud rate is > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > interfaces) from NXP. Just a gently ping on this series, patches 1,2 with DT binding changes are reviewed/acked, patch 5 with the DTS change should just be on hold till patches 1-4 are merged. No feedback on patches 4 (and 3), with the BT serdev driver code changes, any plan on those? Thanks a lot! Francesco
Hi Francesco, On Fri, Feb 10, 2023 at 12:40 AM Francesco Dolcini <francesco@dolcini.it> wrote: > > Hello all, > > On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote: > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > > support for changing the baud rate. The command to change the baud rate is > > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > > interfaces) from NXP. > > Just a gently ping on this series, patches 1,2 with DT binding changes > are reviewed/acked, patch 5 with the DTS change should just be on hold > till patches 1-4 are merged. > > No feedback on patches 4 (and 3), with the BT serdev driver code > changes, any plan on those? bots have detected errors on these changes > Thanks a lot! > Francesco >
On Fri, Feb 10, 2023 at 10:52:43AM -0800, Luiz Augusto von Dentz wrote: > Hi Francesco, > > On Fri, Feb 10, 2023 at 12:40 AM Francesco Dolcini <francesco@dolcini.it> wrote: > > > > Hello all, > > > > On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote: > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > > > support for changing the baud rate. The command to change the baud rate is > > > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > > > interfaces) from NXP. > > > > Just a gently ping on this series, patches 1,2 with DT binding changes > > are reviewed/acked, patch 5 with the DTS change should just be on hold > > till patches 1-4 are merged. > > > > No feedback on patches 4 (and 3), with the BT serdev driver code > > changes, any plan on those? > > bots have detected errors on these changes From what I can understand from this point of view v2 is fine, the error was in v1, if I'm wrong just let me know. Said that I'll do the change you asked regarding __hci_cmd_sync_status and send a v3. Thanks, Francesco
Hi Francesco, On Fri, Feb 10, 2023 at 11:04 AM Francesco Dolcini <francesco@dolcini.it> wrote: > > On Fri, Feb 10, 2023 at 10:52:43AM -0800, Luiz Augusto von Dentz wrote: > > Hi Francesco, > > > > On Fri, Feb 10, 2023 at 12:40 AM Francesco Dolcini <francesco@dolcini.it> wrote: > > > > > > Hello all, > > > > > > On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote: > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > > > > support for changing the baud rate. The command to change the baud rate is > > > > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > > > > interfaces) from NXP. > > > > > > Just a gently ping on this series, patches 1,2 with DT binding changes > > > are reviewed/acked, patch 5 with the DTS change should just be on hold > > > till patches 1-4 are merged. > > > > > > No feedback on patches 4 (and 3), with the BT serdev driver code > > > changes, any plan on those? > > > > bots have detected errors on these changes > > From what I can understand from this point of view v2 is fine, the error > was in v1, if I'm wrong just let me know. > > Said that I'll do the change you asked regarding __hci_cmd_sync_status > and send a v3. Great, for some reason your set is not being tested by our CI though, @Tedd Ho-Jeong An do you know why? > Thanks, > Francesco >
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 26 Jan 2023 08:43:51 +0100 you wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > support for changing the baud rate. The command to change the baud rate is > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > interfaces) from NXP. > > [...] Here is the summary with links: - [v2,1/5] dt-bindings: bluetooth: marvell: add 88W8997 https://git.kernel.org/bluetooth/bluetooth-next/c/f48823aa0c4f - [v2,2/5] dt-bindings: bluetooth: marvell: add max-speed property https://git.kernel.org/bluetooth/bluetooth-next/c/d7303dce9fcb - [v2,3/5] Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids https://git.kernel.org/bluetooth/bluetooth-next/c/e275614465ec - [v2,4/5] Bluetooth: hci_mrvl: Add serdev support for 88W8997 (no matching commit) - [v2,5/5] arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4 (no matching commit) You are awesome, thank you!