mbox series

[bpf-next,v4,0/4] Enable struct_ops programs to be sleepable

Message ID 20230125164735.785732-1-void@manifault.com
Headers
Series Enable struct_ops programs to be sleepable |

Message

David Vernet Jan. 25, 2023, 4:47 p.m. UTC 
  This is part 4 of https://lore.kernel.org/bpf/20230123232228.646563-1-void@manifault.com/

Part 3: https://lore.kernel.org/all/20230125050359.339273-1-void@manifault.com/
Part 2: https://lore.kernel.org/all/20230124160802.1122124-1-void@manifault.com/

Changelog:
----------
v3 -> v4:
- Fix accidental typo in name of dummy_st_ops introduced in v2, moving
  it back to dummy_st_ops from dummy_st_ops_success. Should fix s390x
  testruns.

v2 -> v3:
- Don't call a KF_SLEEPABLE kfunc from the dummy_st_ops testsuite, and
  remove the newly added bpf_kfunc_call_test_sleepable() test kfunc
  (Martin).
- Include vmlinux.h from progs/dummy_st_ops_success.c (previously
  progs/dummy_st_ops.c) rather than manually defining
  struct bpf_dummy_ops_state and struct bpf_dummy_ops.
  (Martin).
- Fix a typo added to prog_tests/dummy_st_ops.c in a previous version:
  s/trace_dummy_st_ops_success__open/trace_dummy_st_ops__open.

v1 -> v2:
- Add support for specifying sleepable struct_ops programs with
  struct_ops.s in libbpf (Alexei).
- Move failure test case into new dummy_st_ops_fail.c prog file.
- Update test_dummy_sleepable() to use struct_ops.s instead of manually
  setting prog flags. Also remove open_load_skel() helper which is no
  longer needed.
- Fix verifier tests to expect new sleepable prog failure message.


David Vernet (4):
  bpf: Allow BPF_PROG_TYPE_STRUCT_OPS programs to be sleepable
  libbpf: Support sleepable struct_ops.s section
  bpf: Pass const struct bpf_prog * to .check_member
  bpf/selftests: Verify struct_ops prog sleepable behavior

 include/linux/bpf.h                           |  4 +-
 kernel/bpf/verifier.c                         |  7 +--
 net/bpf/bpf_dummy_struct_ops.c                | 18 +++++++
 net/ipv4/bpf_tcp_ca.c                         |  3 +-
 tools/lib/bpf/libbpf.c                        |  1 +
 .../selftests/bpf/prog_tests/dummy_st_ops.c   | 52 ++++++++++++++-----
 .../selftests/bpf/progs/dummy_st_ops_fail.c   | 27 ++++++++++
 ...{dummy_st_ops.c => dummy_st_ops_success.c} | 19 +++----
 .../selftests/bpf/verifier/sleepable.c        |  2 +-
 9 files changed, 103 insertions(+), 30 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/dummy_st_ops_fail.c
 rename tools/testing/selftests/bpf/progs/{dummy_st_ops.c => dummy_st_ops_success.c} (72%)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 25, 2023, 6:30 p.m. UTC | #1 
Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 25 Jan 2023 10:47:31 -0600 you wrote:
> This is part 4 of https://lore.kernel.org/bpf/20230123232228.646563-1-void@manifault.com/
> 
> Part 3: https://lore.kernel.org/all/20230125050359.339273-1-void@manifault.com/
> Part 2: https://lore.kernel.org/all/20230124160802.1122124-1-void@manifault.com/
> 
> Changelog:
> 
> [...]

Here is the summary with links:
  - [bpf-next,v4,1/4] bpf: Allow BPF_PROG_TYPE_STRUCT_OPS programs to be sleepable
    https://git.kernel.org/bpf/bpf-next/c/1e12d3ef47d2
  - [bpf-next,v4,2/4] libbpf: Support sleepable struct_ops.s section
    https://git.kernel.org/bpf/bpf-next/c/913b2255c3d8
  - [bpf-next,v4,3/4] bpf: Pass const struct bpf_prog * to .check_member
    https://git.kernel.org/bpf/bpf-next/c/51a52a29ebaa
  - [bpf-next,v4,4/4] bpf/selftests: Verify struct_ops prog sleepable behavior
    https://git.kernel.org/bpf/bpf-next/c/7dd880592a88

You are awesome, thank you!