From patchwork Wed Jan 25 08:23:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Ghiti X-Patchwork-Id: 4499 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp161769wrn; Wed, 25 Jan 2023 00:27:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXvpKggZ8/6Bt/Jq63Ph0hzdGjDSp5hi6nNdG/pKrBdGoalv7B20/gCyjorNA7MdSqZSuboS X-Received: by 2002:aa7:85d5:0:b0:582:6732:ee0b with SMTP id z21-20020aa785d5000000b005826732ee0bmr52230577pfn.28.1674635224505; Wed, 25 Jan 2023 00:27:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674635224; cv=none; d=google.com; s=arc-20160816; b=R6IIP0Q4ZTAmVHwEJjd68jDK+9Crxzx9mu6XoFXuP7Kw3aEq/crXCN/dHLwzE36nRC d9uxMT57iiTOuEtcxLPkXxRrKb3ZyeHDBGHPGnknq7Q6fr+jc5T/Qp4XV/8dFyXHO3AJ 30KyBGonvN0MXrQC4aJ+D0bnFX3GRblg1hTp5wA6Pyi2R3TzjGsoGDD0rDAbsXQrim9t yP8LocHI7zDGox7Btzs/lCt3kObYMXRcjYKLF0e9FVhOrdXTn4EF2wWIQd1DT/zvxH+e juJLKiVWZYh+53BHfEGDOBJV6SkzWvronBkcFz5X+3zbGmQ6ZfdDBUqpnUoLtYXt2Ojc 4Uhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5YDvDkWAbLDWKsnQUnWtcsgg0pzlyYSw3Ro2XkM1b1U=; b=TSoge3utQvuHeyexPrtq2f6CThFKjvmogM6/t6lxXlGwtszovhCscDq43+AkwVeteb jiAAMDczH05I0GxfOv+ClLOHnt1F7qoViA+ZWzK+8togfjdiodtiPTg4HEI8HI5xra5U zWX2dthUrqmXAU3vS+hSJ8Xj6O2qMm1TK/miPgMmg11yZz9d9drFyrRkg8J6asIWDaUj CUU09q1/zATaHiMu0sOJDOAGzqerHeqwGGLFHTf4Mf2nPE9LtU+YP/Nnt0csQ7FSy5b/ mQuLwhaXJf/CjUP4aE/03HWUHfWY/jxQ5PklG0Ht+5W32uzcltBkZNp7w4a9ce5gJrXX 2r9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=kcqF6iq5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p127-20020a622985000000b0059063092b51si573657pfp.380.2023.01.25.00.26.52; Wed, 25 Jan 2023 00:27:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=kcqF6iq5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234431AbjAYIXr (ORCPT + 99 others); Wed, 25 Jan 2023 03:23:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233880AbjAYIXq (ORCPT ); Wed, 25 Jan 2023 03:23:46 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A920E366A3 for ; Wed, 25 Jan 2023 00:23:44 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id bk16so16196322wrb.11 for ; Wed, 25 Jan 2023 00:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5YDvDkWAbLDWKsnQUnWtcsgg0pzlyYSw3Ro2XkM1b1U=; b=kcqF6iq5mRuvn+vLGKITzcs41XGVfxnke94ZRKDv6r/GXQtJq/DjhtH1Bka1ZuWmOz hs+sqQ3WOiAIzxmt/9Zuy/4eSmxyAq/uDcMuDh+FJbpdipz28DjE2DIVkgbNi25nI5zK jZGqHtN15KR7z7UdxlfjkoHN0aNKg85LhpwylDBIfJNneOTjMUQ1oWWjUE6Vj1+92pDr DRAh5QfaLNT5gzj81fbZsHRopjbSDX3pwjXbQqwgN0tn+3A3A42nZDMT6rcPdvCmhryC zOFWEjBbK4SyukL/JoRIo5lmLYlAkvj+bWXz40K7tGlP0Gc3CfH5evRrgYHF5D/SHgDa TiBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5YDvDkWAbLDWKsnQUnWtcsgg0pzlyYSw3Ro2XkM1b1U=; b=w4JGT4u0e2mlIPqGvQTyM0/Iw8KoNcrt7aJG7DQ+cIcCQEtxTdd/lMZ6zdKR0D/pyN QciyIYI8WLt4U63zs1FeUeOvc2NZFkhrx3vkkhsb4/ELHlsArai0bv4OAbRdNQKWPLzx 30SYgdbScW4709xbX0mSBL8BHqbw3EnWAaBMQEzmlqqV8ykFXt2ouacyRJZl2of36CC0 SAxtCUbYLii0VI/pyFrH6LuBpO0AOQG2bzKJCiob8CqNsrKbQPbr7OBIPKCoDa3IuUx9 HhB79Rff/8w5A48bsAqujN4gdR1hEyXCYNdrXxyrbRzT2Ap7hbzBcL8kUaJZftRJshlL aPRA== X-Gm-Message-State: AO0yUKX3C55XZMmVAuX3z+DkyCrCwCNlgHWSkwI+PFl1A/KXiYrVkBzR dAzavaQiIcQwaStJtNvUYxOY1A== X-Received: by 2002:a5d:42cd:0:b0:2bf:81eb:dc26 with SMTP id t13-20020a5d42cd000000b002bf81ebdc26mr7593494wrr.37.1674635023170; Wed, 25 Jan 2023 00:23:43 -0800 (PST) Received: from alex-rivos.home (lfbn-lyo-1-450-160.w2-7.abo.wanadoo.fr. [2.7.42.160]) by smtp.gmail.com with ESMTPSA id a18-20020a056000101200b002be25db0b7bsm3821071wrx.10.2023.01.25.00.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 00:23:42 -0800 (PST) From: Alexandre Ghiti To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Ard Biesheuvel , Conor Dooley , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-efi@vger.kernel.org Cc: Alexandre Ghiti Subject: [PATCH v3 0/6] RISC-V kasan rework Date: Wed, 25 Jan 2023 09:23:27 +0100 Message-Id: <20230125082333.1577572-1-alexghiti@rivosinc.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755982305068686247?= X-GMAIL-MSGID: =?utf-8?q?1755982305068686247?= As described in patch 2, our current kasan implementation is intricate, so I tried to simplify the implementation and mimic what arm64/x86 are doing. In addition it fixes UEFI bootflow with a kasan kernel and kasan inline instrumentation: all kasan configurations were tested on a large ubuntu kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST. inline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK outline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK Actually 1 test always fails with KASAN_KUNIT_TEST that I have to check: # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan__test.c:1020 KASAN failure expected in "set_bit(nr, addr)", but none occurrred Note that Palmer recently proposed to remove COMMAND_LINE_SIZE from the userspace abi https://lore.kernel.org/lkml/20221211061358.28035-1-palmer@rivosinc.com/T/ so that we can finally increase the command line to fit all kasan kernel parameters. All of this should hopefully fix the syzkaller riscv build that has been failing for a few months now, any test is appreciated and if I can help in any way, please ask. v3: - Add AB from Ard in patch 4, thanks - Fix checkpatch issues in patch 1, thanks Conor v2: - Rebase on top of v6.2-rc3 - patch 4 is now way simpler than it used to be since Ard already moved the string functions into the efistub. Alexandre Ghiti (6): riscv: Split early and final KASAN population functions riscv: Rework kasan population functions riscv: Move DTB_EARLY_BASE_VA to the kernel address space riscv: Fix EFI stub usage of KASAN instrumented strcmp function riscv: Fix ptdump when KASAN is enabled riscv: Unconditionnally select KASAN_VMALLOC if KASAN arch/riscv/Kconfig | 1 + arch/riscv/kernel/image-vars.h | 2 - arch/riscv/mm/init.c | 2 +- arch/riscv/mm/kasan_init.c | 516 ++++++++++++++++++--------------- arch/riscv/mm/ptdump.c | 24 +- 5 files changed, 298 insertions(+), 247 deletions(-)