mbox series

[00/23] staging: r8188eu: some more xmit cleanups

Message ID 20230123205342.229589-1-martin@kaiser.cx
Headers
Series staging: r8188eu: some more xmit cleanups |

Message

Martin Kaiser Jan. 23, 2023, 8:53 p.m. UTC 
  Here's another series with cleanups of the xmit part. Amongst other
things, it replaces some __queue variables with standard list_heads.

This series also includes rebased versions of the patches that caused
conflicts during the last review cycle.

Martin Kaiser (23):
  staging: r8188eu: we use a constant number of hw_xmit entries
  staging: r8188eu: pass struct adapter to usb_write
  staging: r8188eu: remove struct intf_hdl
  staging: r8188eu: remove struct intf_priv
  staging: r8188eu: simplify the sta loop in rtw_dequeue_xframe
  staging: r8188eu: simplify the code to initialise inx
  staging: r8188eu: remove an obsolete comment
  staging: r8188eu: remove unused function parameter
  staging: r8188eu: remove dead assignment
  staging: r8188eu: use list_empty
  staging: r8188eu: simplify dequeue_one_xmitframe
  staging: r8188eu: remove redundant parameter
  staging: r8188eu: make rtw_chk_hi_queue_cmd a void function
  staging: r8188eu: decrement qcnt in rtw_dequeue_xframe
  staging: r8188eu: simplify dequeue_one_xmitframe
  staging: r8188eu: use list_head for xmitframe list
  staging: r8188eu: merge dequeue_one_xmitframe into its caller
  staging: r8188eu: use lists for hwxmits
  staging: r8188eu: fix rtw_xmitframe_enqueue error handling
  staging: r8188eu: remove rtw_xmitframe_enqueue
  staging: r8188eu: struct agg_pkt_info is unused
  staging: r8188eu: apsd_setting is unused
  staging: r8188eu: merge rtw_free_hwxmits into its only caller

 drivers/staging/r8188eu/core/rtw_cmd.c        |  16 +--
 drivers/staging/r8188eu/core/rtw_xmit.c       | 119 +++++-------------
 drivers/staging/r8188eu/hal/rtl8188eu_xmit.c  |   7 +-
 drivers/staging/r8188eu/hal/usb_ops_linux.c   |  18 +--
 drivers/staging/r8188eu/include/drv_types.h   |   1 -
 drivers/staging/r8188eu/include/osdep_intf.h  |  32 -----
 .../staging/r8188eu/include/rtl8188e_xmit.h   |   3 +-
 drivers/staging/r8188eu/include/rtw_cmd.h     |   2 +-
 drivers/staging/r8188eu/include/rtw_io.h      |   8 --
 drivers/staging/r8188eu/include/rtw_xmit.h    |  23 +---
 drivers/staging/r8188eu/os_dep/usb_intf.c     |   6 -
 11 files changed, 57 insertions(+), 178 deletions(-)

Comments

Philipp Hortmann Jan. 24, 2023, 7:01 p.m. UTC | #1 
On 1/23/23 21:53, Martin Kaiser wrote:
> Here's another series with cleanups of the xmit part. Amongst other
> things, it replaces some __queue variables with standard list_heads.
> 
> This series also includes rebased versions of the patches that caused
> conflicts during the last review cycle.
> 
> Martin Kaiser (23):
>    staging: r8188eu: we use a constant number of hw_xmit entries
>    staging: r8188eu: pass struct adapter to usb_write
>    staging: r8188eu: remove struct intf_hdl
>    staging: r8188eu: remove struct intf_priv
>    staging: r8188eu: simplify the sta loop in rtw_dequeue_xframe
>    staging: r8188eu: simplify the code to initialise inx
>    staging: r8188eu: remove an obsolete comment
>    staging: r8188eu: remove unused function parameter
>    staging: r8188eu: remove dead assignment
>    staging: r8188eu: use list_empty
>    staging: r8188eu: simplify dequeue_one_xmitframe
>    staging: r8188eu: remove redundant parameter
>    staging: r8188eu: make rtw_chk_hi_queue_cmd a void function
>    staging: r8188eu: decrement qcnt in rtw_dequeue_xframe
>    staging: r8188eu: simplify dequeue_one_xmitframe
>    staging: r8188eu: use list_head for xmitframe list
>    staging: r8188eu: merge dequeue_one_xmitframe into its caller
>    staging: r8188eu: use lists for hwxmits
>    staging: r8188eu: fix rtw_xmitframe_enqueue error handling
>    staging: r8188eu: remove rtw_xmitframe_enqueue
>    staging: r8188eu: struct agg_pkt_info is unused
>    staging: r8188eu: apsd_setting is unused
>    staging: r8188eu: merge rtw_free_hwxmits into its only caller
> 
>   drivers/staging/r8188eu/core/rtw_cmd.c        |  16 +--
>   drivers/staging/r8188eu/core/rtw_xmit.c       | 119 +++++-------------
>   drivers/staging/r8188eu/hal/rtl8188eu_xmit.c  |   7 +-
>   drivers/staging/r8188eu/hal/usb_ops_linux.c   |  18 +--
>   drivers/staging/r8188eu/include/drv_types.h   |   1 -
>   drivers/staging/r8188eu/include/osdep_intf.h  |  32 -----
>   .../staging/r8188eu/include/rtl8188e_xmit.h   |   3 +-
>   drivers/staging/r8188eu/include/rtw_cmd.h     |   2 +-
>   drivers/staging/r8188eu/include/rtw_io.h      |   8 --
>   drivers/staging/r8188eu/include/rtw_xmit.h    |  23 +---
>   drivers/staging/r8188eu/os_dep/usb_intf.c     |   6 -
>   11 files changed, 57 insertions(+), 178 deletions(-)
> 


Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150