[v2,0/3] Misc thermal cleanup and fixes

  This series is based on linux-pm/thermal

It unregisters the netlink generic family for thermal in case the thermal
framework fails to initialize, removes a unneeded ida_destroy() call and moves
the thermal trip code in a separate file.

A couple of changes have been removed from the previous version:

 - Ordering the trip points. Some consolidation is needed in the set_trip_temp
   ops before ordering the trip points, so this change is postpone

 - Remove the mutex destroy call. Even if the call is not needed, the
   justification of the change is not accurate. So it is postponed also.

 V2:
   - Removed ordering the trip points change
   - Removed mutex destroy change
   - Added "No functional change intented" as requested by Rui
   - Added the function declaration for_each_thermal_trip

Daniel Lezcano (3):
  thermal/core: Fix unregistering netlink at thermal init time
  thermal/core: Remove unneeded ida_destroy()
  thermal/core: Move the thermal trip code to a dedicated file

 drivers/thermal/Makefile          |   4 +-
 drivers/thermal/thermal_core.c    |  93 +--------------
 drivers/thermal/thermal_core.h    |   4 +
 drivers/thermal/thermal_helpers.c |  62 ----------
 drivers/thermal/thermal_netlink.c |   5 +
 drivers/thermal/thermal_netlink.h |   3 +
 drivers/thermal/thermal_trip.c    | 182 ++++++++++++++++++++++++++++++
 7 files changed, 199 insertions(+), 154 deletions(-)
 create mode 100644 drivers/thermal/thermal_trip.c
  

Hi Rafael,

will you take this series on your branch ?


On 23/01/2023 16:27, Daniel Lezcano wrote:
> This series is based on linux-pm/thermal
> 
> It unregisters the netlink generic family for thermal in case the thermal
> framework fails to initialize, removes a unneeded ida_destroy() call and moves
> the thermal trip code in a separate file.
> 
> A couple of changes have been removed from the previous version:
> 
>   - Ordering the trip points. Some consolidation is needed in the set_trip_temp
>     ops before ordering the trip points, so this change is postpone
> 
>   - Remove the mutex destroy call. Even if the call is not needed, the
>     justification of the change is not accurate. So it is postponed also.
> 
>   V2:
>     - Removed ordering the trip points change
>     - Removed mutex destroy change
>     - Added "No functional change intented" as requested by Rui
>     - Added the function declaration for_each_thermal_trip
> 
> Daniel Lezcano (3):
>    thermal/core: Fix unregistering netlink at thermal init time
>    thermal/core: Remove unneeded ida_destroy()
>    thermal/core: Move the thermal trip code to a dedicated file
> 
>   drivers/thermal/Makefile          |   4 +-
>   drivers/thermal/thermal_core.c    |  93 +--------------
>   drivers/thermal/thermal_core.h    |   4 +
>   drivers/thermal/thermal_helpers.c |  62 ----------
>   drivers/thermal/thermal_netlink.c |   5 +
>   drivers/thermal/thermal_netlink.h |   3 +
>   drivers/thermal/thermal_trip.c    | 182 ++++++++++++++++++++++++++++++
>   7 files changed, 199 insertions(+), 154 deletions(-)
>   create mode 100644 drivers/thermal/thermal_trip.c
>
  

On Wed, Jan 25, 2023 at 12:16 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
>
> Hi Rafael,
>
> will you take this series on your branch ?

Yes, I'm planning to do that, if I don't find any issues with it (not
likely though).

> On 23/01/2023 16:27, Daniel Lezcano wrote:
> > This series is based on linux-pm/thermal
> >
> > It unregisters the netlink generic family for thermal in case the thermal
> > framework fails to initialize, removes a unneeded ida_destroy() call and moves
> > the thermal trip code in a separate file.
> >
> > A couple of changes have been removed from the previous version:
> >
> >   - Ordering the trip points. Some consolidation is needed in the set_trip_temp
> >     ops before ordering the trip points, so this change is postpone
> >
> >   - Remove the mutex destroy call. Even if the call is not needed, the
> >     justification of the change is not accurate. So it is postponed also.
> >
> >   V2:
> >     - Removed ordering the trip points change
> >     - Removed mutex destroy change
> >     - Added "No functional change intented" as requested by Rui
> >     - Added the function declaration for_each_thermal_trip
> >
> > Daniel Lezcano (3):
> >    thermal/core: Fix unregistering netlink at thermal init time
> >    thermal/core: Remove unneeded ida_destroy()
> >    thermal/core: Move the thermal trip code to a dedicated file
> >
> >   drivers/thermal/Makefile          |   4 +-
> >   drivers/thermal/thermal_core.c    |  93 +--------------
> >   drivers/thermal/thermal_core.h    |   4 +
> >   drivers/thermal/thermal_helpers.c |  62 ----------
> >   drivers/thermal/thermal_netlink.c |   5 +
> >   drivers/thermal/thermal_netlink.h |   3 +
> >   drivers/thermal/thermal_trip.c    | 182 ++++++++++++++++++++++++++++++
> >   7 files changed, 199 insertions(+), 154 deletions(-)
> >   create mode 100644 drivers/thermal/thermal_trip.c
> >
>
> --
  

On Wed, Jan 25, 2023 at 3:03 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, Jan 25, 2023 at 12:16 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
> >
> >
> > Hi Rafael,
> >
> > will you take this series on your branch ?
>
> Yes, I'm planning to do that, if I don't find any issues with it (not
> likely though).

I've just queued it up for 6.3.

> > On 23/01/2023 16:27, Daniel Lezcano wrote:
> > > This series is based on linux-pm/thermal
> > >
> > > It unregisters the netlink generic family for thermal in case the thermal
> > > framework fails to initialize, removes a unneeded ida_destroy() call and moves
> > > the thermal trip code in a separate file.
> > >
> > > A couple of changes have been removed from the previous version:
> > >
> > >   - Ordering the trip points. Some consolidation is needed in the set_trip_temp
> > >     ops before ordering the trip points, so this change is postpone
> > >
> > >   - Remove the mutex destroy call. Even if the call is not needed, the
> > >     justification of the change is not accurate. So it is postponed also.
> > >
> > >   V2:
> > >     - Removed ordering the trip points change
> > >     - Removed mutex destroy change
> > >     - Added "No functional change intented" as requested by Rui
> > >     - Added the function declaration for_each_thermal_trip
> > >
> > > Daniel Lezcano (3):
> > >    thermal/core: Fix unregistering netlink at thermal init time
> > >    thermal/core: Remove unneeded ida_destroy()
> > >    thermal/core: Move the thermal trip code to a dedicated file
> > >
> > >   drivers/thermal/Makefile          |   4 +-
> > >   drivers/thermal/thermal_core.c    |  93 +--------------
> > >   drivers/thermal/thermal_core.h    |   4 +
> > >   drivers/thermal/thermal_helpers.c |  62 ----------
> > >   drivers/thermal/thermal_netlink.c |   5 +
> > >   drivers/thermal/thermal_netlink.h |   3 +
> > >   drivers/thermal/thermal_trip.c    | 182 ++++++++++++++++++++++++++++++
> > >   7 files changed, 199 insertions(+), 154 deletions(-)
> > >   create mode 100644 drivers/thermal/thermal_trip.c
> > >
> >
> > --