From patchwork Mon Jan 23 10:09:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Ghiti X-Patchwork-Id: 4388 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1524503wrn; Mon, 23 Jan 2023 02:10:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXt65XBQwq527TWO1I8tBZGLHPgPpYxJB6ypwpjzv/ok6ytcIharfannCgCZvZKfZU6wcDov X-Received: by 2002:a05:6402:5d4:b0:499:bdd8:f8 with SMTP id n20-20020a05640205d400b00499bdd800f8mr28366193edx.5.1674468633299; Mon, 23 Jan 2023 02:10:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674468633; cv=none; d=google.com; s=arc-20160816; b=zVhuzYmXjPB7bOHcH/Ls+wuYNIHvFJ4tV+oR2nsnoPXHV1d3H4IMQQuAZ2Qn4zlPTM Ll7nb80AbKtPCsImCf4yTd94IMpoeV4TQR1xCqPJ8VD4Tw/2NuNIqCZu4nFV8k6Ozokn 9xBC62Ds/KA8EvdGO81OSmMMj9ziGtqDEchSi0PbWaFb9dn+DQ16N7YXfLBgjhkQ7BHn ZtKNQ+Sxvppvtsug7/Y3/J1Q64OAm4o2wOWl2lu5yxw2z6ntNC6hiN8kgtZzXK8fhah6 O2c+CyyocTrGwO5tgK6BdSw6kPxcDByIMCuqt6phbj6oLQjl/JQc7/LsY/WDlZ+xUPec ayAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BowUBQydnAafqAai7xO8TqOkM+didbH9IqQu35TSCq4=; b=o25l9ZXnY69ttrdnQZNN7zcJdHexFqAIk3QDT2qmr/383Lp/BeqFQxnkFqwWq7Goee c3jJSScqaxsuhwbEVri4nhK9AXJCpIbRYAadyLwcxvhhYUAm14uWvDhVfurY+9Uk1Nod w0knGggtq6M2Dbuck/GbcQbqpnarTZdmsHrCuWzeCfxkfRdGobDoxM+3nnIoH6sUPPcs FPTht8IRfczligwZO36xKi5z1qAhCnBJq9qCvv0p3BN544Z+g+blwVup7YFTfnRUJrP7 QtAWj0HKj9gAQeeqzry12ZseKojj59uuQ+LRR+LZM79BX5aKO5cIxidwK8ZiniRhD5vE l8mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=dOwqxgrV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g12-20020a056402320c00b004615937b174si33738609eda.480.2023.01.23.02.10.09; Mon, 23 Jan 2023 02:10:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=dOwqxgrV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231263AbjAWKJ5 (ORCPT + 99 others); Mon, 23 Jan 2023 05:09:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230074AbjAWKJ4 (ORCPT ); Mon, 23 Jan 2023 05:09:56 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 282BCCC31 for ; Mon, 23 Jan 2023 02:09:55 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so10198944wma.1 for ; Mon, 23 Jan 2023 02:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BowUBQydnAafqAai7xO8TqOkM+didbH9IqQu35TSCq4=; b=dOwqxgrVb3ypUy4k4M318f6E0m70qvhPaXk+aDiLRN4MuUpj2iih++Rsv4zeEwZQ/Z gve4hd6zTyG8YvQ8gOY1uzbwnzAsu8I9uZILphr7ks/N2yRFJ1CpIjkgVlnnsXLZ2rUL kv1LZ40Yjom/NcmpJWLKMyTNYHqVb8qelkDTrEkp/Ke1pH/imyoTS902MaR6FW2fQGmX ZOW2vt+6UBqyMc3E+NRg5YaC9YTt3EeMpt35ByUCj8q+2MXSNjSiU/JPVfvxLaocF2FT Lhp0sAkCvc8dDuvPa4LLRyhtveEfzTDWMGuyFcq+DHJVqPUWTkG8iZ6UZJ/wAitUfsV0 h2kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BowUBQydnAafqAai7xO8TqOkM+didbH9IqQu35TSCq4=; b=o/30NiyWG3BeWi2MzQSZ/aSfIFSfy4KZkqdttCPeWyXzldyvU61MsBvOVJ9IpuPcvA YMpHRtj6nYKChBey9uQuI5zNetB6PgQv4w5mLbylCMDsYTO9iG963fGWm+axbF2i3m2T V1VgtzcK9zkul6CqqRFJN6lQX85NEae/I9fso45CTDjIt/ZJP8O5KyVIucy9i7J6g0Zc Cu7ePbu4TIcK/2tgRZh+MSCIYvrb/WnDqnqvYja29ZX7q78L0anb49cSt13aUhmPt/pI uwC+M256MBk+z0BRthLG1FkudxJpJs/ym68jVUkCf/KRZET7pNSKgEKNJaUds+k8UiLk YoVQ== X-Gm-Message-State: AFqh2krz/4cAmyIE3KhTViDlI+Dbb3GqtYCIRyNGVDzBXtuVCfidjg+W xhA8VKDrq/N2XRAo0qOQRewGkQ== X-Received: by 2002:a05:600c:1c01:b0:3c6:e63e:23e9 with SMTP id j1-20020a05600c1c0100b003c6e63e23e9mr23745245wms.24.1674468593747; Mon, 23 Jan 2023 02:09:53 -0800 (PST) Received: from alex-rivos.ba.rivosinc.com (lfbn-lyo-1-450-160.w2-7.abo.wanadoo.fr. [2.7.42.160]) by smtp.gmail.com with ESMTPSA id bi16-20020a05600c3d9000b003daf89e01d3sm10170407wmb.11.2023.01.23.02.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 02:09:53 -0800 (PST) From: Alexandre Ghiti To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Ard Biesheuvel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-efi@vger.kernel.org Cc: Alexandre Ghiti Subject: [PATCH v2 0/6] RISC-V kasan rework Date: Mon, 23 Jan 2023 11:09:45 +0100 Message-Id: <20230123100951.810807-1-alexghiti@rivosinc.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755807621490546567?= X-GMAIL-MSGID: =?utf-8?q?1755807621490546567?= As described in patch 2, our current kasan implementation is intricate, so I tried to simplify the implementation and mimic what arm64/x86 are doing. In addition it fixes UEFI bootflow with a kasan kernel and kasan inline instrumentation: all kasan configurations were tested on a large ubuntu kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST. inline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK outline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK Actually 1 test always fails with KASAN_KUNIT_TEST that I have to check: # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan__test.c:1020 KASAN failure expected in "set_bit(nr, addr)", but none occurrred Note that Palmer recently proposed to remove COMMAND_LINE_SIZE from the userspace abi https://lore.kernel.org/lkml/20221211061358.28035-1-palmer@rivosinc.com/T/ so that we can finally increase the command line to fit all kasan kernel parameters. All of this should hopefully fix the syzkaller riscv build that has been failing for a few months now, any test is appreciated and if I can help in any way, please ask. v2: - Rebase on top of v6.2-rc3 - patch 4 is now way simpler than it used to be since Ard already moved the string functions into the efistub. Alexandre Ghiti (6): riscv: Split early and final KASAN population functions riscv: Rework kasan population functions riscv: Move DTB_EARLY_BASE_VA to the kernel address space riscv: Fix EFI stub usage of KASAN instrumented strcmp function riscv: Fix ptdump when KASAN is enabled riscv: Unconditionnally select KASAN_VMALLOC if KASAN arch/riscv/Kconfig | 1 + arch/riscv/kernel/image-vars.h | 2 - arch/riscv/mm/init.c | 2 +- arch/riscv/mm/kasan_init.c | 516 ++++++++++++++++++--------------- arch/riscv/mm/ptdump.c | 24 +- 5 files changed, 298 insertions(+), 247 deletions(-)