Message ID | 20230120190147.718976-1-opendmb@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp373931wrn; Fri, 20 Jan 2023 11:04:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXsTsKpjWinAwXmoX2ShkB8ZMr+bIgPNdo9EJ0knZbM8HVVw421PFpn/23/oR8bP9hnkbpVE X-Received: by 2002:a17:90a:305:b0:229:fbaa:37cb with SMTP id 5-20020a17090a030500b00229fbaa37cbmr5522105pje.41.1674241477333; Fri, 20 Jan 2023 11:04:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674241477; cv=none; d=google.com; s=arc-20160816; b=clQ+fd2QO1afLTPmBUamqyuQIGNWegwWTykvvITKYm3cXi6NIoiJLpflnURCt+MjAA FBOOtx7mdaMNOh4XecJmWoVo8I09m7QGCS3LteyPQOIZZXmnbJqwm1yFwIoz0K4qplFC 9KHzdx2x13RvC/ob1rqT2C+1/7P0+hp3w4CDJgn2c/yt3NWM1+7gozuJFtJnRoQYS29A d+xx2K3JP4NsEUWaWvnGgQY/AFqUtUJVc8M0MpFXhFh+sN7sknmNJhYJwjS52464tfnW tYYXhDbajH93xURzLFVAB8XUovVFNYKkFEIEiz6XWIu60WwN14fc862Wzo/SPYiF9vV5 Fj9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ty2vaSJYfWXnQKh12ga3jGSjJvuvI1UeShBRy78Xdwc=; b=ULiWAhW2Y7WVeF5l0vkBZm4tGvtzU4EHJFbWBTO28J9Bpn+GYrpibmzLcs/KhvxZhc +vCjCbLI9/FBbeHhfZTfwbECiX4y5qlayxpLOvrg1kqksjVXpauBWlGqDHbFiXXK8YDF iVAxn1n9JujdeKVQyuFRHJbUmHtm1BV7tTzSn1DujzSlBKtr2OMnz/wgplGQ+U2Ji2DS 3c1+OChJr/F/yDbD8Jm0h90x69ixZVqr7YBJWJVrzEvyjWbfJUkWcS85+FW4+ljE/78L nKdLb2ygTV0aVTpk09sVNz9f7g27ba2UBAI1jU+naACpEdkARw1qlpfvDzXZ/s+pXeag GJuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LTAzPNF1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mt12-20020a17090b230c00b0022bb87f2dfdsi1170677pjb.129.2023.01.20.11.04.25; Fri, 20 Jan 2023 11:04:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LTAzPNF1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229673AbjATTCZ (ORCPT <rfc822;forouhar.linux@gmail.com> + 99 others); Fri, 20 Jan 2023 14:02:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjATTCY (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 20 Jan 2023 14:02:24 -0500 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30D497EF1; Fri, 20 Jan 2023 11:02:23 -0800 (PST) Received: by mail-il1-x136.google.com with SMTP id h10so995546ilq.6; Fri, 20 Jan 2023 11:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ty2vaSJYfWXnQKh12ga3jGSjJvuvI1UeShBRy78Xdwc=; b=LTAzPNF1017FDGxs/KdhLIXruwcqk2UsjeXOJIy8s75ZAc5J7k3/GLf01h+Tsv00j/ 0UsHrctRRg+9Ze95HIOjiC4z9Owz5fYyMRbRq6VWNLKOfPsh0TQx8Mwc4cGeX5iejDl7 BUO32yalPHzhWBI9casVX99GKgCkHF2ZdzQjvqggU8ZLKghPyua9P+bqttA7fU9aeP/X A3bqvwusl9Qqgj+n+g4I8yUT0oAfDVe4DNPSWI5qnMTJMW2106m+u8kVcSahQgeJKOlj N5nUaMi0rOKsCSGw/SVCsarbxrc+eNXVZ6MdUfEf9i4H9nmQiKWjKnHubbZHakEnedsD YhgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ty2vaSJYfWXnQKh12ga3jGSjJvuvI1UeShBRy78Xdwc=; b=osOa4rXR8WXvd1YqmjeAIFizuM/Zk4eVW6qU/BMuRlPsArz1YeHnac8CQySdKNXW4A rFKnwTeI7RLCp8mcv7Z8IVUHawDTjc7JmPSU+5MMt+2QQIj5aj+9qQ6DljRCpzFfGnyD Bpdpc7c+d3+ldM212adtSf6v1XXUWYRKUguG5bsO0o28ZMBSgkPUHnqg6V9OmqaMmfLK mn7akWzEQ8ASqe1RCZwqaBB9r/HI1zAg1fcO+Y+lbVt1SMEndWIO6TTVpkK8SaTVAwQa GOfXVh+geqCp4q6u09Z+IuqR9Cw4ZTrG+muXCKIy7hZxJhwwoCITiwy0JF6i80pg/zKT KSBQ== X-Gm-Message-State: AFqh2kqZIestd81DRJz37mN1dzg1Wk24Vp3R8Yicy9z38APiaAvKguVN 8al0OMnVpSRhvSBy55AAigk= X-Received: by 2002:a05:6e02:1562:b0:30f:3736:25ab with SMTP id k2-20020a056e02156200b0030f373625abmr8463067ilu.28.1674241342553; Fri, 20 Jan 2023 11:02:22 -0800 (PST) Received: from stbirv-lnx-3.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y13-20020a37f60d000000b006fa2b1c3c1esm10379806qkj.58.2023.01.20.11.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 11:02:22 -0800 (PST) From: Doug Berger <opendmb@gmail.com> To: Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Brian Norris <computersforpeace@gmail.com>, Markus Mayer <mmayer@broadcom.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Florian Fainelli <f.fainelli@gmail.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Doug Berger <opendmb@gmail.com> Subject: [PATCH 0/6] rtc: brcmstb-waketimer: add RTC alarm irq Date: Fri, 20 Jan 2023 11:01:41 -0800 Message-Id: <20230120190147.718976-1-opendmb@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755569431452582622?= X-GMAIL-MSGID: =?utf-8?q?1755569431452582622?= |
Series |
rtc: brcmstb-waketimer: add RTC alarm irq
|
|
Message
Doug Berger
Jan. 20, 2023, 7:01 p.m. UTC
Support is added for an interrupt that can be triggered from the brcmstb-waketimer hardware while the system is awake. This interrupt allows the driver to pass the rtctest selftest. Doug Berger (6): rtc: brcmstb-waketimer: introduce WKTMR_ALARM_EVENT flag rtc: brcmstb-waketimer: non-functional code changes rtc: brcmstb-waketimer: compensate for lack of wktmr disable rtc: brcmstb-waketimer: rename irq to wake_irq dt-bindings: rtc: brcm,brcmstb-waketimer: add alarm interrupt rtc: brcmstb-waketimer: allow use as non-wake alarm .../bindings/rtc/brcm,brcmstb-waketimer.yaml | 22 ++- drivers/rtc/rtc-brcmstb-waketimer.c | 152 +++++++++++++----- 2 files changed, 130 insertions(+), 44 deletions(-)
Comments
On Fri, 20 Jan 2023 11:01:41 -0800, Doug Berger wrote: > Support is added for an interrupt that can be triggered from the > brcmstb-waketimer hardware while the system is awake. > > This interrupt allows the driver to pass the rtctest selftest. > > Doug Berger (6): > rtc: brcmstb-waketimer: introduce WKTMR_ALARM_EVENT flag > rtc: brcmstb-waketimer: non-functional code changes > rtc: brcmstb-waketimer: compensate for lack of wktmr disable > rtc: brcmstb-waketimer: rename irq to wake_irq > dt-bindings: rtc: brcm,brcmstb-waketimer: add alarm interrupt > rtc: brcmstb-waketimer: allow use as non-wake alarm > > [...] Applied, thanks! [1/6] rtc: brcmstb-waketimer: introduce WKTMR_ALARM_EVENT flag commit: 90226f6b17a3edcb0bddaf2f16991861c99d6a15 [2/6] rtc: brcmstb-waketimer: non-functional code changes commit: 2cd98b22c1443d1f2921a371baee658da184868e [3/6] rtc: brcmstb-waketimer: compensate for lack of wktmr disable commit: 516ae02c38ff3ae867f9b19fa050f78157e2bdae [4/6] rtc: brcmstb-waketimer: rename irq to wake_irq commit: eae258edcb8705932c9e5c61a99f91d8235f688b
On 1/23/23 15:08, 'Alexandre Belloni' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote: > > On Fri, 20 Jan 2023 11:01:41 -0800, Doug Berger wrote: >> Support is added for an interrupt that can be triggered from the >> brcmstb-waketimer hardware while the system is awake. >> >> This interrupt allows the driver to pass the rtctest selftest. >> >> Doug Berger (6): >> rtc: brcmstb-waketimer: introduce WKTMR_ALARM_EVENT flag >> rtc: brcmstb-waketimer: non-functional code changes >> rtc: brcmstb-waketimer: compensate for lack of wktmr disable >> rtc: brcmstb-waketimer: rename irq to wake_irq >> dt-bindings: rtc: brcm,brcmstb-waketimer: add alarm interrupt >> rtc: brcmstb-waketimer: allow use as non-wake alarm >> >> [...] > > Applied, thanks! > > [1/6] rtc: brcmstb-waketimer: introduce WKTMR_ALARM_EVENT flag > commit: 90226f6b17a3edcb0bddaf2f16991861c99d6a15 > [2/6] rtc: brcmstb-waketimer: non-functional code changes > commit: 2cd98b22c1443d1f2921a371baee658da184868e > [3/6] rtc: brcmstb-waketimer: compensate for lack of wktmr disable > commit: 516ae02c38ff3ae867f9b19fa050f78157e2bdae > [4/6] rtc: brcmstb-waketimer: rename irq to wake_irq > commit: eae258edcb8705932c9e5c61a99f91d8235f688b That was quick, how about patch 6? It does not actually have a dependency on the Device Tree binding (patch 5) and the second interrupt is looked up by index.
On 24/01/2023 09:42:19-0800, Florian Fainelli wrote: > On 1/23/23 15:08, 'Alexandre Belloni' via BCM-KERNEL-FEEDBACK-LIST,PDL > wrote: > > > > On Fri, 20 Jan 2023 11:01:41 -0800, Doug Berger wrote: > > > Support is added for an interrupt that can be triggered from the > > > brcmstb-waketimer hardware while the system is awake. > > > > > > This interrupt allows the driver to pass the rtctest selftest. > > > > > > Doug Berger (6): > > > rtc: brcmstb-waketimer: introduce WKTMR_ALARM_EVENT flag > > > rtc: brcmstb-waketimer: non-functional code changes > > > rtc: brcmstb-waketimer: compensate for lack of wktmr disable > > > rtc: brcmstb-waketimer: rename irq to wake_irq > > > dt-bindings: rtc: brcm,brcmstb-waketimer: add alarm interrupt > > > rtc: brcmstb-waketimer: allow use as non-wake alarm > > > > > > [...] > > > > Applied, thanks! > > > > [1/6] rtc: brcmstb-waketimer: introduce WKTMR_ALARM_EVENT flag > > commit: 90226f6b17a3edcb0bddaf2f16991861c99d6a15 > > [2/6] rtc: brcmstb-waketimer: non-functional code changes > > commit: 2cd98b22c1443d1f2921a371baee658da184868e > > [3/6] rtc: brcmstb-waketimer: compensate for lack of wktmr disable > > commit: 516ae02c38ff3ae867f9b19fa050f78157e2bdae > > [4/6] rtc: brcmstb-waketimer: rename irq to wake_irq > > commit: eae258edcb8705932c9e5c61a99f91d8235f688b > > That was quick, how about patch 6? It does not actually have a dependency on > the Device Tree binding (patch 5) and the second interrupt is looked up by > index. My understanding is that if I take it, then the feature will not be documented. I keep that as an incentive to send v2 ;)