Message ID | 20230120165408.500511-1-kan.liang@linux.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp312107wrn; Fri, 20 Jan 2023 09:01:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXtMJhXOF//ZXhcB0MTnJjdOoquidkFeTBLEqP285ECF2DlT6wWmrRvttJEqV0VS1qT6vc+A X-Received: by 2002:a17:90a:fb52:b0:229:2d53:3f92 with SMTP id iq18-20020a17090afb5200b002292d533f92mr16462461pjb.36.1674234081354; Fri, 20 Jan 2023 09:01:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674234081; cv=none; d=google.com; s=arc-20160816; b=Cn1GfXs2N7glz63YdhWC8xdBCptNVqs+03Dow87EA3xzO4B/v6RdN/nF3KrcTPjEuS p+ak4H/9Jt5snLnll+fXHYlOh7CPMNVJ4NEo/FAqGURBnj4AfBg+7GakrIoepqf2BNzJ Bpe8qcXKpQNC0qHkDYT+2S9uHuouI3POaWQIA9v8aT4tBSGzFInQ0w+tbZZBEzZdfHXC /qVk9F9eLwRO9JrZGuYTg4PKjK5hPfACfDoDWV4fXMveI/NA79lMj+qzloco2uTGylLA jROU9Ase9qfmIJaTAasmisDFJpRVtYYghV20VTGMymgPE+BtpxHqcqs6TM27htPreawe DNtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3c7A07Tw+0W/WnNijf8w2ZuJDcJks80c0tsWolaSaZ8=; b=zZIE8/u65Ia4+AdLmtD5csYMb8RNKb348ZqVJJJl7NqOXaNseTbN0kAnPM6D1RGRB8 SQWwZjZI5QaEGmLFxsUCgHlRCzVzKuDAyJ9pOZLS3VwSMgUJRqUpSnF6ThpJ88xgRYtu lXZ8aPSlZzr0r2qrkuauzeJCTGW24oVof+Dv2zE3owFGf7ZtNZwfnLAse7+MXobIsoSO jJ2GUzO76s5Mu7vawifLInVTf9cAhyokid4qxieqo+jnbhYrBtOgYkbig06SVh/lNWvO oQdTaw6le2y8p8n4ClcPBvofk1Yz6mBETQwn+V2gOXJuTONumcgmQ0v4GSszIGU6sM7F US/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hYA7VPUA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d3-20020a17090a6f0300b002298cb342fcsi2896479pjk.121.2023.01.20.09.01.08; Fri, 20 Jan 2023 09:01:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hYA7VPUA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230296AbjATQyy (ORCPT <rfc822;forouhar.linux@gmail.com> + 99 others); Fri, 20 Jan 2023 11:54:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjATQys (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 20 Jan 2023 11:54:48 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F123C17B for <linux-kernel@vger.kernel.org>; Fri, 20 Jan 2023 08:54:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674233687; x=1705769687; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=L5adZLDfpzZ5TjZGsFBthPz0tUNZi5rcH/sfXtmD1yM=; b=hYA7VPUA1y9CRRnkVIWkKCbIv/iV0toie257e9npwPOMWWWx0GYN2oTO N+o+LS2vkoYRea1hux526d8+ZY79oLBJ9dg35hnevFWFkvRWULWQp0V/R +575lonNBJhEQWiMKCrk4XwO5LtxoJBNUPlaQ1D4/bSalPdzHPDP4Z3QU B2bv3myJp+kr44yJIhB+NsdpT5XB/Bqo8Pj6z4IvKkhoChOrgP8EP6D+1 +mzR5sCbXd6s8DnPIESUpCxyovcc1ZOfIbKWHxqyrO1GDkuWxhOVFXZG6 dj30I2w/wZMAWvdj6UBRJIr9DxTfcY4OEZksGh5x4pU278wFGhDyMpQAB A==; X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="324315174" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="324315174" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 08:54:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="638207825" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="638207825" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orsmga006.jf.intel.com with ESMTP; 20 Jan 2023 08:54:45 -0800 From: kan.liang@linux.intel.com To: joro@8bytes.org, will@kernel.org, baolu.lu@linux.intel.com, dwmw2@infradead.org, robin.murphy@arm.com, robert.moore@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Cc: yu-cheng.yu@intel.com, Kan Liang <kan.liang@linux.intel.com> Subject: [PATCH V3 0/7] iommu/vt-d: Support performance monitoring for IOMMU Date: Fri, 20 Jan 2023 08:54:01 -0800 Message-Id: <20230120165408.500511-1-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755561676321115459?= X-GMAIL-MSGID: =?utf-8?q?1755561676321115459?= |
Series |
iommu/vt-d: Support performance monitoring for IOMMU
|
|
Message
Liang, Kan
Jan. 20, 2023, 4:54 p.m. UTC
From: Kan Liang <kan.liang@linux.intel.com>
Changes since V2:
- Move ecmd_submit_sync() to iommu.c to avoid #ifdef CONFIG_INTEL_IOMMU
Changes since V1:
- The cap and ecap registers are always in the first page. It's not
necessary to use the reg size in dmar_validate_one_drhd(). (Patch 1)
- Move reg_size up and pair it with reg_base_addr in struct
dmar_drhd_unit (Patch 1)
- Update the year of Copyright (Patch 2)
- Return 0 if PMS is not supported (Patch 2)
- Refine the comments and add a pr_warn for per-counter capabilities
check (Patch 2)
- Remove unnecessary iommu_pmu->num_cntr = i (Patch 2)
- Remove has_ob of ecmd_submit_sync() (Patch 3)
- Remove the helpers from non-INTEL_IOMMU. (Patch 3)
- Still keep #ifdef CONFIG_INTEL_IOMMU for ecmd_submit_sync() to
avoid compile warning with non-INTEL_IOMMU config.
- Use pr_warn_once() to replace WARN_ONCE() (Patch 4 & 6)
- Free iommu PMU if it fails to be registered. (Patch 4)
- Remove unnecessary 'handled' variable. (Patch 6)
A performance monitoring infrastructure, perfmon, is introduced with
the VT-d Spec 4.0. The purpose of perfmon is to support collection of
information about key events occurring during operation of the remapping
hardware, to aid performance tuning and debug. The patch series is to
support the perfmon for IOMMU.
To facilitate the perfmon support, the patch series also supports two
new generic features of VT-d Spec 4.0.
- Support the 'size' field to retrieve the accurate size of the register
set for each dmar device from DRHD. (Patch 1)
- Support the new Enhanced Command Interface. (Patch 3)
With the patch series, users can collect the performance data of IOMMU
via Linux perf tool. For example,
$ perf stat -e dmar0/iommu_requests,filter_ats=0/ -a sleep 1
Performance counter stats for 'system wide':
2135 dmar0/iommu_requests,filter_ats=0/
1.001087695 seconds time elapsed
The IOMMU PMUs can be found under /sys/bus/event_source/devices/dmar*
The available filters and event format can be found at the format folder
$ ls /sys/bus/event_source/devices/dmar0/format/
event event_group filter_ats filter_page_table
The supported events can be found at the events folder
$ ls /sys/bus/event_source/devices/dmar0/events/
ats_blocked int_cache_hit_nonposted iommu_mrds
pasid_cache_lookup
ctxt_cache_hit int_cache_hit_posted iommu_requests
pg_req_posted
ctxt_cache_lookup int_cache_lookup iotlb_hit
pw_occupancy
fs_nonleaf_hit iommu_clocks iotlb_lookup
ss_nonleaf_hit
fs_nonleaf_lookup iommu_mem_blocked pasid_cache_hit
ss_nonleaf_lookup
Kan Liang (7):
iommu/vt-d: Support size of the register set in DRHD
iommu/vt-d: Retrieve IOMMU perfmon capability information
iommu/vt-d: Support Enhanced Command Interface
iommu/vt-d: Add IOMMU perfmon support
iommu/vt-d: Support cpumask for IOMMU perfmon
iommu/vt-d: Add IOMMU perfmon overflow handler support
iommu/vt-d: Enable IOMMU perfmon support
.../sysfs-bus-event_source-devices-iommu | 32 +
drivers/iommu/intel/Kconfig | 9 +
drivers/iommu/intel/Makefile | 1 +
drivers/iommu/intel/dmar.c | 33 +-
drivers/iommu/intel/iommu.c | 59 ++
drivers/iommu/intel/iommu.h | 101 +-
drivers/iommu/intel/perfmon.c | 860 ++++++++++++++++++
drivers/iommu/intel/perfmon.h | 65 ++
drivers/iommu/intel/svm.c | 2 +-
include/acpi/actbl1.h | 2 +-
include/linux/cpuhotplug.h | 1 +
include/linux/dmar.h | 1 +
12 files changed, 1159 insertions(+), 7 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-bus-event_source-devices-iommu
create mode 100644 drivers/iommu/intel/perfmon.c
create mode 100644 drivers/iommu/intel/perfmon.h
Comments
On 2023/1/21 0:54, kan.liang@linux.intel.com wrote: > From: Kan Liang <kan.liang@linux.intel.com> > > Changes since V2: > - Move ecmd_submit_sync() to iommu.c to avoid #ifdef CONFIG_INTEL_IOMMU > > Changes since V1: > - The cap and ecap registers are always in the first page. It's not > necessary to use the reg size in dmar_validate_one_drhd(). (Patch 1) > - Move reg_size up and pair it with reg_base_addr in struct > dmar_drhd_unit (Patch 1) > - Update the year of Copyright (Patch 2) > - Return 0 if PMS is not supported (Patch 2) > - Refine the comments and add a pr_warn for per-counter capabilities > check (Patch 2) > - Remove unnecessary iommu_pmu->num_cntr = i (Patch 2) > - Remove has_ob of ecmd_submit_sync() (Patch 3) > - Remove the helpers from non-INTEL_IOMMU. (Patch 3) > - Still keep #ifdef CONFIG_INTEL_IOMMU for ecmd_submit_sync() to > avoid compile warning with non-INTEL_IOMMU config. > - Use pr_warn_once() to replace WARN_ONCE() (Patch 4 & 6) > - Free iommu PMU if it fails to be registered. (Patch 4) > - Remove unnecessary 'handled' variable. (Patch 6) > > A performance monitoring infrastructure, perfmon, is introduced with > the VT-d Spec 4.0. The purpose of perfmon is to support collection of > information about key events occurring during operation of the remapping > hardware, to aid performance tuning and debug. The patch series is to > support the perfmon for IOMMU. > > To facilitate the perfmon support, the patch series also supports two > new generic features of VT-d Spec 4.0. > - Support the 'size' field to retrieve the accurate size of the register > set for each dmar device from DRHD. (Patch 1) > - Support the new Enhanced Command Interface. (Patch 3) > > With the patch series, users can collect the performance data of IOMMU > via Linux perf tool. For example, > > $ perf stat -e dmar0/iommu_requests,filter_ats=0/ -a sleep 1 > > Performance counter stats for 'system wide': > > 2135 dmar0/iommu_requests,filter_ats=0/ > > 1.001087695 seconds time elapsed > > The IOMMU PMUs can be found under /sys/bus/event_source/devices/dmar* > > The available filters and event format can be found at the format folder > $ ls /sys/bus/event_source/devices/dmar0/format/ > event event_group filter_ats filter_page_table > > The supported events can be found at the events folder > > $ ls /sys/bus/event_source/devices/dmar0/events/ > ats_blocked int_cache_hit_nonposted iommu_mrds > pasid_cache_lookup > ctxt_cache_hit int_cache_hit_posted iommu_requests > pg_req_posted > ctxt_cache_lookup int_cache_lookup iotlb_hit > pw_occupancy > fs_nonleaf_hit iommu_clocks iotlb_lookup > ss_nonleaf_hit > fs_nonleaf_lookup iommu_mem_blocked pasid_cache_hit > ss_nonleaf_lookup > > Kan Liang (7): > iommu/vt-d: Support size of the register set in DRHD > iommu/vt-d: Retrieve IOMMU perfmon capability information > iommu/vt-d: Support Enhanced Command Interface > iommu/vt-d: Add IOMMU perfmon support > iommu/vt-d: Support cpumask for IOMMU perfmon > iommu/vt-d: Add IOMMU perfmon overflow handler support > iommu/vt-d: Enable IOMMU perfmon support > > .../sysfs-bus-event_source-devices-iommu | 32 + > drivers/iommu/intel/Kconfig | 9 + > drivers/iommu/intel/Makefile | 1 + > drivers/iommu/intel/dmar.c | 33 +- > drivers/iommu/intel/iommu.c | 59 ++ > drivers/iommu/intel/iommu.h | 101 +- > drivers/iommu/intel/perfmon.c | 860 ++++++++++++++++++ > drivers/iommu/intel/perfmon.h | 65 ++ > drivers/iommu/intel/svm.c | 2 +- > include/acpi/actbl1.h | 2 +- > include/linux/cpuhotplug.h | 1 + > include/linux/dmar.h | 1 + > 12 files changed, 1159 insertions(+), 7 deletions(-) > create mode 100644 Documentation/ABI/testing/sysfs-bus-event_source-devices-iommu > create mode 100644 drivers/iommu/intel/perfmon.c > create mode 100644 drivers/iommu/intel/perfmon.h Thanks for the work. The overall looks good to me now. But I am still seeing some code style issues after running "./scripts/checkpatch.pl --strict" scripts. Can you please fix those issues and post a v4? Best regards, baolu
On 2023-01-28 2:10 a.m., Baolu Lu wrote: > On 2023/1/21 0:54, kan.liang@linux.intel.com wrote: >> From: Kan Liang <kan.liang@linux.intel.com> >> >> Changes since V2: >> - Move ecmd_submit_sync() to iommu.c to avoid #ifdef CONFIG_INTEL_IOMMU >> >> Changes since V1: >> - The cap and ecap registers are always in the first page. It's not >> necessary to use the reg size in dmar_validate_one_drhd(). (Patch 1) >> - Move reg_size up and pair it with reg_base_addr in struct >> dmar_drhd_unit (Patch 1) >> - Update the year of Copyright (Patch 2) >> - Return 0 if PMS is not supported (Patch 2) >> - Refine the comments and add a pr_warn for per-counter capabilities >> check (Patch 2) >> - Remove unnecessary iommu_pmu->num_cntr = i (Patch 2) >> - Remove has_ob of ecmd_submit_sync() (Patch 3) >> - Remove the helpers from non-INTEL_IOMMU. (Patch 3) >> - Still keep #ifdef CONFIG_INTEL_IOMMU for ecmd_submit_sync() to >> avoid compile warning with non-INTEL_IOMMU config. >> - Use pr_warn_once() to replace WARN_ONCE() (Patch 4 & 6) >> - Free iommu PMU if it fails to be registered. (Patch 4) >> - Remove unnecessary 'handled' variable. (Patch 6) >> >> A performance monitoring infrastructure, perfmon, is introduced with >> the VT-d Spec 4.0. The purpose of perfmon is to support collection of >> information about key events occurring during operation of the remapping >> hardware, to aid performance tuning and debug. The patch series is to >> support the perfmon for IOMMU. >> >> To facilitate the perfmon support, the patch series also supports two >> new generic features of VT-d Spec 4.0. >> - Support the 'size' field to retrieve the accurate size of the register >> set for each dmar device from DRHD. (Patch 1) >> - Support the new Enhanced Command Interface. (Patch 3) >> >> With the patch series, users can collect the performance data of IOMMU >> via Linux perf tool. For example, >> >> $ perf stat -e dmar0/iommu_requests,filter_ats=0/ -a sleep 1 >> >> Performance counter stats for 'system wide': >> >> 2135 dmar0/iommu_requests,filter_ats=0/ >> >> 1.001087695 seconds time elapsed >> >> The IOMMU PMUs can be found under /sys/bus/event_source/devices/dmar* >> >> The available filters and event format can be found at the format folder >> $ ls /sys/bus/event_source/devices/dmar0/format/ >> event event_group filter_ats filter_page_table >> >> The supported events can be found at the events folder >> >> $ ls /sys/bus/event_source/devices/dmar0/events/ >> ats_blocked int_cache_hit_nonposted iommu_mrds >> pasid_cache_lookup >> ctxt_cache_hit int_cache_hit_posted iommu_requests >> pg_req_posted >> ctxt_cache_lookup int_cache_lookup iotlb_hit >> pw_occupancy >> fs_nonleaf_hit iommu_clocks iotlb_lookup >> ss_nonleaf_hit >> fs_nonleaf_lookup iommu_mem_blocked pasid_cache_hit >> ss_nonleaf_lookup >> >> Kan Liang (7): >> iommu/vt-d: Support size of the register set in DRHD >> iommu/vt-d: Retrieve IOMMU perfmon capability information >> iommu/vt-d: Support Enhanced Command Interface >> iommu/vt-d: Add IOMMU perfmon support >> iommu/vt-d: Support cpumask for IOMMU perfmon >> iommu/vt-d: Add IOMMU perfmon overflow handler support >> iommu/vt-d: Enable IOMMU perfmon support >> >> .../sysfs-bus-event_source-devices-iommu | 32 + >> drivers/iommu/intel/Kconfig | 9 + >> drivers/iommu/intel/Makefile | 1 + >> drivers/iommu/intel/dmar.c | 33 +- >> drivers/iommu/intel/iommu.c | 59 ++ >> drivers/iommu/intel/iommu.h | 101 +- >> drivers/iommu/intel/perfmon.c | 860 ++++++++++++++++++ >> drivers/iommu/intel/perfmon.h | 65 ++ >> drivers/iommu/intel/svm.c | 2 +- >> include/acpi/actbl1.h | 2 +- >> include/linux/cpuhotplug.h | 1 + >> include/linux/dmar.h | 1 + >> 12 files changed, 1159 insertions(+), 7 deletions(-) >> create mode 100644 >> Documentation/ABI/testing/sysfs-bus-event_source-devices-iommu >> create mode 100644 drivers/iommu/intel/perfmon.c >> create mode 100644 drivers/iommu/intel/perfmon.h > > Thanks for the work. The overall looks good to me now. But I am still > seeing some code style issues after running "./scripts/checkpatch.pl > --strict" scripts. > > Can you please fix those issues and post a v4? > Sure. Thanks, Kan