From patchwork Fri Jan 20 14:36:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Clark X-Patchwork-Id: 4319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp245069wrn; Fri, 20 Jan 2023 07:00:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXsc/DkdNIMbuPUrviVDjSCk+aPvlCUFARcuBeaj6v+j9rOrK4FzLKSOsq44sdj7cXRJVmOu X-Received: by 2002:a17:90b:1112:b0:21a:1f5f:e798 with SMTP id gi18-20020a17090b111200b0021a1f5fe798mr15731185pjb.48.1674226831331; Fri, 20 Jan 2023 07:00:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674226831; cv=none; d=google.com; s=arc-20160816; b=IjcsfZmoc0M3qXFbqlk/h8QnSZPoGbYzoGQcRO8+bK7kS2/AIOYrXuIHy74GHHyV59 wWtnoL7ulEv8yAfadmoQmk4qwm2nipV9tJJvsgCwOkye96yFwkvLdj6vZmLPLF+LQSXF bPeq/rczjqOSfSMTARlsiHIFNOJ68VpK3jW6Zxicio3IHoMshmUnMKc8HIBf4b035p7F FPT4DwSt6iGwo0vnQmg5jKhGbHO+DCjh4WOJ6fJvb65Cd5iIGr9rfsy2/HBTetQcRVdW CjqFJmRJ1NRLJ4aIVRt43EBEwXfqoiPPclmeASzecfK6zdcsJyRsq4vNhn1Qs/oLJLUc NOGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=WGpeyJzBybjQ2Vqk0Y3QbexM40jwuJ53QIJKQPCkTBA=; b=wFsY2VY1SjkEPmp+nik+f1b2jvccv1QY2jQhnXlo5sPYfUJMjnZ7MmG6QJFRCkLH8A PtzkWG8LwxJwW/iZMUzzjcIkSirMs/fhzTGxpaQedaeHh7pj7huXbvzkbkZkVGkleLcc 6GC+u/V7mJvShZyHpTK9DJZNNHWS1FXAI6OpQCVPUHBUgEY1QsSpwTIcbAzxUDN0zYjI PF4muEJillBCLnyc7p363FajBeB3rFKuFNXqmSzxrTXIePaxdLGADtQd1SJhojmcMZ9V BT1RJQLlWstj6dntqLrwnjNwE2t5LPSippAzVJnHZ44p9siFYtT2InQzWHr+uavbzyxi cCZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d23-20020a17090ab31700b00225a7fb0dbdsi2596381pjr.111.2023.01.20.07.00.11; Fri, 20 Jan 2023 07:00:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230166AbjATOur (ORCPT + 99 others); Fri, 20 Jan 2023 09:50:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbjATOuo (ORCPT ); Fri, 20 Jan 2023 09:50:44 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ABCE340C3; Fri, 20 Jan 2023 06:50:42 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F3C514BF; Fri, 20 Jan 2023 06:38:34 -0800 (PST) Received: from e126815.warwick.arm.com (e126815.arm.com [10.32.32.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 914173F67D; Fri, 20 Jan 2023 06:37:49 -0800 (PST) From: James Clark To: linux-perf-users@vger.kernel.org, tanmay@marvell.com, leo.yan@linaro.org, mike.leach@linaro.org Cc: sgoutham@marvell.com, gcherian@marvell.com, lcherian@marvell.com, bbhushan2@marvell.com, James Clark , Mathieu Poirier , Suzuki K Poulose , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 0/8] perf cs_etm: Basic support for virtual/kernel timestamps Date: Fri, 20 Jan 2023 14:36:53 +0000 Message-Id: <20230120143702.4035046-1-james.clark@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755553817961367801?= X-GMAIL-MSGID: =?utf-8?q?1755554073909195703?= Changes since v4: * Rebase onto perf/core * Convert new perf_pmu__cpu_slots_per_cycle() function to use new helper functions =========================== Changes since v3: * Scale time estimates by INSTR_PER_NS, rather than assuming 1 instruction = 1ns * Add a new commit that fixes some issues around timestamps going backwards * Use nanoseconds inside cs-etm-decoder.c, rather than storing the raw time values and converting when a sample is synthesized. This simplifies some of the code like estimating the first timestamp. =========================== Changes since v2: * Remove const to non-const change and copy strings where needed instead. * Use sizeof() instead of PATH_MAX * Append "will not be set accurately." to new error message * Remove unneeded stat() call * Rebase on perf/core ========================== Changes since v1: * Add 3 refactor commits for sysfs reading around pmu.c as suggested by Arnaldo here [1] * The dependency on [2] has now reached mainline so is no longer blocking * Rebase on perf/core [1]: https://lore.kernel.org/all/YnqVqq5QW%2Fb14oPZ@kernel.org/ [2]: https://lore.kernel.org/all/20220503123537.1003035-1-german.gomez@arm.com/ German Gomez (4): perf pmu: Add function to check if a pmu file exists perf cs_etm: Keep separate symbols for ETMv4 and ETE parameters perf cs_etm: Record ts_source in AUXTRACE_INFO for ETMv4 and ETE perf cs_etm: Set the time field in the synthetic samples James Clark (4): perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH perf: Use perf_pmu__open_file() and perf_pmu__scan_file() perf: Remove remaining duplication of bus/event_source/devices/... perf: cs-etm: Ensure that Coresight timestamps don't go backwards tools/perf/arch/arm/util/auxtrace.c | 5 +- tools/perf/arch/arm/util/cs-etm.c | 91 ++++++++- tools/perf/arch/arm64/util/pmu.c | 4 +- tools/perf/arch/x86/util/pmu.c | 12 +- tools/perf/util/cputopo.c | 9 +- tools/perf/util/cs-etm-base.c | 34 +++- .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 68 +++++-- tools/perf/util/cs-etm.c | 95 +++++++++- tools/perf/util/cs-etm.h | 16 +- tools/perf/util/pmu-hybrid.c | 27 +-- tools/perf/util/pmu.c | 177 +++++++----------- tools/perf/util/pmu.h | 10 +- 12 files changed, 351 insertions(+), 197 deletions(-) base-commit: 1962ab6f6e0b39e4216206205bda14aff87705f3 prerequisite-patch-id: 9722bf86e3e6d16d177ff9a1411992a795a7dcbd prerequisite-patch-id: b05dbef439c2ea8465f3321532257b0ca29f21f9 prerequisite-patch-id: 92680a4781cbcf010fcb007e6ea030f59e9eaefc prerequisite-patch-id: 8e3a73a04e4b89b503377b5fac1d89d551159393 prerequisite-patch-id: 09980d8fedcdaa70b220a7802428109f48448a58 Tested-by: Tanmay Jagdale