From patchwork Fri Jan 20 09:20:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 4296 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp97465wrn; Fri, 20 Jan 2023 01:21:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXv/BKeeiUVbtzWjA8NfgRYf5fG0z0ZSKbAvQrEDr9a2cSKFPGLTU4Iu8HqUj8a1KJxDPoiI X-Received: by 2002:a17:907:6c16:b0:86f:5636:4712 with SMTP id rl22-20020a1709076c1600b0086f56364712mr16612101ejc.7.1674206514096; Fri, 20 Jan 2023 01:21:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674206514; cv=none; d=google.com; s=arc-20160816; b=tV4LUVRwtQNvTpJYgrkOr3q8J0JfYsNBl1AbRMROslcJ3IAuLtvI0raGc3rUkw/ju1 tEx4nv6K9uX6gmAUuC11cRPaEKYLHUU9Bdpe7HIAUCSihEHaip//pNkTV/1+EpU6VFYc PoP999+ao6/2pQdfm4rV4L6LDrzdRi20rJLSe6YZPvLqAkn4NNtHu6DOc+98Qs+gvVzB 1NeCwiIt5jlCYokQsjTeiCGadQJR7Y2wjFMvZgpjGGaUVYkMXGZuLcoIcEtE49gHYuLQ J4CQ8s+PUhLqpXraRGYvrctJoQ3xS29a26ViSMpp68IjWuF5oAb7AXVQM4DjvShXoDxg rGGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LfLfi9B9wMdjQJ+K0evMXmGvBLkEUWxKVbaioKgW0KA=; b=N7XyiZU2HPFx4dUVI38LdMV5zZmyvGe4+KMrfYJ982EaocApUxO4Oq3fWKiROT8+Iv 2rH97KGkAKjtxPaYfHYh/YE7AOC3BtTwpTXVNamv0o+c45FINWFym1TaDbNSZbg3+USQ jECRwKBoOvDBy1o1SLKMPHguTEu28MMd9SejF0wxiwyT/JxbFJcIlHvbCM03Q9IhTkg9 bnkfcEpn8xsSJj69ZzHBHs2M2dGGXMVDWiCdyI5m23QlkCydX9UBLc3kzNQqNT1cR29e dtUPUuDAHQDLuAnxMU1j1PaJgmMnB4z9LdLeC3sPQ5i9VwocxjByE3LzWqM9qmVUqxnD Nc8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=NH6V5Iyg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt17-20020a170907729100b0084d1d7fbd27si46614014ejc.205.2023.01.20.01.21.30; Fri, 20 Jan 2023 01:21:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=NH6V5Iyg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbjATJVP (ORCPT + 99 others); Fri, 20 Jan 2023 04:21:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230184AbjATJVM (ORCPT ); Fri, 20 Jan 2023 04:21:12 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3973E9085F; Fri, 20 Jan 2023 01:21:01 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id E8E92660230B; Fri, 20 Jan 2023 09:20:57 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1674206459; bh=08pqxwBJ+ELb6MVeH4W4H+Ud+X9mBids/ORKAnMiXrY=; h=From:To:Cc:Subject:Date:From; b=NH6V5IygSrDjcCKE9BQhvpFi25inC8l3SCfcBo5tjaBXmP8jAfGuD7JCB+5JeE6vK jB7atxxZwxL2igwD/YZv2XZ0VhVbwG7WclRzM6fjxqhWoth+BT47Y6i2zbAUzKZpkt 49v7y1zgQX5echY8oiw+rE3gjhQYjscILKy4fACSUTBD8jmky3EDHcQcN1dfKCYV18 M0SlM1kEu1lHETTl4E0Z/Sgi44UN8kBMMHYBak0Fw8Ne6o7h8vuR1rXS7zs2ODHMSP 2Wl+fStBEee937lxgp0TfIqDXiXvqZjPbaX1D0OFEdBjOK13uJe6komv7XE+kWeDfy zj0SqvL5uXwgw== From: AngeloGioacchino Del Regno To: mturquette@baylibre.com Cc: sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, angelogioacchino.delregno@collabora.com, wenst@chromium.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com Subject: [PATCH v4 00/23] MediaTek clocks cleanups and improvements Date: Fri, 20 Jan 2023 10:20:30 +0100 Message-Id: <20230120092053.182923-1-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755532769762167263?= X-GMAIL-MSGID: =?utf-8?q?1755532769762167263?= Changes in v4: - Exported cg_regs_dummy to fix modpost issues with mt8173 drivers - Changed mtk_register_reset_controller() to _with_dev() variant to fix last modpost issues - Added Miles' Tested-by tags on all commits touching mt6779/8192 Changes in v3: - Moved struct device pointer as first member in all commits adding propagation of it - Fixed some indentation issues as pointed out by strict checkpatch - Tested again to make sure that nothing went wrong in the process :-) Changes in v2: - Moved dt-bindings CLK_DUMMY to clk-mtk.h instead This series performs cleanups and improvements on MediaTek clock drivers, greatly reducing code duplication (hence also reducing kernel size). There would be a lot to say about it, but summarizing: * Propagates struct device where possible in order to introduce the possibility of using Runtime PM on clock drivers as needed, possibly enhancing reliability of some platforms (obviously, this will do nothing unless power-domains are added to devicetree); * Cleans up some duplicated clock(s) registration attempt(s): on some platforms the 26M fixed factor clock is registered early, but then upon platform_driver probe, an attempt to re-register that clock was performed; * Removes some early clock registration where possible, moving everything to platform_driver clock probe; * Breaks down the big MT8173 clock driver in multiple ones, as it's already done with the others, cleans it up and adds possibility possibility to compile non-boot-critical clock drivers (for 8173) as modules; * Extends the common mtk_clk_simple_probe() function to be able to register multiple MediaTek clock types; * Removes duplicated [...]_probe functions from multiple MediaTek SoC clock drivers, migrating almost everything to the common functions mtk_clk_simple_probe(); * Adds a .remove() callback, pointing to the common mtk_clk_simple_remove() function to all clock drivers that were migrated to the common probe; * Some more spare cleanups here and there. All of this was manually tested on various Chromebooks (with different MTK SoCs) and no regression was detected. Cheers! AngeloGioacchino Del Regno (23): clk: mediatek: mt8192: Correctly unregister and free clocks on failure clk: mediatek: mt8192: Propagate struct device for gate clocks clk: mediatek: clk-gate: Propagate struct device with mtk_clk_register_gates() clk: mediatek: cpumux: Propagate struct device where possible clk: mediatek: clk-mtk: Propagate struct device for composites clk: mediatek: clk-mux: Propagate struct device for mtk-mux clk: mediatek: clk-mtk: Add dummy clock ops clk: mediatek: mt8173: Migrate to platform driver and common probe clk: mediatek: mt8173: Remove mtk_clk_enable_critical() clk: mediatek: mt8173: Break down clock drivers and allow module build clk: mediatek: Switch to mtk_clk_simple_probe() where possible clk: mediatek: clk-mtk: Extend mtk_clk_simple_probe() clk: mediatek: mt8173: Migrate pericfg/topckgen to mtk_clk_simple_probe() clk: mediatek: clk-mt8192: Move CLK_TOP_CSW_F26M_D2 in top_divs clk: mediatek: mt8192: Join top_adj_divs and top_muxes clk: mediatek: mt8186: Join top_adj_div and top_muxes clk: mediatek: clk-mt8183: Join top_aud_muxes and top_aud_divs clk: mediatek: clk-mtk: Register MFG notifier in mtk_clk_simple_probe() clk: mediatek: clk-mt8192: Migrate topckgen to mtk_clk_simple_probe() clk: mediatek: clk-mt8186-topckgen: Migrate to mtk_clk_simple_probe() clk: mediatek: clk-mt6795-topckgen: Migrate to mtk_clk_simple_probe() clk: mediatek: clk-mt7986-topckgen: Properly keep some clocks enabled clk: mediatek: clk-mt7986-topckgen: Migrate to mtk_clk_simple_probe() drivers/clk/mediatek/Kconfig | 32 +- drivers/clk/mediatek/Makefile | 6 +- drivers/clk/mediatek/clk-cpumux.c | 8 +- drivers/clk/mediatek/clk-cpumux.h | 2 +- drivers/clk/mediatek/clk-gate.c | 23 +- drivers/clk/mediatek/clk-gate.h | 7 +- drivers/clk/mediatek/clk-mt2701-aud.c | 31 +- drivers/clk/mediatek/clk-mt2701-eth.c | 36 +- drivers/clk/mediatek/clk-mt2701-g3d.c | 56 +- drivers/clk/mediatek/clk-mt2701-hif.c | 38 +- drivers/clk/mediatek/clk-mt2701-mm.c | 4 +- drivers/clk/mediatek/clk-mt2701.c | 24 +- drivers/clk/mediatek/clk-mt2712-mm.c | 4 +- drivers/clk/mediatek/clk-mt2712.c | 99 +- drivers/clk/mediatek/clk-mt6765.c | 13 +- drivers/clk/mediatek/clk-mt6779-mm.c | 4 +- drivers/clk/mediatek/clk-mt6779.c | 59 +- drivers/clk/mediatek/clk-mt6795-infracfg.c | 6 +- drivers/clk/mediatek/clk-mt6795-mm.c | 3 +- drivers/clk/mediatek/clk-mt6795-pericfg.c | 6 +- drivers/clk/mediatek/clk-mt6795-topckgen.c | 84 +- drivers/clk/mediatek/clk-mt6797-mm.c | 4 +- drivers/clk/mediatek/clk-mt6797.c | 7 +- drivers/clk/mediatek/clk-mt7622-aud.c | 54 +- drivers/clk/mediatek/clk-mt7622-eth.c | 82 +- drivers/clk/mediatek/clk-mt7622-hif.c | 85 +- drivers/clk/mediatek/clk-mt7622.c | 26 +- drivers/clk/mediatek/clk-mt7629-eth.c | 7 +- drivers/clk/mediatek/clk-mt7629-hif.c | 85 +- drivers/clk/mediatek/clk-mt7629.c | 22 +- drivers/clk/mediatek/clk-mt7986-eth.c | 10 +- drivers/clk/mediatek/clk-mt7986-infracfg.c | 7 +- drivers/clk/mediatek/clk-mt7986-topckgen.c | 100 +- drivers/clk/mediatek/clk-mt8135.c | 18 +- drivers/clk/mediatek/clk-mt8167-aud.c | 2 +- drivers/clk/mediatek/clk-mt8167-img.c | 2 +- drivers/clk/mediatek/clk-mt8167-mfgcfg.c | 2 +- drivers/clk/mediatek/clk-mt8167-mm.c | 4 +- drivers/clk/mediatek/clk-mt8167-vdec.c | 3 +- drivers/clk/mediatek/clk-mt8167.c | 12 +- drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 157 +++ drivers/clk/mediatek/clk-mt8173-img.c | 55 + drivers/clk/mediatek/clk-mt8173-infracfg.c | 155 +++ drivers/clk/mediatek/clk-mt8173-mm.c | 22 +- drivers/clk/mediatek/clk-mt8173-pericfg.c | 122 ++ drivers/clk/mediatek/clk-mt8173-topckgen.c | 653 ++++++++++ drivers/clk/mediatek/clk-mt8173-vdecsys.c | 57 + drivers/clk/mediatek/clk-mt8173-vencsys.c | 64 + drivers/clk/mediatek/clk-mt8173.c | 1125 ------------------ drivers/clk/mediatek/clk-mt8183-audio.c | 27 +- drivers/clk/mediatek/clk-mt8183-mm.c | 4 +- drivers/clk/mediatek/clk-mt8183.c | 130 +- drivers/clk/mediatek/clk-mt8186-mcu.c | 3 +- drivers/clk/mediatek/clk-mt8186-mm.c | 3 +- drivers/clk/mediatek/clk-mt8186-topckgen.c | 112 +- drivers/clk/mediatek/clk-mt8192-aud.c | 30 +- drivers/clk/mediatek/clk-mt8192-mm.c | 3 +- drivers/clk/mediatek/clk-mt8192.c | 182 +-- drivers/clk/mediatek/clk-mt8195-apmixedsys.c | 3 +- drivers/clk/mediatek/clk-mt8195-topckgen.c | 9 +- drivers/clk/mediatek/clk-mt8195-vdo0.c | 3 +- drivers/clk/mediatek/clk-mt8195-vdo1.c | 3 +- drivers/clk/mediatek/clk-mt8365-mm.c | 5 +- drivers/clk/mediatek/clk-mt8365.c | 14 +- drivers/clk/mediatek/clk-mt8516-aud.c | 2 +- drivers/clk/mediatek/clk-mt8516.c | 12 +- drivers/clk/mediatek/clk-mtk.c | 136 ++- drivers/clk/mediatek/clk-mtk.h | 35 +- drivers/clk/mediatek/clk-mux.c | 14 +- drivers/clk/mediatek/clk-mux.h | 3 +- 70 files changed, 2041 insertions(+), 2179 deletions(-) create mode 100644 drivers/clk/mediatek/clk-mt8173-apmixedsys.c create mode 100644 drivers/clk/mediatek/clk-mt8173-img.c create mode 100644 drivers/clk/mediatek/clk-mt8173-infracfg.c create mode 100644 drivers/clk/mediatek/clk-mt8173-pericfg.c create mode 100644 drivers/clk/mediatek/clk-mt8173-topckgen.c create mode 100644 drivers/clk/mediatek/clk-mt8173-vdecsys.c create mode 100644 drivers/clk/mediatek/clk-mt8173-vencsys.c delete mode 100644 drivers/clk/mediatek/clk-mt8173.c