From patchwork Thu Jan 19 11:28:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 4230 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp273370wrn; Thu, 19 Jan 2023 03:29:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXvRQntsue5oaV/0do2YkyKPysLpplpSWpD5mbocJSIqZvYa4E1VT1FihpKYbyh6QyoS42cJ X-Received: by 2002:a17:907:98cc:b0:871:3f83:1bc5 with SMTP id kd12-20020a17090798cc00b008713f831bc5mr10474793ejc.14.1674127795676; Thu, 19 Jan 2023 03:29:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674127795; cv=none; d=google.com; s=arc-20160816; b=Yu5bpZACMWtNaY/F1h+EPtd2v67XYA1PVptrwN0cooth/JMyiJSAUXqgHvi32fALDe nnkfocoYSB6xQ7DOaqXBneGvI0Oz8SqHktEn0PWtIBjNwVXDupjTAXj+P+J9c0Tbegen 4sVwtYIQ40IfIfvhX4dyN549Rm3z8snLXyPIYOvsZiNAxG7dQfID/6chaiVY//ld999T 2rtgdpYd9v5CGXwCe4Xx9+bHi4t6OK+yleeALHP48M3DNJ47fAfXQ+ZtPPsYCxPhVFrR 0UR38BuZE6myZ7rg1K7Z1xR7ZuMaECBwwV1WxxYiU7nMUAaEyXfyoP026B9LUiecfY6w pUEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yiAGKLpvi523+rEpZtd14F9kmeWEbgLCZAyPvQjQfyY=; b=O1hdHjs7sPJeSqD9XeEUndJQMZpFnM+1YytFRz2RLVRs2LhBhm0eqg2cu7XB+6vV51 jrwwCec5eEu/tGn7J4fHbqbnhJPZgF9E5eBb8pWMAi2iQ3yIRUF8VfbpgJOmdXtemfKJ VAoDFDfvfRgSyazMi5a0aOYMsR9Q2QmoeYVCA5DP8GtNo+cicKoZiiZ3uCCr4tEi6tXV disyYDVhwENMOmvnKLvNMfKdhf+1uvK45m846WEA2iXjJaKzZ2YmG8bf5HdNPehCH1Jv jfD6kbgfCZNZZKlcJUWDR9x9t+VbcAqcuVcktccnXjdfOqz9k1+MKWngWx7ArVwdqaSh M9QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=BVreKkIZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz2-20020a1709072ce200b0085f373499eesi3442992ejc.578.2023.01.19.03.29.31; Thu, 19 Jan 2023 03:29:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=BVreKkIZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230206AbjASL3C (ORCPT + 99 others); Thu, 19 Jan 2023 06:29:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbjASL27 (ORCPT ); Thu, 19 Jan 2023 06:28:59 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EFC770C4F; Thu, 19 Jan 2023 03:28:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1674127737; x=1705663737; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=DcMuBWFFR6Z1Zscg6mz2qkHW2S/lYlqIKkXOk0ulIV4=; b=BVreKkIZ3WqzOsfdVsKsXBOvAoQTehiTooO63KOy9QMSZ1RND6h1YtR3 DexLzTEJ+npSvd51i3BfmaXnP+LK086snmxalx+o92WafzaHRZknzNktr 4tnE7bXLF/F5++DxuLGXNRzQ6vuEomBRDkFIwEKFoFrbH9Oi6UeuPart/ BkzuwgO9v+aSr8Tl++I/oXPlWq1BETLhjcSkWkouulIOpc21APAln1ui5 vkAv1dKYKrkhXw8l+EGuZR6+VzmGRGp3PyuaVEUNYAgC2XitsfWUm3u9k KSBSeFeRtTSC/o4uzmAcDLjqKBWUTJ39thfEEJ+Sb8qlmq2vU63ihllBo w==; X-IronPort-AV: E=Sophos;i="5.97,228,1669100400"; d="scan'208";a="208443525" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 19 Jan 2023 04:28:56 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 19 Jan 2023 04:28:55 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Thu, 19 Jan 2023 04:28:52 -0700 From: shravan kumar To: , , CC: , , "shravan kumar" , Jacopo Mondi , Sakari Ailus Subject: [PATCH v10 0/5] media: i2c: imx334: support lower bandwidth mode Date: Thu, 19 Jan 2023 16:58:43 +0530 Message-ID: <20230119112848.3523273-1-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755450227315860605?= X-GMAIL-MSGID: =?utf-8?q?1755450227315860605?= From: Shravan Chippa Hi This patch series is for imx334 sensor driver support for lower bandwidth Some platforms may not be capable of supporting the bandwidth required for 12 bit or 3840x2160@60 resolutions. Add support for dynamically selecting 10 bit and 1920x1080@30 resolutions while leaving the existing configuration as default V9 -> V10 Added new dt-binding patch added support for handling multiple link-frequncy minor changes on coding style V8 -> V9 -Updated all array values with samall later to get unifamity in mode array values -corrected hblank_min, hbalank, pix_clk for 1920x1080@30 updated according to link frequency -corrected mutex use for imx334_get_format_code function -corrected the fmt->format.code value assinment -in function imx334_get_format_code variable "i" value comparision corrected V7 -> V8 -patch drop "mimx334-odify-link-frequency" as per the commnets linkfrquncy will be half of the line bandwidth -changed 1920x1080@30 mode link frequency from (891000000Mbps) to (445500000Mbps). linkfrquncy will be half of the line bandwidth V6 -> V7 Reloved: kernel test robot warning "drivers/media/i2c/imx334.c:767:15: warning: unused variable 'i' " V5 -> V6 -Drop the dt-binding patch -Optimize the code to avoid duplicating the lines -Added proper mutex while imx334_mbus_codes array -Modified Function __v4l2_ctrl_modify_range arguments as per the review commants -Added hblank dummy set ctrl -Removed Redundant comment -corrected code alignment -All commit msgs are re-written V4 -> V5 -Added 5 more patchs as per the review comments witch has below updates -Updated 1782000000Mbps link frequency for 3840x2160@60 as per the mode values -Updated 1782000000Mbps link frequency in dt-bindings also -Updated 3840x2160@60 mode array with default(reset) values -Updated hblank __v4l2_ctrl_s_ctrl() to __v4l2_ctrl_modify_range() Suggested-by: Jacopo Mondi -Current mode update only when we try to set V4L2_SUBDEV_FORMAT_ACTIVE -Added link frequency (891000000Mbps) and pixel rate (74250000) to 1920x1080@30 mode Suggested-by: Sakari Ailus -Updated commit message V3 -> V4 - Make the 12 bit and 3840x2160 as default - Set bus code SRGGB12 if set format fails V2 -> V3 - Fixed the warning reported by kernel test robot V1 -> V2 - Addressed the review comment given by Jacopo Mondi, Which has bug in imx334_enum_frame_size() loop function, - Renamed array codes[] to imx334_mbus_codes[] Shravan Chippa (5): media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range media: i2c: imx334: add missing reset values for mode 3840x2160_regs[] media: i2c: imx334: support lower bandwidth mode dt-bindings: media: i2c: imx334 add new link_freq media: i2c: imx334: update pixel and link frequency .../bindings/media/i2c/sony,imx334.yaml | 2 +- drivers/media/i2c/imx334.c | 361 ++++++++++++++++-- 2 files changed, 324 insertions(+), 39 deletions(-)