From patchwork Wed Jan 18 11:58:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 4169 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2313373wrn; Wed, 18 Jan 2023 04:40:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXsBMH52DTTA1qabirBfMET8cuJPTQhPw4XbjvVQffTuO4gicKzTS6w+oS9Xy11fw27erxcO X-Received: by 2002:a17:903:2306:b0:194:6e8d:89ac with SMTP id d6-20020a170903230600b001946e8d89acmr10418183plh.24.1674045652606; Wed, 18 Jan 2023 04:40:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674045652; cv=none; d=google.com; s=arc-20160816; b=CSbfRb33pZeZHl/cmF4zU1OhTJ6A9n3FO8QjNNwQAfONgH6tbxF4KCbZ/ploJ+ODV2 4j6ypnAA9Tz0nMpCri3ktCOd8m2Kg7pZ5489zm215RoBuDjtOJ47w6OtGG+rH+9CHNDP iVxmoLx11eNmjy7sRQE7qnHW63sjhfB6kOc8YhstUCLDvvseoCWtiLfnWa6VDGzVGj2r hcrHuKM/HcojkteD4p38c6de5OuA4/Hx1faKSZR3K9K28NU0kazEATGsRhtimLdbgx72 BuKXXn52fWTf6YHSm/ypj482V5rrNgxgh+qqAMIhyPwSLR65coKMHarjJjFAvxP15VJz /7rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kzMIpMI79UF0+OpcHUH6+6IlBed9I+CF2lh/cnzzvOw=; b=uyiB0pz/A+D61jzcFuCvChnZWQjG65YMhP5xh9CwfQDj+umuZeyHtdYRu5N4r198PG UWinb5Zfdjm6mclUULbFr0k2CzdOaO3ZBvJvpFQH2P7kA+5A8t6z7OgJs8Sji3K4ur2B VvZjtfc+rC8WqPXYV/Ne3U3ejmUPqDK0p+40LKbWdS5Ha0nrGbBxaTHE8sH8yWNXDYth kMgVPm5zX3pVe9hpZG9G1P6B+YxTCcgIGLyOCr031PSL3KRbOo9PFYvSuM867ewiyt8S V1jhaMcAe4S23FxESsLRq03q1I1+jaHS9i3lAVU2zMoosI7lPle8FVhP7bBxeYKWWlGe SZ4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=mr0XK0dJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a170902ea0900b00192f6c63f54si38884472plg.502.2023.01.18.04.40.39; Wed, 18 Jan 2023 04:40:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=mr0XK0dJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230090AbjARMfW (ORCPT + 99 others); Wed, 18 Jan 2023 07:35:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230495AbjARMe7 (ORCPT ); Wed, 18 Jan 2023 07:34:59 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2FCE298F1; Wed, 18 Jan 2023 03:58:22 -0800 (PST) Received: from umang.jainideasonboard.com (unknown [103.86.18.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 408671643; Wed, 18 Jan 2023 12:58:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1674043099; bh=4ZkEehY0EKcMSSK/FWZM4yQ45U26CQ/uPHxtUY8/+Kw=; h=From:To:Cc:Subject:Date:From; b=mr0XK0dJNxcu3fFvP7C+BBGG9i618Wp2a6bHZ4j0KZhNxdYBGNuju4tgCE/dVaS5x vPradXpHtzLbV0a8YcUOCmv/JXCNWzYeUqGHYLkRfxp+CZoi9WUk3T7oNYeY+3lL// Zyx45aew3KRMeYAPPkqHCT1swWhfj2xxzQgXBMJw= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [RFC PATCH 0/4] Drop custom logging Date: Wed, 18 Jan 2023 17:28:06 +0530 Message-Id: <20230118115810.21979-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755364094442285642?= X-GMAIL-MSGID: =?utf-8?q?1755364094442285642?= Drop custom logging from the vchiq interface. Mostly of them are replaced with dev_dbg and friends and/or pr_info and friends. The debugfs log levels (in 4/4) are mapped to kernel logs levels (coming from include/linux/kern_levels.h) Would like some thoughts on it as I am not sure (hence marking this is RFC) From drivers/staging/vc04_services/interface/TODO: """ * Cleanup logging mechanism The driver should probably be using the standard kernel logging mechanisms such as dev_info, dev_dbg, and friends. """ Umang Jain (4): staging: vc04_services: vchiq_core: Drop custom logging staging: vc04_services: vchiq_arm: Drop custom logging staging: vc04_services: Drop custom logging staging: vc04_services: Drop remnants of custom logging .../interface/vchiq_arm/vchiq_arm.c | 151 +++--- .../interface/vchiq_arm/vchiq_connected.c | 5 +- .../interface/vchiq_arm/vchiq_core.c | 479 ++++++++---------- .../interface/vchiq_arm/vchiq_core.h | 39 -- .../interface/vchiq_arm/vchiq_debugfs.c | 26 +- .../interface/vchiq_arm/vchiq_dev.c | 78 ++- 6 files changed, 329 insertions(+), 449 deletions(-)