mbox series

[0/2] arm64: dts: (imx8mm|imx8mp)-verdin-dev: Do not include dahlia dtsi

Message ID 20230118105251.6035-1-dev@pschenker.ch
Headers
Series arm64: dts: (imx8mm|imx8mp)-verdin-dev: Do not include dahlia dtsi |

Message

Philippe Schenker Jan. 18, 2023, 10:52 a.m. UTC 
  From: Philippe Schenker <philippe.schenker@toradex.com>


We so far included the Dahlia device-tree in the development board
devicetree in order to try to minimize code duplication.

This mainly gets rid of ''status = "okay"' lines. Plus we saw that some
settings in the audio-codec of verdin-imx8mm are inherited that are
wrong for the development board. Those did also lead to the DT Schema
checker to fail on multiple settings.

We decided to remove this include in order to get the audio-codec
settings correct and make the DT Schema checker return less warnings.
This introduces some code duplication which we consider being mostly
only configuration of the actual development/dahlia boards.

This series of two patches removes the include for both Verdin boards we
have at the moment.

This issue was spotted by Rob Herring. [1]

[1] https://lore.kernel.org/all/167182349408.373865.10339766752503211557.robh@kernel.org/


Philippe Schenker (2):
  arm64: dts: imx8mm-verdin-dev: Do not include dahlia dtsi
  arm64: dts: imx8mp-verdin-dev: Do not include dahlia dtsi

 .../boot/dts/freescale/imx8mm-verdin-dev.dtsi |  96 ++++++++++++++-
 .../boot/dts/freescale/imx8mp-verdin-dev.dtsi | 116 +++++++++++++++++-
 2 files changed, 208 insertions(+), 4 deletions(-)

Comments

Shawn Guo Jan. 26, 2023, 8:06 a.m. UTC | #1 
On Wed, Jan 18, 2023 at 11:52:49AM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> 
> We so far included the Dahlia device-tree in the development board
> devicetree in order to try to minimize code duplication.
> 
> This mainly gets rid of ''status = "okay"' lines. Plus we saw that some
> settings in the audio-codec of verdin-imx8mm are inherited that are
> wrong for the development board. Those did also lead to the DT Schema
> checker to fail on multiple settings.
> 
> We decided to remove this include in order to get the audio-codec
> settings correct and make the DT Schema checker return less warnings.
> This introduces some code duplication which we consider being mostly
> only configuration of the actual development/dahlia boards.
> 
> This series of two patches removes the include for both Verdin boards we
> have at the moment.
> 
> This issue was spotted by Rob Herring. [1]
> 
> [1] https://lore.kernel.org/all/167182349408.373865.10339766752503211557.robh@kernel.org/
> 
> 
> Philippe Schenker (2):
>   arm64: dts: imx8mm-verdin-dev: Do not include dahlia dtsi
>   arm64: dts: imx8mp-verdin-dev: Do not include dahlia dtsi

Applied both, thanks!