[v6,0/6] add support for MT8195 VPPSYS on MMSYS and MUTEX

  Changes since v5:
- Depend on :
  [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=713031

Changes since v4:
- Rebase on linux-next.
- Remove MMSYS fallback compatible.
- Migrate MT8195 VPPSYS0/1 from clock to mtk-mmsys driver.

Changes since v3:
- Rebase on linux-next.

Changes since v2:
- Depend on :
  [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
- Split dts settings into two patches based on belonging to MMSYS or MUTEX.

Changes since v1:
- Depend on :
  [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
- Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding file.
- Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check.
- Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config() to
  mtk_mmsys_vpp_rsz_merge_config() and mtk_mmsys_vpp_rsz_dcm_config().
- Clean up mtk_mmsys_vpp_rsz_dcm_config().
- Add a comment to mtk_mutex_write_mod() and clean it up for use in more
  than 32 mods.

Hi,

This series add support for MT8195's two VPPSYS(Video Processor Pipe Subsystem),
under which there will be corresponding MMSYS and MUTEX settings that
need to be configured.

Moudy Ho (1):
  arm64: dts: mediatek: mt8195: add MUTEX configuration for VPPSYS

Roy-CW.Yeh (5):
  dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS
  arm64: dts: mediatek: mt8195: add MMSYS configuration for VPPSYS
  soc: mediatek: mmsys: add config api for RSZ switching and DCM
  soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1
  soc: mediatek: mutex: support MT8195 VPPSYS

 .../bindings/soc/mediatek/mediatek,mutex.yaml |   1 +
 arch/arm64/boot/dts/mediatek/mt8195.dtsi      |  26 +++-
 drivers/soc/mediatek/mt8195-mmsys.h           |  13 ++
 drivers/soc/mediatek/mtk-mmsys.c              |  42 ++++++
 drivers/soc/mediatek/mtk-mutex.c              | 135 +++++++++++++++++-
 include/linux/soc/mediatek/mtk-mmsys.h        |   4 +
 include/linux/soc/mediatek/mtk-mutex.h        |  35 +++++
 7 files changed, 245 insertions(+), 11 deletions(-)
  

Whole series queued for the next merge window.

Thanks!

On 18/01/2023 04:21, Moudy Ho wrote:
> Changes since v5:
> - Depend on :
>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=713031
> 
> Changes since v4:
> - Rebase on linux-next.
> - Remove MMSYS fallback compatible.
> - Migrate MT8195 VPPSYS0/1 from clock to mtk-mmsys driver.
> 
> Changes since v3:
> - Rebase on linux-next.
> 
> Changes since v2:
> - Depend on :
>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
> - Split dts settings into two patches based on belonging to MMSYS or MUTEX.
> 
> Changes since v1:
> - Depend on :
>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
> - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding file.
> - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check.
> - Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config() to
>    mtk_mmsys_vpp_rsz_merge_config() and mtk_mmsys_vpp_rsz_dcm_config().
> - Clean up mtk_mmsys_vpp_rsz_dcm_config().
> - Add a comment to mtk_mutex_write_mod() and clean it up for use in more
>    than 32 mods.
> 
> Hi,
> 
> This series add support for MT8195's two VPPSYS(Video Processor Pipe Subsystem),
> under which there will be corresponding MMSYS and MUTEX settings that
> need to be configured.
> 
> Moudy Ho (1):
>    arm64: dts: mediatek: mt8195: add MUTEX configuration for VPPSYS
> 
> Roy-CW.Yeh (5):
>    dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS
>    arm64: dts: mediatek: mt8195: add MMSYS configuration for VPPSYS
>    soc: mediatek: mmsys: add config api for RSZ switching and DCM
>    soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1
>    soc: mediatek: mutex: support MT8195 VPPSYS
> 
>   .../bindings/soc/mediatek/mediatek,mutex.yaml |   1 +
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi      |  26 +++-
>   drivers/soc/mediatek/mt8195-mmsys.h           |  13 ++
>   drivers/soc/mediatek/mtk-mmsys.c              |  42 ++++++
>   drivers/soc/mediatek/mtk-mutex.c              | 135 +++++++++++++++++-
>   include/linux/soc/mediatek/mtk-mmsys.h        |   4 +
>   include/linux/soc/mediatek/mtk-mutex.h        |  35 +++++
>   7 files changed, 245 insertions(+), 11 deletions(-)
>
  

On 02/02/2023 13:40, Matthias Brugger wrote:
> Whole series queued for the next merge window.
> 

I encountered some compile errors, so I deleted the whole series, please fix and 
resubmit. Thanks

drivers/soc/mediatek/mtk-mmsys.c: In function 'mtk_mmsys_vpp_rsz_merge_config':
drivers/soc/mediatek/mtk-mmsys.c:261:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   261 |         mtk_mmsys_update_bits(dev_get_drvdata(dev), reg, ~0, enable);
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c: In function 'mtk_mmsys_vpp_rsz_dcm_config':
drivers/soc/mediatek/mtk-mmsys.c:270:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   270 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:273:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   273 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:278:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   278 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:281:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   281 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~

Regards,
Matthias

> Thanks!
> 
> On 18/01/2023 04:21, Moudy Ho wrote:
>> Changes since v5:
>> - Depend on :
>>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=713031
>>
>> Changes since v4:
>> - Rebase on linux-next.
>> - Remove MMSYS fallback compatible.
>> - Migrate MT8195 VPPSYS0/1 from clock to mtk-mmsys driver.
>>
>> Changes since v3:
>> - Rebase on linux-next.
>>
>> Changes since v2:
>> - Depend on :
>>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
>> - Split dts settings into two patches based on belonging to MMSYS or MUTEX.
>>
>> Changes since v1:
>> - Depend on :
>>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
>> - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding file.
>> - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check.
>> - Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config() to
>>    mtk_mmsys_vpp_rsz_merge_config() and mtk_mmsys_vpp_rsz_dcm_config().
>> - Clean up mtk_mmsys_vpp_rsz_dcm_config().
>> - Add a comment to mtk_mutex_write_mod() and clean it up for use in more
>>    than 32 mods.
>>
>> Hi,
>>
>> This series add support for MT8195's two VPPSYS(Video Processor Pipe Subsystem),
>> under which there will be corresponding MMSYS and MUTEX settings that
>> need to be configured.
>>
>> Moudy Ho (1):
>>    arm64: dts: mediatek: mt8195: add MUTEX configuration for VPPSYS
>>
>> Roy-CW.Yeh (5):
>>    dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS
>>    arm64: dts: mediatek: mt8195: add MMSYS configuration for VPPSYS
>>    soc: mediatek: mmsys: add config api for RSZ switching and DCM
>>    soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1
>>    soc: mediatek: mutex: support MT8195 VPPSYS
>>
>>   .../bindings/soc/mediatek/mediatek,mutex.yaml |   1 +
>>   arch/arm64/boot/dts/mediatek/mt8195.dtsi      |  26 +++-
>>   drivers/soc/mediatek/mt8195-mmsys.h           |  13 ++
>>   drivers/soc/mediatek/mtk-mmsys.c              |  42 ++++++
>>   drivers/soc/mediatek/mtk-mutex.c              | 135 +++++++++++++++++-
>>   include/linux/soc/mediatek/mtk-mmsys.h        |   4 +
>>   include/linux/soc/mediatek/mtk-mutex.h        |  35 +++++
>>   7 files changed, 245 insertions(+), 11 deletions(-)
>>
  

On Thu, 2023-02-02 at 16:01 +0100, Matthias Brugger wrote:
> 
> On 02/02/2023 13:40, Matthias Brugger wrote:
> > Whole series queued for the next merge window.
> > 
> 
> I encountered some compile errors, so I deleted the whole series,
> please fix and 
> resubmit. Thanks
> 
> drivers/soc/mediatek/mtk-mmsys.c: In function
> 'mtk_mmsys_vpp_rsz_merge_config':
> drivers/soc/mediatek/mtk-mmsys.c:261:9: error: too few arguments to
> function 
> 'mtk_mmsys_update_bits'
>    261 |         mtk_mmsys_update_bits(dev_get_drvdata(dev), reg, ~0,
> enable);
>        |         ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
>    129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys,
> u32 offset, 
> u32 mask, u32 val,
>        |             ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c: In function
> 'mtk_mmsys_vpp_rsz_dcm_config':
> drivers/soc/mediatek/mtk-mmsys.c:270:9: error: too few arguments to
> function 
> 'mtk_mmsys_update_bits'
>    270 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
>        |         ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
>    129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys,
> u32 offset, 
> u32 mask, u32 val,
>        |             ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c:273:9: error: too few arguments to
> function 
> 'mtk_mmsys_update_bits'
>    273 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
>        |         ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
>    129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys,
> u32 offset, 
> u32 mask, u32 val,
>        |             ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c:278:9: error: too few arguments to
> function 
> 'mtk_mmsys_update_bits'
>    278 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
>        |         ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
>    129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys,
> u32 offset, 
> u32 mask, u32 val,
>        |             ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c:281:9: error: too few arguments to
> function 
> 'mtk_mmsys_update_bits'
>    281 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
>        |         ^~~~~~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
>    129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys,
> u32 offset, 
> u32 mask, u32 val,
>        |             ^~~~~~~~~~~~~~~~~~~~~
> 
> Regards,
> Matthias
> 

Hi Matthias,

Sorry for the inconvenience, the v7 with corrections has been sent.
https://patchwork.kernel.org/project/linux-mediatek/list/?series=719050

Regards,
Moudy

> > Thanks!
> > 
> > On 18/01/2023 04:21, Moudy Ho wrote:
> > > Changes since v5:
> > > - Depend on :
> > >    [1] 
> > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=713031__;!!CTRNKA9wMg0ARbw!hudgud9YRhtPxf6iEZ9MRM6C9XVGOIPS8Uvzc-VKoQGZDgBBCf-XqwSoBK1Fgqwh59DUX3kUcsaDM6OfmMiOcLk$ 
> > >  
> > > 
> > > Changes since v4:
> > > - Rebase on linux-next.
> > > - Remove MMSYS fallback compatible.
> > > - Migrate MT8195 VPPSYS0/1 from clock to mtk-mmsys driver.
> > > 
> > > Changes since v3:
> > > - Rebase on linux-next.
> > > 
> > > Changes since v2:
> > > - Depend on :
> > >    [1] 
> > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097__;!!CTRNKA9wMg0ARbw!hudgud9YRhtPxf6iEZ9MRM6C9XVGOIPS8Uvzc-VKoQGZDgBBCf-XqwSoBK1Fgqwh59DUX3kUcsaDM6OfprEEPgw$ 
> > >  
> > > - Split dts settings into two patches based on belonging to MMSYS
> > > or MUTEX.
> > > 
> > > Changes since v1:
> > > - Depend on :
> > >    [1] 
> > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097__;!!CTRNKA9wMg0ARbw!hudgud9YRhtPxf6iEZ9MRM6C9XVGOIPS8Uvzc-VKoQGZDgBBCf-XqwSoBK1Fgqwh59DUX3kUcsaDM6OfprEEPgw$ 
> > >  
> > > - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding
> > > file.
> > > - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check.
> > > - Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config()
> > > to
> > >    mtk_mmsys_vpp_rsz_merge_config() and
> > > mtk_mmsys_vpp_rsz_dcm_config().
> > > - Clean up mtk_mmsys_vpp_rsz_dcm_config().
> > > - Add a comment to mtk_mutex_write_mod() and clean it up for use
> > > in more
> > >    than 32 mods.
> > > 
> > > Hi,
> > > 
> > > This series add support for MT8195's two VPPSYS(Video Processor
> > > Pipe Subsystem),
> > > under which there will be corresponding MMSYS and MUTEX settings
> > > that
> > > need to be configured.
> > > 
> > > Moudy Ho (1):
> > >    arm64: dts: mediatek: mt8195: add MUTEX configuration for
> > > VPPSYS
> > > 
> > > Roy-CW.Yeh (5):
> > >    dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS
> > >    arm64: dts: mediatek: mt8195: add MMSYS configuration for
> > > VPPSYS
> > >    soc: mediatek: mmsys: add config api for RSZ switching and DCM
> > >    soc: mediatek: mutex: Add mtk_mutex_set_mod support to set
> > > MOD1
> > >    soc: mediatek: mutex: support MT8195 VPPSYS
> > > 
> > >   .../bindings/soc/mediatek/mediatek,mutex.yaml |   1 +
> > >   arch/arm64/boot/dts/mediatek/mt8195.dtsi      |  26 +++-
> > >   drivers/soc/mediatek/mt8195-mmsys.h           |  13 ++
> > >   drivers/soc/mediatek/mtk-mmsys.c              |  42 ++++++
> > >   drivers/soc/mediatek/mtk-mutex.c              | 135
> > > +++++++++++++++++-
> > >   include/linux/soc/mediatek/mtk-mmsys.h        |   4 +
> > >   include/linux/soc/mediatek/mtk-mutex.h        |  35 +++++
> > >   7 files changed, 245 insertions(+), 11 deletions(-)
> > >