mbox series

[net-next:,v7,0/7] dsa: lan9303: Move to PHYLINK

Message ID 20230117205703.25960-1-jerry.ray@microchip.com
Headers
Series dsa: lan9303: Move to PHYLINK |

Message

Jerry Ray Jan. 17, 2023, 8:56 p.m. UTC 
  This patch series moves the lan9303 driver to use the phylink
api away from phylib.

Migrating to phylink means removing the .adjust_link api. The
functionality from the adjust_link is moved to the phylink_mac_link_up
api.  The code being removed only affected the cpu port.  The other
ports on the LAN9303 do not need anything from the phylink_mac_link_up
api.

Patches:
 0001 - Whitespace only change aligning the dsa_switch_ops members.
	No code changes.
 0002 - Moves the Turbo bit initialization out of the adjust_link api and
	places it in a driver initialization execution path. It only needs
	to be initialized once, it is never changed, and it is not a
	per-port flag.
 0003 - Adds exception handling logic in the extremely unlikely event that
	the read of the device fails.
 0004 - Performance optimization that skips a slow register write if there
	is no need to perform it.
 0005 - Change the way we identify the xMII port as phydev will be NULL
	when this logic is moved into phylink_mac_link_up.
 0006 - Removes adjust_link and begins using the phylink dsa_switch_ops
	apis.
 0007 - Adds XMII port flow control settings in the phylink_mac_link_up()
	api while cleaning up the ANEG / speed / duplex implementation.
---
v6->v7:
  - Moved the initialization of the Turbo bit into lan9303_setup().
  - Added a macro for determining is a port is an XMII port.
  - Added setting the XMII flow control in the phylink_mac_link_up() API.
  - removed unnecessary error handling and cleaned up the code flow in
    phylink_mac_link_up().
v5->v6:
  - Moved to using port number to identify xMII port for the LAN9303.
v4->v5:
  - Created prep patches to better show how things migrate.
  - cleaned up comments.
v3->v4:
  - Addressed whitespace issues as a separate patch.
  - Removed port_max_mtu api patch as it is unrelated to phylink migration.
  - Reworked the implementation to preserve the adjust_link functionality
    by including it in the phylink_mac_link_up api.
v2->v3:
  Added back in disabling Turbo Mode on the CPU MII interface.
  Removed the unnecessary clearing of the phy supported interfaces.
v1->v2:
  corrected the reported mtu size, removing ETH_HLEN and ETH_FCS_LEN

 drivers/net/dsa/lan9303-core.c | xx ++++++++++++--------
 1 file changed

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 20, 2023, 9 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 17 Jan 2023 14:56:56 -0600 you wrote:
> This patch series moves the lan9303 driver to use the phylink
> api away from phylib.
> 
> Migrating to phylink means removing the .adjust_link api. The
> functionality from the adjust_link is moved to the phylink_mac_link_up
> api.  The code being removed only affected the cpu port.  The other
> ports on the LAN9303 do not need anything from the phylink_mac_link_up
> api.
> 
> [...]

Here is the summary with links:
  - [net-next:,v7,1/7] dsa: lan9303: align dsa_switch_ops members
    https://git.kernel.org/netdev/net-next/c/9755126dc038
  - [net-next:,v7,2/7] dsa: lan9303: move Turbo Mode bit init
    https://git.kernel.org/netdev/net-next/c/1bcb5df81e4b
  - [net-next:,v7,3/7] dsa: lan9303: Add exception logic for read failure
    https://git.kernel.org/netdev/net-next/c/601f574a1b44
  - [net-next:,v7,4/7] dsa: lan9303: write reg only if necessary
    https://git.kernel.org/netdev/net-next/c/de375aa860fb
  - [net-next:,v7,5/7] dsa: lan9303: Port 0 is xMII port
    https://git.kernel.org/netdev/net-next/c/56e23d91bcfd
  - [net-next:,v7,6/7] dsa: lan9303: Migrate to PHYLINK
    https://git.kernel.org/netdev/net-next/c/332bc552a402
  - [net-next:,v7,7/7] dsa: lan9303: Add flow ctrl in link_up
    https://git.kernel.org/netdev/net-next/c/87523986570e

You are awesome, thank you!