mbox series

[v2,0/4] Minor cleanup in msm8916 dts files

Message ID 20230116145053.1412501-1-nikita@trvn.ru
Headers
Series Minor cleanup in msm8916 dts files |

Message

Nikita Travkin Jan. 16, 2023, 2:50 p.m. UTC 
  This series performs some minor cleanup on msm8916/apq8016 files to
bring them in line with the current standard and be closer to the new
submissions.

The series is separated into commits by each specific change made across
all files and these commits should not cause any functional difference.

Changes in v2:
- Rebase on top of newly applied upstream patches

Nikita Travkin (4):
  arm64: dts: qcom: msm/apq8x16-*: Move status property last
  arm64: dts: qcom: msm/apq8x16-*: Reorder the pinctrl properties.
  arm64: dts: qcom: msm/apq8x16-*: Drop empty lines in pinctrl states
  arm64: dts: qcom: msm/apq8x16-*: Reorder some regulator properties

 arch/arm64/boot/dts/qcom/apq8016-sbc.dts      | 78 +++++++--------
 .../boot/dts/qcom/msm8916-acer-a1-724.dts     | 15 ++-
 .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 46 ++++-----
 .../arm64/boot/dts/qcom/msm8916-asus-z00l.dts | 34 +++----
 .../arm64/boot/dts/qcom/msm8916-huawei-g7.dts | 52 ++++------
 .../boot/dts/qcom/msm8916-longcheer-l8150.dts | 42 ++++----
 .../boot/dts/qcom/msm8916-longcheer-l8910.dts | 30 +++---
 arch/arm64/boot/dts/qcom/msm8916-pins.dtsi    | 96 +++++--------------
 .../qcom/msm8916-samsung-a2015-common.dtsi    | 64 +++++--------
 .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 11 +--
 .../boot/dts/qcom/msm8916-samsung-a5u-eur.dts |  5 +-
 .../qcom/msm8916-samsung-e2015-common.dtsi    |  5 +-
 .../dts/qcom/msm8916-samsung-grandmax.dts     |  3 +-
 .../boot/dts/qcom/msm8916-samsung-j5.dts      | 21 ++--
 .../dts/qcom/msm8916-samsung-serranove.dts    | 62 +++++-------
 .../dts/qcom/msm8916-wingtech-wt88047.dts     | 35 +++----
 arch/arm64/boot/dts/qcom/msm8916.dtsi         | 32 +++----
 17 files changed, 245 insertions(+), 386 deletions(-)

Comments

Bjorn Andersson Jan. 19, 2023, 3:34 a.m. UTC | #1 
On Mon, Jan 16, 2023 at 07:50:49PM +0500, Nikita Travkin wrote:
> This series performs some minor cleanup on msm8916/apq8016 files to
> bring them in line with the current standard and be closer to the new
> submissions.
> 
> The series is separated into commits by each specific change made across
> all files and these commits should not cause any functional difference.
> 
> Changes in v2:
> - Rebase on top of newly applied upstream patches
> 

The first patch looks pretty reasonable, but without documenting the
guidelines and tools to help others maintain the ordering this
unfortunately just moves things around arbitrarily.

Forgive me, but I will ignore this series until this is finalized and
documented.

Thanks,
Bjorn

> Nikita Travkin (4):
>   arm64: dts: qcom: msm/apq8x16-*: Move status property last
>   arm64: dts: qcom: msm/apq8x16-*: Reorder the pinctrl properties.
>   arm64: dts: qcom: msm/apq8x16-*: Drop empty lines in pinctrl states
>   arm64: dts: qcom: msm/apq8x16-*: Reorder some regulator properties
> 
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dts      | 78 +++++++--------
>  .../boot/dts/qcom/msm8916-acer-a1-724.dts     | 15 ++-
>  .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 46 ++++-----
>  .../arm64/boot/dts/qcom/msm8916-asus-z00l.dts | 34 +++----
>  .../arm64/boot/dts/qcom/msm8916-huawei-g7.dts | 52 ++++------
>  .../boot/dts/qcom/msm8916-longcheer-l8150.dts | 42 ++++----
>  .../boot/dts/qcom/msm8916-longcheer-l8910.dts | 30 +++---
>  arch/arm64/boot/dts/qcom/msm8916-pins.dtsi    | 96 +++++--------------
>  .../qcom/msm8916-samsung-a2015-common.dtsi    | 64 +++++--------
>  .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 11 +--
>  .../boot/dts/qcom/msm8916-samsung-a5u-eur.dts |  5 +-
>  .../qcom/msm8916-samsung-e2015-common.dtsi    |  5 +-
>  .../dts/qcom/msm8916-samsung-grandmax.dts     |  3 +-
>  .../boot/dts/qcom/msm8916-samsung-j5.dts      | 21 ++--
>  .../dts/qcom/msm8916-samsung-serranove.dts    | 62 +++++-------
>  .../dts/qcom/msm8916-wingtech-wt88047.dts     | 35 +++----
>  arch/arm64/boot/dts/qcom/msm8916.dtsi         | 32 +++----
>  17 files changed, 245 insertions(+), 386 deletions(-)
> 
> -- 
> 2.38.1
>
Konrad Dybcio Jan. 19, 2023, 11:10 a.m. UTC | #2 
On 19.01.2023 04:34, Bjorn Andersson wrote:
> On Mon, Jan 16, 2023 at 07:50:49PM +0500, Nikita Travkin wrote:
>> This series performs some minor cleanup on msm8916/apq8016 files to
>> bring them in line with the current standard and be closer to the new
>> submissions.
>>
>> The series is separated into commits by each specific change made across
>> all files and these commits should not cause any functional difference.
>>
>> Changes in v2:
>> - Rebase on top of newly applied upstream patches
>>
> 
> The first patch looks pretty reasonable, but without documenting the
> guidelines and tools to help others maintain the ordering this
> unfortunately just moves things around arbitrarily.
> 
> Forgive me, but I will ignore this series until this is finalized and
> documented.
Ack, the idea is good, but I rushed enforcing it.

Konrad
> 
> Thanks,
> Bjorn
> 
>> Nikita Travkin (4):
>>   arm64: dts: qcom: msm/apq8x16-*: Move status property last
>>   arm64: dts: qcom: msm/apq8x16-*: Reorder the pinctrl properties.
>>   arm64: dts: qcom: msm/apq8x16-*: Drop empty lines in pinctrl states
>>   arm64: dts: qcom: msm/apq8x16-*: Reorder some regulator properties
>>
>>  arch/arm64/boot/dts/qcom/apq8016-sbc.dts      | 78 +++++++--------
>>  .../boot/dts/qcom/msm8916-acer-a1-724.dts     | 15 ++-
>>  .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 46 ++++-----
>>  .../arm64/boot/dts/qcom/msm8916-asus-z00l.dts | 34 +++----
>>  .../arm64/boot/dts/qcom/msm8916-huawei-g7.dts | 52 ++++------
>>  .../boot/dts/qcom/msm8916-longcheer-l8150.dts | 42 ++++----
>>  .../boot/dts/qcom/msm8916-longcheer-l8910.dts | 30 +++---
>>  arch/arm64/boot/dts/qcom/msm8916-pins.dtsi    | 96 +++++--------------
>>  .../qcom/msm8916-samsung-a2015-common.dtsi    | 64 +++++--------
>>  .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 11 +--
>>  .../boot/dts/qcom/msm8916-samsung-a5u-eur.dts |  5 +-
>>  .../qcom/msm8916-samsung-e2015-common.dtsi    |  5 +-
>>  .../dts/qcom/msm8916-samsung-grandmax.dts     |  3 +-
>>  .../boot/dts/qcom/msm8916-samsung-j5.dts      | 21 ++--
>>  .../dts/qcom/msm8916-samsung-serranove.dts    | 62 +++++-------
>>  .../dts/qcom/msm8916-wingtech-wt88047.dts     | 35 +++----
>>  arch/arm64/boot/dts/qcom/msm8916.dtsi         | 32 +++----
>>  17 files changed, 245 insertions(+), 386 deletions(-)
>>
>> -- 
>> 2.38.1
>>