From patchwork Mon Jan 16 12:55:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 4063 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1183341wrn; Mon, 16 Jan 2023 05:11:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXt688yGer9xAMc+sscU3be5fsjFHmvZC/nbNy5gt6ysN/3GkYaVh+CtnYUHYAKwjiim+Syb X-Received: by 2002:a17:907:1c07:b0:86f:2819:2760 with SMTP id nc7-20020a1709071c0700b0086f28192760mr7100892ejc.41.1673874682241; Mon, 16 Jan 2023 05:11:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673874682; cv=none; d=google.com; s=arc-20160816; b=S0RKlk8BtVbVbal7Irofy2xIpeG1/NGsJZWB9dVXoIczoAktVRuf5L7y2vIC+sVUke acDKIzGZ4jZAlwcL3+p/Sz3iLFey026sEy313dlriw8QE+TdvSvjnQu6CjORrEtncB+M i1ELW+L+xQ8u0CACPCQnJsSA+qubgEv2VUhUcz/l9YZ4CqGsLe3to0thg28UJuIaWK95 UtBe7DLIDnm714LymFYJvsKw+JIuDARhFF0KJDh9ICH5nZWgi6sAX5bFL+EqEiyiXl0o BOpQIGyU43FQ9YJo1Wgz8JV7KyWzDmPHWEG52/yPUUuljtxRnr0yijT9ki2hSXZnH9Lu cKnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=oi2SopsYqvQOvZS8eGSs/vfUTqYgbbTRsA3aYNrX8os=; b=iYjIGFxJCJQfhxaX+vkWOuAVPztejw31X9rz8z0zpmD8rZMeq4N77orpdieLzejXlz b5Zx3xKDsavcf5EumG/kzTMC540dN/rCdHJJ448uetpIHRSfLYjo4R3/QVXU9Ktbe37z oLxyvy+l6d4C0mhm/o3h6RhONcKREvrjflEKkZHcRB/gWzq44Lmzcu0ai/9LdTaPEpf5 BKqABtsPwZDxbnRDe6xkbR02kbGaMO9olFoaEKryd/7b/+qN4lrnzMzSn43m1hg6cEcE cuHpi35FmMwTgTqgqs+Wf/6xNN+Dx+TLihn8dAyd64qUxn4/AMd+HZ+HVwXFC4DMN0Ng 4F2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=Fm0iMjxf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wv1-20020a170907080100b00787abcb1ce0si31398442ejb.679.2023.01.16.05.10.58; Mon, 16 Jan 2023 05:11:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=Fm0iMjxf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231278AbjAPM5L (ORCPT + 99 others); Mon, 16 Jan 2023 07:57:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbjAPM4o (ORCPT ); Mon, 16 Jan 2023 07:56:44 -0500 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56DDD1F4BA; Mon, 16 Jan 2023 04:55:37 -0800 (PST) Received: from mwalle01.sab.local (unknown [213.135.10.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 2F03E12F5; Mon, 16 Jan 2023 13:55:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1673873735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oi2SopsYqvQOvZS8eGSs/vfUTqYgbbTRsA3aYNrX8os=; b=Fm0iMjxfC0m13II6p3JkZ2RQjrcS+i2JomIL+v0Clxs+USFXV019fSnKd5b5tuXniSzMtk MU5fsC6tY6S4cmiH6XiEGu2rJiyj9VAK8gJ2bZ0pW1/16NMQxqbfZWRI1w7mh06fGBDpkE G+bcVtLKz0wwbvhZKHoLxxgWqeaMA3FR0DJQ70bI4dI/51u+EhA+bxvwR9Xr9L4NMD4BAX JhvjbzuVfDNt7zrYNj4d6TSK3oX6XbMxKStXuUSe+FlWj3T2nWm4vXY3BjI2YQKqZdYi2q AGmz80894DJ0vFmlBhqGerR6dxrOdJ3GYtY2VJ87OKuXLgxNFS7xFuEIR7Gm8g== From: Michael Walle Subject: [PATCH net-next 0/6] net: phy: Remove probe_capabilities Date: Mon, 16 Jan 2023 13:55:13 +0100 Message-Id: <20230116-net-next-remove-probe-capabilities-v1-0-5aa29738a023@walle.cc> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIADFJxWMC/zXNwQqDMBAE0F+RPXchMSK0v1J62MS1LtQkbIII4 r83FnqYwzDw5oDCKlzg0R2gvEmRFFuxtw7CQvHNKFPr0JveGWtHjFxb9orKa9oYsybPGCiTl4/U ZqFx02Ds4O5zGKFBngqjV4phuaiVSmW9hqw8y/57f8Ifhtd5fgEMJ2GZlwAAAA== To: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , Bryan Whitehead , UNGLinuxDriver@microchip.com, Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Joel Stanley , Andrew Jeffery Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-aspeed@lists.ozlabs.org, Andrew Lunn , Michael Walle X-Mailer: b4 0.11.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755184660685574630?= X-GMAIL-MSGID: =?utf-8?q?1755184818472259512?= With all the drivers which used .probe_capabilities converted to the new c45 MDIO access methods, we can now decide based upon these whether a bus driver supports c45 and we can get rid of the not widely used probe_capabilites. Unfortunately, due to a now broader support of c45 scans, this will trigger a bug on some boards with a (c22-only) Micrel PHY. These PHYs don't ignore c45 accesses correctly, thinking they are addressed themselves and distrupt the MDIO access. To avoid this, a blacklist for c45 scans is introduced. To: Heiner Kallweit To: Russell King To: "David S. Miller" To: Eric Dumazet To: Jakub Kicinski To: Paolo Abeni To: Felix Fietkau To: John Crispin To: Sean Wang To: Mark Lee To: Lorenzo Bianconi To: Matthias Brugger To: Bryan Whitehead To: UNGLinuxDriver@microchip.com To: Giuseppe Cavallaro To: Alexandre Torgue To: Jose Abreu To: Maxime Coquelin To: Joel Stanley To: Andrew Jeffery Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-aspeed@lists.ozlabs.org Cc: Andrew Lunn Signed-off-by: Michael Walle --- Andrew Lunn (6): net: mdio: Move mdiobus_scan() within file net: mdio: Rework scanning of bus ready for quirks net: mdio: Add workaround for Micrel PHYs which are not C45 compatible net: mdio: scan bus based on bus capabilities for C22 and C45 net: phy: Decide on C45 capabilities based on presence of method net: phy: Remove probe_capabilities drivers/net/ethernet/adi/adin1110.c | 1 - drivers/net/ethernet/freescale/xgmac_mdio.c | 1 - drivers/net/ethernet/marvell/pxa168_eth.c | 2 +- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 - drivers/net/ethernet/microchip/lan743x_main.c | 2 - drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 3 - drivers/net/mdio/mdio-aspeed.c | 1 - drivers/net/phy/mdio_bus.c | 194 +++++++++++++++------- drivers/net/phy/phy_device.c | 2 +- include/linux/micrel_phy.h | 2 + include/linux/phy.h | 10 +- 11 files changed, 138 insertions(+), 81 deletions(-) --- base-commit: c12e2e5b76b2e739ccdf196bee960412b45d5f85 change-id: 20230116-net-next-remove-probe-capabilities-03d401439fc6 Best regards,