Message ID | 20230115170623.3680647-1-hugo@hugovil.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp825765wrn; Sun, 15 Jan 2023 09:08:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXv0n46f+XeMw1TqHC59vrnRZtFQdicCsm50FjUvCuMX2fJkxSF4syP/LF4GIeAXW9utxaml X-Received: by 2002:a05:6402:916:b0:49e:4b8:f6ab with SMTP id g22-20020a056402091600b0049e04b8f6abmr3893908edz.8.1673802513101; Sun, 15 Jan 2023 09:08:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673802513; cv=none; d=google.com; s=arc-20160816; b=jrxtKRHH2saaTeemDV0uOpf74W0p67tFABrBWnhOCxV3akeNAjE/zH+ypjqaQnOQxi 5aW3A1uEPDI1COIBQVQ139LujQNiLM7EKWsHnT+2sfWal8FNxG5oyVwdakLtprcoxyNc i0tBL2hlZ9OGIYPvQ9VxFiTbSY+wFbt9LdjJVaSDB3cqxfbXRgLgnBb7g4ZZQ6aZoCAD qRi3MuRxZjtSRDAbzeVzCn8/+fOZDjleG6LmZivzt3EJbfZVp8xZp9ag9fG1ksxTOQob 9fWFX9ORYz3OXJiM8cD/8gNtqlUyJ52vD2FkCrh8FsLzIIO+e/YzAP0wNOVsNZyxS4xr IWuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=7oQjWizTIg0aveN7RKfxUj+dsq5MSKpbj01KTca2xQU=; b=LkpLe3FQLhL8yUsxldraE6fMlGp7auaWaI1IrK2PEVigH3XeUnoyuWFvWeGcGgcsto G9wZ4DXoC7H5R/GMbscq6pYVot3ZythWFAo/WhMB+vMjEMT9mVhdjNhuMnw/FR0cujK5 HUu7P2damUGHrkvSeWSIIAzX+bhVd6xVo5VFwpA9ZRwN/sM+HtZqDS8Wl0S4/VtQpcFI yoJJyvCxFnDrtxOhi2XCdhn2b/4Xhjk1RYhtQAfJM0D9ucg5lQ0/S2mJwyqIKblabyis fOuiDwJUmgFnrpDqc0Go0ulvgOOLksJNVcNG5EhbV4pKtiQY9ehXMmM0vL4PHYVMwKf8 QcGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=W8fzRgUb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fi11-20020a056402550b00b00499c424f683si14881676edb.223.2023.01.15.09.08.09; Sun, 15 Jan 2023 09:08:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=W8fzRgUb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231406AbjAORGg (ORCPT <rfc822;stefanalexe802@gmail.com> + 99 others); Sun, 15 Jan 2023 12:06:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231181AbjAORGf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 15 Jan 2023 12:06:35 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8EB3EC53; Sun, 15 Jan 2023 09:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=7oQjWizTIg0aveN7RKfxUj+dsq5MSKpbj01KTca2xQU=; b=W 8fzRgUbNzeYj4EWaHyfR2S4gJoedBU32aUtF7Qv9phxt1LJF2yobJptxMG20CRbRvdNRP4nGRWVwD mPFGNbpdvedFIM2hP5qf1rrYMKrR9jF/0hyP0MmSQHFQ/tWBqI73jkOPvyMZCZOEXJjgOxcg3ijO5 ChMLo75QzYEyYSTw=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:41198 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from <hugo@hugovil.com>) id 1pH6Sg-0008Cy-IR; Sun, 15 Jan 2023 12:06:27 -0500 From: Hugo Villeneuve <hugo@hugovil.com> To: hvilleneuve@dimonoff.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com Date: Sun, 15 Jan 2023 12:06:21 -0500 Message-Id: <20230115170623.3680647-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH v4 0/2] iio: adc: ti-ads7924: add Texas Instruments ADS7924 driver X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755109143948512789?= X-GMAIL-MSGID: =?utf-8?q?1755109143948512789?= |
Series |
iio: adc: ti-ads7924: add Texas Instruments ADS7924 driver
|
|
Message
Hugo Villeneuve
Jan. 15, 2023, 5:06 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Hello,
this patch series adds the driver for the Texas Instruments ADS7924.
The Texas Instruments ADS7924 is a 4 channels, 12-bit analog to
digital converter (ADC) with an I2C interface.
Patch 1 contains the driver for the ADS7924.
Patch 2 add the dt-bindings for the ADS7924.
I have tested the driver using the Texas Instruments ADS7924EVM board connected
to a Variscite Symphony EVK with a IMX8MN NANO SOM:
- Tested reset pin Ok
- Tested regulator setup Ok
- Tested reading sysfs in_voltage_scale Ok
- Tested reading sysfs in_voltageX_raw (x=0 to 3) Ok
Thank you.
Link: [v1] https://lore.kernel.org/linux-iio/20221222203610.2571287-1-hugo@hugovil.com/
Link: [v2] https://lore.kernel.org/linux-iio/20230110160124.3853593-1-hugo@hugovil.com/
Link: [v3] https://lore.kernel.org/linux-iio/20230113194959.3276433-1-hugo@hugovil.com/
Changes for V4:
- DT bindings: remove label description.
- Remove blank line between datasheet tag and SOB in commit message.
- Return value from regulator_get_voltage()
- Fix num_channels comparison (cannot be < 0)
- Change severity of message to dev_err in ads7924_set_conv_mode().
Changes for V3:
- Rebase on linux-6.2-rc1
- Refactor to follow usual coding practices as per review comments.
- Fix missing include (reported by kernel test robot).
- Fix DT bindings errors.
- Removed unused define.
- Remove breaks after return.
- Remove debug message in ads7924_get_channels_config().
- Remove braces around swich case IIO_CHAN_INFO_RAW.
- Remove comments about regulator_get_voltage() failing for dummy regulator.
Changes for V2:
- Dropped patch "iio: adc: Kconfig: add SPI interface mention to AD7924
description"
- Fixed comments style
- Removed unused defines/variables/etc related to buffered support (no buffered
support for the moment).
- Convert of-specific code to use the generic firmware property accessors in
include/linux/property.h.
- Use FIELD_GET / FIELD_PREP for bit operations/defines
- Simplified conversion result registers definitions/usage.
- Now using mutex lock/unlock only for INFO_RAW switch branch
- Use dev_err_probe() in all return paths of ads7924_probe()
- Removed ads7924_remove() after adding callbacks with
devm_add_action_or_reset().
- Change iio_device_register() to devm_iio_device_register().
- Add the legacy i2c_device_id table
- DT bindings: reorder entries, fix indentation,improve comments, add interrupt
line
Hugo Villeneuve (2):
iio: adc: ti-ads7924: add Texas Instruments ADS7924 driver
dt-bindings: iio: adc: add Texas Instruments ADS7924
.../bindings/iio/adc/ti,ads7924.yaml | 110 ++++
MAINTAINERS | 7 +
drivers/iio/adc/Kconfig | 11 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/ti-ads7924.c | 474 ++++++++++++++++++
5 files changed, 603 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml
create mode 100644 drivers/iio/adc/ti-ads7924.c
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
Comments
On Sun, 15 Jan 2023 12:06:21 -0500 Hugo Villeneuve <hugo@hugovil.com> wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Hello, > this patch series adds the driver for the Texas Instruments ADS7924. > > The Texas Instruments ADS7924 is a 4 channels, 12-bit analog to > digital converter (ADC) with an I2C interface. > > Patch 1 contains the driver for the ADS7924. > > Patch 2 add the dt-bindings for the ADS7924. > > I have tested the driver using the Texas Instruments ADS7924EVM board connected > to a Variscite Symphony EVK with a IMX8MN NANO SOM: > - Tested reset pin Ok > - Tested regulator setup Ok > - Tested reading sysfs in_voltage_scale Ok > - Tested reading sysfs in_voltageX_raw (x=0 to 3) Ok > > Thank you. > > Link: [v1] https://lore.kernel.org/linux-iio/20221222203610.2571287-1-hugo@hugovil.com/ > Link: [v2] https://lore.kernel.org/linux-iio/20230110160124.3853593-1-hugo@hugovil.com/ > Link: [v3] https://lore.kernel.org/linux-iio/20230113194959.3276433-1-hugo@hugovil.com/ Series applied to the togreg branch of iio.git and pushed out initially as testing for 0-day to work it's magic and see if it can find anything we missed! Thanks, Jonathan > > Changes for V4: > - DT bindings: remove label description. > - Remove blank line between datasheet tag and SOB in commit message. > - Return value from regulator_get_voltage() > - Fix num_channels comparison (cannot be < 0) > - Change severity of message to dev_err in ads7924_set_conv_mode(). > > Changes for V3: > - Rebase on linux-6.2-rc1 > - Refactor to follow usual coding practices as per review comments. > - Fix missing include (reported by kernel test robot). > - Fix DT bindings errors. > - Removed unused define. > - Remove breaks after return. > - Remove debug message in ads7924_get_channels_config(). > - Remove braces around swich case IIO_CHAN_INFO_RAW. > - Remove comments about regulator_get_voltage() failing for dummy regulator. > > Changes for V2: > - Dropped patch "iio: adc: Kconfig: add SPI interface mention to AD7924 > description" > - Fixed comments style > - Removed unused defines/variables/etc related to buffered support (no buffered > support for the moment). > - Convert of-specific code to use the generic firmware property accessors in > include/linux/property.h. > - Use FIELD_GET / FIELD_PREP for bit operations/defines > - Simplified conversion result registers definitions/usage. > - Now using mutex lock/unlock only for INFO_RAW switch branch > - Use dev_err_probe() in all return paths of ads7924_probe() > - Removed ads7924_remove() after adding callbacks with > devm_add_action_or_reset(). > - Change iio_device_register() to devm_iio_device_register(). > - Add the legacy i2c_device_id table > - DT bindings: reorder entries, fix indentation,improve comments, add interrupt > line > > Hugo Villeneuve (2): > iio: adc: ti-ads7924: add Texas Instruments ADS7924 driver > dt-bindings: iio: adc: add Texas Instruments ADS7924 > > .../bindings/iio/adc/ti,ads7924.yaml | 110 ++++ > MAINTAINERS | 7 + > drivers/iio/adc/Kconfig | 11 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/ti-ads7924.c | 474 ++++++++++++++++++ > 5 files changed, 603 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > create mode 100644 drivers/iio/adc/ti-ads7924.c > > > base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2