Message ID | 20230114132508.96600-1-fnkl.kernel@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp282694wrn; Sat, 14 Jan 2023 05:27:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXtIfjgMZ/9z3YkjIzmvDqLwMUxBoC/j0eGL0adVfKH25hj773KfagWPuG+0w/UcZsfn5usD X-Received: by 2002:aa7:9824:0:b0:58b:c873:54e1 with SMTP id q4-20020aa79824000000b0058bc87354e1mr2172735pfl.24.1673702849974; Sat, 14 Jan 2023 05:27:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673702849; cv=none; d=google.com; s=arc-20160816; b=hKkZYqkPPS9MAQL1hAhgmA1a2GUp3IQklqOQepzKOtfVkdrhVPsSXLCLp0QLMkR+Ro sYwOpsYCSJyRLk4RxTPqJmlaEpNqtak9J69CnCHXVUm0mvUROnZuVCmpSfNYBPG4daYt M7se7kBXOSmrEUmph98lXxGA/bypOJPOLFlmNKdxMk9bHZP7XhcDcUiEedmCWwqjxwDX yU1fkHSDKY4bXH5y5NqfYcMntJtUDo8n8pNnSjUqV59koqwi4nlqt2Q7M7VlVjDXDggN ZGsHa7VU7tNNMHMzgCwuxNUdz8fMZU3PSFWDcg3TDCdThQFvi1gDJbFUYBeue/KA7d0K t0Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g99//iPDMyFvy/+oL6QKSbCjazZl6KWjaU9oRhSg69A=; b=QmDa3uLYiMHqlDALeNmuDkgUGha6e4o9k7xKZlF8xfVuvOsDIKB433lE+9XvgpcCU9 f7Y8M25WAjKYRYo42Jfh6a6O4nG0bgR6wruklSsbIcuqBxUDukfV30YkGU6u83Qe6ryc Jnbju9QsQ73Yn8D/EJ1H7181UXJ00xfNDitrDZ9cF/pH5nwNq0VjgWOQUa2sdc7Tpchx ynN1ggEC1vd05dWpVXKY+yLug7ScsUn3I0ndQt7dTe1d15zRyWaAM0DPLRehqMf0b7+n p+Sc1B4yFKaIatkYbBIbszesZNURJCxgWTE0vsWoWg/5Ppkkm4AjOZ4oXZDoVEvm6WQW PUoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Qb7HH+w7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b4-20020a056a00114400b00577c17000dasi24473759pfm.166.2023.01.14.05.27.18; Sat, 14 Jan 2023 05:27:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Qb7HH+w7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbjANN0i (ORCPT <rfc822;limurcpp@gmail.com> + 99 others); Sat, 14 Jan 2023 08:26:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjANN0c (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 14 Jan 2023 08:26:32 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52C5659FD; Sat, 14 Jan 2023 05:26:31 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id bk16so23371823wrb.11; Sat, 14 Jan 2023 05:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=g99//iPDMyFvy/+oL6QKSbCjazZl6KWjaU9oRhSg69A=; b=Qb7HH+w7rp3xAgJR1Gpka6RuRPxxIMArkq/4xD/AB7fEVE8B4m4GoBFgPabInQxP24 DGKmJ/RNF0ofRA7EbLR0FltGrB0oHAjOS952ahiUaA38sxS7zJrL2y8l2OYlP+VKnFIT vJ1ieL8AhvquLoVyYHMJBg7Xmpm04JT+ACxPHRx0NxnznlK+xp9RYCtHVV5jkg4660Px kAMLrBX8wbiXOeAquft79WbwSiVN9BahjAa7fPabLMo/IvpAGKUK5cENcc8V4A4eatUx gxjTdBq0YBJQMDbYt2tI1JFiKb8lC3y4azvtL/dxpPBoeGosZO296wLAxZSPk5joGCb4 qaOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g99//iPDMyFvy/+oL6QKSbCjazZl6KWjaU9oRhSg69A=; b=7RI0sPHPBqFJej9YqWy4iM8Ywgh+PJbp+ksRBIpEbQVfVX/Q7Rj+M8XS1ZXhTLA5EX 4qz7X8VIXwNsSN0oOWaZ7CcOsYdIBv3kXt4qfkE3m0HQm+wEddXywK87TNcmxxkHvdSF BHLtrvGQgarnenicpORD0phzr0jG5GgnwPQVJyzOckgj3w52q8hhMY7iWM2psHRBc2Ss nDyHQEkNkPeu1HnruauO1ko7Y+ry0AQsQnR9xdKultSOQ/xKoCpQlfFHA9rLPdRhSPeG 1Q1LLLPC0unyNrtdLtn9bdQNAjKTD2r+NHE8RvB2AQ7TRfvCTKOTRrg4xnjyQSiN0kN4 J6IA== X-Gm-Message-State: AFqh2ko5Vwj6GipM+WYjn9wYI7TZesw9gdJjwjH2MXI9JLOjObCjk5LN QJyTK9gHYpOFEoNagoeIJR0w3q6rDiE= X-Received: by 2002:adf:f44f:0:b0:2bd:c6ce:7bf9 with SMTP id f15-20020adff44f000000b002bdc6ce7bf9mr10462091wrp.33.1673702789767; Sat, 14 Jan 2023 05:26:29 -0800 (PST) Received: from localhost ([176.234.9.57]) by smtp.gmail.com with UTF8SMTPSA id k6-20020a5d5186000000b002bbddb89c71sm17643370wrv.67.2023.01.14.05.26.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Jan 2023 05:26:29 -0800 (PST) From: Sasha Finkelstein <fnkl.kernel@gmail.com> To: u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Finkelstein <fnkl.kernel@gmail.com> Subject: [PATCH v7 0/5] PWM and keyboard backlight driver for ARM Macs Date: Sat, 14 Jan 2023 16:25:03 +0300 Message-Id: <20230114132508.96600-1-fnkl.kernel@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755004639190945993?= X-GMAIL-MSGID: =?utf-8?q?1755004639190945993?= |
Series |
PWM and keyboard backlight driver for ARM Macs
|
|
Message
Sasha Finkelstein
Jan. 14, 2023, 1:25 p.m. UTC
Hi, This is the v7 of the patch series to add PWM and keyboard backlight driver for ARM macs. No significant changes this time. Here is hoping that this time, the paint on this shed is up to everyone's standards. Changes in v1: Addressing the review comments. Changes in v2: Added the reviewed-by and acked-by tags. Addressing a review comment. Changes in v3 and v4: Addressing the review comments. Changes in v5: Added t600x device tree changes v1: https://www.spinics.net/lists/linux-pwm/msg19500.html v2: https://www.spinics.net/lists/linux-pwm/msg19562.html v3: https://www.spinics.net/lists/linux-pwm/msg19901.html v4: https://www.spinics.net/lists/linux-pwm/msg20093.html v5: https://www.spinics.net/lists/linux-pwm/msg20150.html v6: https://www.spinics.net/lists/linux-pwm/msg20190.html Sasha Finkelstein (5): dt-bindings: pwm: Add Apple PWM controller pwm: Add Apple PWM controller arm64: dts: apple: t8103: Add PWM controller arm64: dts: apple: t600x: Add PWM controller MAINTAINERS: Add entries for Apple PWM driver .../bindings/pwm/apple,s5l-fpwm.yaml | 51 ++++++ MAINTAINERS | 2 + arch/arm64/boot/dts/apple/t600x-die0.dtsi | 9 + .../arm64/boot/dts/apple/t600x-j314-j316.dtsi | 18 ++ arch/arm64/boot/dts/apple/t8103-j293.dts | 17 ++ arch/arm64/boot/dts/apple/t8103-j313.dts | 17 ++ arch/arm64/boot/dts/apple/t8103.dtsi | 9 + drivers/pwm/Kconfig | 12 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-apple.c | 159 ++++++++++++++++++ 10 files changed, 295 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml create mode 100644 drivers/pwm/pwm-apple.c
Comments
Hello, On Sat, Jan 14, 2023 at 04:25:05PM +0300, Sasha Finkelstein wrote: > Adds the Apple PWM controller driver. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > Acked-by: Sven Peter <sven@svenpeter.dev> > --- > drivers/pwm/Kconfig | 12 +++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-apple.c | 159 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 172 insertions(+) > create mode 100644 drivers/pwm/pwm-apple.c > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index dae023d783a2..8df861b1f4a3 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -51,6 +51,18 @@ config PWM_AB8500 > To compile this driver as a module, choose M here: the module > will be called pwm-ab8500. > > +config PWM_APPLE > + tristate "Apple SoC PWM support" > + depends on ARCH_APPLE || COMPILE_TEST > + help > + Generic PWM framework driver for PWM controller present on > + Apple SoCs > + > + Say Y here if you have an ARM Apple laptop, otherwise say N > + > + To compile this driver as a module, choose M here: the module > + will be called pwm-apple. > + > config PWM_ATMEL > tristate "Atmel PWM support" > depends on ARCH_AT91 || COMPILE_TEST > diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile > index 7bf1a29f02b8..19899b912e00 100644 > --- a/drivers/pwm/Makefile > +++ b/drivers/pwm/Makefile > @@ -2,6 +2,7 @@ > obj-$(CONFIG_PWM) += core.o > obj-$(CONFIG_PWM_SYSFS) += sysfs.o > obj-$(CONFIG_PWM_AB8500) += pwm-ab8500.o > +obj-$(CONFIG_PWM_APPLE) += pwm-apple.o > obj-$(CONFIG_PWM_ATMEL) += pwm-atmel.o > obj-$(CONFIG_PWM_ATMEL_HLCDC_PWM) += pwm-atmel-hlcdc.o > obj-$(CONFIG_PWM_ATMEL_TCB) += pwm-atmel-tcb.o > diff --git a/drivers/pwm/pwm-apple.c b/drivers/pwm/pwm-apple.c > new file mode 100644 > index 000000000000..551e07d49bf7 > --- /dev/null > +++ b/drivers/pwm/pwm-apple.c > @@ -0,0 +1,159 @@ > +// SPDX-License-Identifier: GPL-2.0 OR MIT > +/* > + * Driver for the Apple SoC PWM controller > + * > + * Copyright The Asahi Linux Contributors > + * > + * Limitations: > + * - The writes to cycle registers are shadowed until a write to > + * the control register. > + * - If both OFF_CYCLES and ON_CYCLES are set to 0, the output > + * is a constant off signal. > + * - When APPLE_PWM_CTRL is set to 0, the output is constant low > + */ > + > +#include <linux/module.h> > +#include <linux/platform_device.h> > +#include <linux/pwm.h> > +#include <linux/io.h> > +#include <linux/clk.h> > +#include <linux/math64.h> > + > +#define APPLE_PWM_CTRL 0x00 > +#define APPLE_PWM_ON_CYCLES 0x1c > +#define APPLE_PWM_OFF_CYCLES 0x18 > + > +#define APPLE_PWM_CTRL_ENABLE BIT(0) > +#define APPLE_PWM_CTRL_MODE BIT(2) > +#define APPLE_PWM_CTRL_UPDATE BIT(5) > +#define APPLE_PWM_CTRL_TRIGGER BIT(9) > +#define APPLE_PWM_CTRL_INVERT BIT(10) > +#define APPLE_PWM_CTRL_OUTPUT_ENABLE BIT(14) > + > +struct apple_pwm { > + struct pwm_chip chip; > + void __iomem *base; > + u64 clkrate; > +}; > + > +static inline struct apple_pwm *to_apple_pwm(struct pwm_chip *chip) > +{ > + return container_of(chip, struct apple_pwm, chip); > +} > + > +static int apple_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > + const struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + > + if (state->polarity == PWM_POLARITY_INVERSED) > + return -EINVAL; > + > + fpwm = to_apple_pwm(chip); > + if (state->enabled) { > + u64 on_cycles, off_cycles; > + > + on_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->duty_cycle, NSEC_PER_SEC); > + if (on_cycles > 0xFFFFFFFF) > + return -ERANGE; > + > + off_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->period, NSEC_PER_SEC) - on_cycles; > + if (off_cycles > 0xFFFFFFFF) > + return -ERANGE; > + > + writel(on_cycles, fpwm->base + APPLE_PWM_ON_CYCLES); > + writel(off_cycles, fpwm->base + APPLE_PWM_OFF_CYCLES); > + writel(APPLE_PWM_CTRL_ENABLE | APPLE_PWM_CTRL_OUTPUT_ENABLE | APPLE_PWM_CTRL_UPDATE, > + fpwm->base + APPLE_PWM_CTRL); > + } else { > + writel(0, fpwm->base + APPLE_PWM_CTRL); > + } > + return 0; > +} > + > +static int apple_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > + struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + u32 on_cycles, off_cycles, ctrl; > + > + fpwm = to_apple_pwm(chip); > + > + ctrl = readl(fpwm->base + APPLE_PWM_CTRL); > + on_cycles = readl(fpwm->base + APPLE_PWM_ON_CYCLES); > + off_cycles = readl(fpwm->base + APPLE_PWM_OFF_CYCLES); > + > + state->enabled = (ctrl & APPLE_PWM_CTRL_ENABLE) && (ctrl & APPLE_PWM_CTRL_OUTPUT_ENABLE); > + state->polarity = PWM_POLARITY_NORMAL; > + // on_cycles + off_cycles is 33 bits, NSEC_PER_SEC is 30, there is no overflow > + state->duty_cycle = DIV64_U64_ROUND_UP((u64)on_cycles * NSEC_PER_SEC, fpwm->clkrate); > + state->period = DIV64_U64_ROUND_UP(((u64)off_cycles + (u64)on_cycles) * > + NSEC_PER_SEC, fpwm->clkrate); > + > + return 0; > +} > + > +static const struct pwm_ops apple_pwm_ops = { > + .apply = apple_pwm_apply, > + .get_state = apple_pwm_get_state, > + .owner = THIS_MODULE, > +}; > + > +static int apple_pwm_probe(struct platform_device *pdev) > +{ > + struct apple_pwm *fpwm; > + struct clk *clk; > + int ret; > + > + fpwm = devm_kzalloc(&pdev->dev, sizeof(*fpwm), GFP_KERNEL); > + if (!fpwm) > + return -ENOMEM; > + > + fpwm->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(fpwm->base)) > + return PTR_ERR(fpwm->base); > + > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > + if (IS_ERR(clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(clk), "unable to get the clock"); > + I'd add a call to clk_rate_exclusive_get() here to justify that you determine clkrate here and don't recheck later (and also to make sure that your PWM output doesn't change for reasons out of your control). (Even though the rate might be fixed on your platform, doing it right for the benefit of people using your driver as a template is nice.) But I intend to go over the PWM drivers and add such a call where appropriate, so IMHO this doesn't need to delay application of this driver. > + /* > + * Uses the 24MHz system clock on all existing devices, can only > + * happen if the device tree is broken > + * > + * This check is done to prevent an overflow in .apply > + */ > + fpwm->clkrate = clk_get_rate(clk); > + if (fpwm->clkrate > NSEC_PER_SEC) > + return dev_err_probe(&pdev->dev, -EINVAL, "pwm clock out of range"); > + > + fpwm->chip.dev = &pdev->dev; > + fpwm->chip.npwm = 1; > + fpwm->chip.ops = &apple_pwm_ops; > + > + ret = devm_pwmchip_add(&pdev->dev, &fpwm->chip); > + if (ret < 0) > + return dev_err_probe(&pdev->dev, ret, "unable to add pwm chip"); > + > + return 0; > +} > + > +static const struct of_device_id apple_pwm_of_match[] = { > + { .compatible = "apple,s5l-fpwm" }, Out of interest: What does the f in fpwm stand for? Otherwise: Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> FTR: You resent v7, I'll discard that from patchwork in the expectation that Thierry will pick up the original v7.) Best regards Uwe
Hello, On Sat, Jan 14, 2023 at 04:25:05PM +0300, Sasha Finkelstein wrote: > +static int apple_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > + const struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + > + if (state->polarity == PWM_POLARITY_INVERSED) > + return -EINVAL; > + > + fpwm = to_apple_pwm(chip); > + if (state->enabled) { > + u64 on_cycles, off_cycles; > + > + on_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->duty_cycle, NSEC_PER_SEC); > + if (on_cycles > 0xFFFFFFFF) > + return -ERANGE; The idea is to configure the biggest duty_cycle that is not bigger than the requested duty_cycle. So don't return an error here, but use 0xffffffff instead. I should have catched that in my v4 and my v6 review, sorry, I missed that. Best regards Uwe