mbox series

[V10,0/2] SCM: Add support for wait-queue aware firmware

Message ID 20230113161114.22607-1-quic_sibis@quicinc.com
Headers
Series SCM: Add support for wait-queue aware firmware |

Message

Sibi Sankar Jan. 13, 2023, 4:11 p.m. UTC 
  This patch series enables the QCOM SCM driver to support firmware (FW) versions
that expect the high-level OS (HLOS) to be tolerant of SCM call requests not
being processed right away and, instead, being placed on a wait-queue in FW and
processed accordingly.

The problem this feature is fixing is as follows. In a scenario where there is
a VM in addition to HLOS (and an underlying hypervisor):

1. HLOS makes an SMC call on core 5
2. The hypervisor scheduling interrupt interrupts this SMC call.
3. The hypervisor schedules the VM on core 5.
4. The VM makes an SMC call on core 5.
5. The SMC call is non-interruptibly stuck on FW spinlock on core 5.
6. HLOS cannot reschedule since core 5 is not responding to Reschedule IPIs.
7. Watchdog timer expires waiting for core 5.

This problem is solved by FW returning a new return code SCM_WAITQ_SLEEP to
HLOS right away when it is overwhelmed by the VM's SMC call. HLOS then places
the call on a wait-queue and wakes it up when it receives an interrupt that
signifies "all-clear".

There are two new SMC calls also being defined in this design that, together
with one new return code, form the handshake protocol between Linux and FW.

This design is also backwards-compatible with existing firmware versions that
do not support this feature.

V10:
- Drop unused flags variable in quirk_handle_waitq [kernel test bot]

V9:
- Drop unused complete_all [Srini]

v8:
- Rename qcom_scm_lookup_wq to qcom_scm_assert_valid_wq_ctx [Bjorn] 
- Document wq_ctx limitations [Guru]
- Drop dev check and add include completion header [Srini]
- Rename qcom_scm_lookup_completion to qcom_scm_wait_for_wq_completion.

v7:
- Move lookup + wait_for_completion into a single function in qcom_scm [Bjorn]
- Simplify completion retrieval [Bjorn]

v6:
- Fix subject of bindings [Krzysztof]
- Update commit message to include the SoC supporting the feature [Krzysztof]
- Make the interrupt property valid on SM8450 SoC [Krzysztof]
- Fix misc. nits in the scm driver [Krzysztof]
- Rebased on Krzysztof's narrow clocks and interconnect series.

v5:
- Pick up R-b
- Handle the wake_one/wake_all flags [Guru]
- Rename flag handler to qcom_scm_waitq_wakeup [Bjorn]
- Resume scm call can return ebusy as well handle that scenario by retrying
  the original smc call and not the resume call

v4:
- platform_set_drvdata will be used by __scm_smc_do_quirk_handle_waitq to
  get access to scm struct from device so retain it
- Use a single completion as it satisfies all of the current usecases [Bjorn]
- Inline scm_get_wq_ctx [Bjorn]
- Convert all pr_err to dev_err [Bjorn]
- Handle idr_destroy in a thread safe manner [Bjorn]
- Misc. Style fixes [Bjorn]
- Qualify bindings [Krzysztoff]

v3:
- Drop allow-multi-call property since HLOS doesn't completely support it
  yet.
- Fixup irq handling so as not to affect SoCs without the interrupt.
- Fix warnings reported by kernel test-bot.

v2:
- Changes made to patches 4 and 5 are listed therein.
- Rebased dt-bindings on top of the YAML conversion patch [1].

Guru Das Srinagesh (2):
  dt-bindings: firmware: qcom,scm: Add optional interrupt
  firmware: qcom: scm: Add wait-queue handling logic

 .../bindings/firmware/qcom,scm.yaml           | 18 ++++
 drivers/firmware/qcom_scm-smc.c               | 86 ++++++++++++++++--
 drivers/firmware/qcom_scm.c                   | 90 ++++++++++++++++++-
 drivers/firmware/qcom_scm.h                   |  8 ++
 4 files changed, 194 insertions(+), 8 deletions(-)

Comments

Bjorn Andersson Jan. 19, 2023, 4:53 a.m. UTC | #1 
On Fri, 13 Jan 2023 21:41:12 +0530, Sibi Sankar wrote:
> This patch series enables the QCOM SCM driver to support firmware (FW) versions
> that expect the high-level OS (HLOS) to be tolerant of SCM call requests not
> being processed right away and, instead, being placed on a wait-queue in FW and
> processed accordingly.
> 
> The problem this feature is fixing is as follows. In a scenario where there is
> a VM in addition to HLOS (and an underlying hypervisor):
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: firmware: qcom,scm: Add optional interrupt
      commit: afb37e2577938bb854f20d428d8f29a01ea8bc93
[2/2] firmware: qcom: scm: Add wait-queue handling logic
      commit: 6bf32599223634294cdc6efb359ffaab1d68073c

Best regards,